Mirrors/inspec
2
0
Fork 0
mirror of https://github.com/inspec/inspec synced 2024-11-10 07:04:15 +00:00
Code Issues Projects Releases Packages Wiki Activity

CFINSPEC-94: Add unit test for introduced matchers and properties

Browse source 
Signed-off-by: Sonu Saha <sonu.saha@progress.com>
This commit is contained in:
Sonu Saha 2022-03-29 04:09:21 +05:30
parent 95a6ecca6b
commit 1a5c6c2772
5 changed files with 51 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/inspec/resources/users.rb
View file

@ -371,7 +371,7 @@ module Inspec::Resources
bin = find_getent_utility
# fetch details of the passwd file for the current user using getent
cmd = inspec.command("#{bin} passwd #{@username}")
cmd = inspec.command("#{bin} shadow #{@username}")
raise Inspec::Exceptions::ResourceSkipped, "Cannot view encrypted_password information" if cmd.exit_status != 0

1
test/fixtures/cmd/authorized-keys-mock vendored Normal file
View file

@ -0,0 +1 @@
ssh-ed25519 50m3r4nd0m57r1ng mockkey

1
test/fixtures/cmd/getent-shadow-mock vendored Normal file
View file

@ -0,0 +1 @@
root:!:19044:0:99999:7:::

3
test/helpers/mock_loader.rb
View file

@ -318,6 +318,9 @@ class MockLoader
"id root" => cmd.call("id-root"),
"getent passwd root" => cmd.call("getent-passwd-root"),
"chage -l root" => cmd.call("chage-l-root"),
"cat ~/.ssh/authorized_keys" => cmd.call("authorized-keys-mock"),
%{sh -c 'type "getent"'} => empty.call,
"getent shadow root" => cmd.call("getent-shadow-mock"),
# user information for ldap test
"id jfolmer" => cmd.call("id-jfolmer"),
"getent passwd jfolmer" => cmd.call("getent-passwd-jfolmer"),

68
test/unit/resources/user_test.rb
View file

@ -31,33 +31,55 @@ describe "Inspec::Resources::User" do
_(resource.warndays).must_equal 7
end
# serverspec compatibility tests (do not test matcher)
it "returns deprecation notices" do
# serverspec compatibility tests of introduced matchers and properties
it "serverspec compatibility tests on ubuntu" do
resource = MockLoader.new(:ubuntu).load_resource("user", "root")
_(resource.exists?).must_equal true
_(resource.has_uid?(0)).must_equal true
_(resource.belongs_to_primary_group?("root")).must_equal true
_(resource.belongs_to_group?("root")).must_equal true
_(resource.has_home_directory?("/root")).must_equal true
_(resource.has_login_shell?("/bin/bash")).must_equal true
_(resource.minimum_days_between_password_change).must_equal 0
_(resource.maximum_days_between_password_change).must_equal 99999
_(resource.has_authorized_key?("ssh-ed25519 50m3r4nd0m57r1ng mockkey")).must_equal true
_(resource.encrypted_password).must_equal "!"
end
expect_deprecation(:resource_user_serverspec_compat) do
_(resource.has_uid?(0)).must_equal true
end
it "serverspec compatibility tests on freebsd" do
resource = MockLoader.new(:freebsd11).load_resource("user", "fzipi")
_(resource.exists?).must_equal true
_(resource.has_uid?(1000)).must_equal true
_(resource.belongs_to_primary_group?("fzipi")).must_equal true
_(resource.belongs_to_group?("fzipi")).must_equal true
_(resource.has_home_directory?("/home/fzipi")).must_equal true
_(resource.has_login_shell?("/usr/local/bin/bash")).must_equal true
assert_nil(resource.minimum_days_between_password_change)
assert_nil(resource.maximum_days_between_password_change)
_(resource.has_authorized_key?("ssh-ed25519 50m3r4nd0m57r1ng mockkey")).must_equal true
end
expect_deprecation(:resource_user_serverspec_compat) do
_(resource.has_home_directory?("/root")).must_equal true
end
it "serverspec compatibility tests on OSX" do
resource = MockLoader.new(:macos10_10).load_resource("user", "chartmann")
_(resource.exists?).must_equal true
_(resource.has_uid?(501)).must_equal true
_(resource.belongs_to_primary_group?("staff")).must_equal true
_(resource.belongs_to_group?("com.apple.sharepoint.group.1")).must_equal true
_(resource.has_home_directory?("/Users/chartmann")).must_equal true
_(resource.has_login_shell?("/bin/zsh")).must_equal true
assert_nil(resource.minimum_days_between_password_change)
assert_nil(resource.maximum_days_between_password_change)
ex = _ { resource.encrypted_password }.must_raise(Inspec::Exceptions::ResourceSkipped)
_(ex.message).must_include "encrypted_password property is not applicable for your system"
_(resource.has_authorized_key?("ssh-ed25519 50m3r4nd0m57r1ng mockkey")).must_equal true
end
expect_deprecation(:resource_user_serverspec_compat) do
_(resource.has_login_shell?("/bin/bash")).must_equal true
end
expect_deprecation(:resource_user_serverspec_compat) do
_(resource.minimum_days_between_password_change).must_equal 0
end
expect_deprecation(:resource_user_serverspec_compat) do
_(resource.maximum_days_between_password_change).must_equal 99999
end
expect_deprecation(:resource_user_serverspec_compat) do
_(proc { resource.has_authorized_key?("abc") }).must_raise NotImplementedError
end
it "serverspec compatibility tests on windows" do
resource = MockLoader.new(:windows).load_resource("user", "administrator")
_(resource.exists?).must_equal true
_(resource.belongs_to_group?("Administrators")).must_equal true
ex = _ { resource.encrypted_password }.must_raise(Inspec::Exceptions::ResourceSkipped)
_(ex.message).must_include "encrypted_password property is not applicable for your system"
end
it "handles a password that has never changed" do