inspec/test/functional/inspec_exec_test.rb

925 lines
32 KiB
Ruby
Raw Normal View History

require "functional/helper"
2016-03-25 00:31:19 +00:00
describe "inspec exec" do
parallelize_me!
2016-03-25 00:31:19 +00:00
include FunctionalHelper
let(:looks_like_a_stacktrace) { %r{lib/inspec/.+\.rb:\d+:in} }
2016-03-25 00:31:19 +00:00
attr_accessor :out
def inspec(commandline, prefix = nil)
@stdout = @stderr = nil
self.out = super
end
def stdout
@stdout ||= out.stdout
.force_encoding(Encoding::UTF_8)
.gsub(/\e\[(\d+)(;\d+)*m/, "") # strip ANSI color codes
end
def stderr
@stderr ||= out.stderr
.force_encoding(Encoding::UTF_8)
.gsub(/\e\[(\d+)(;\d+)*m/, "") # strip ANSI color codes
end
before do
prof = "test/fixtures/profiles"
FileUtils.rm_f "#{prof}/aws-profile/inspec.lock"
FileUtils.rm_f "#{prof}/simple-inheritance/inspec.lock"
FileUtils.rm_f "#{prof}/simple-metadata/inspec.lock"
end
it "cleanly fails if mixing incompatible resource and transports" do
# TODO: I do not know how to test this more directly. It should be possible.
inspec "exec -t aws:// #{profile_path}/incompatible_resource_for_transport.rb"
_(stdout).must_be_empty
_(stderr).must_include "Unsupported resource/backend combination: file / aws. Exiting."
end
it "can execute the profile" do
inspec("exec " + example_profile + " --no-create-lockfile")
_(stdout).must_include " ✔ tmp-1.0: Create / directory\n"
_(stdout).must_include "
example-1.0: Verify the version number of Example (1 skipped)
Can't find file `/tmp/example/config.yaml`
"
if is_windows?
_(stdout).must_include " ↺ ssh-1: Allow only SSH Protocol 2\n"
_(stdout).must_include "\nProfile Summary: 1 successful control, 0 control failures, 2 controls skipped\n"
_(stdout).must_include "\nTest Summary: 3 successful, 0 failures, 2 skipped\n"
else
_(stdout).must_include " ✔ ssh-1: Allow only SSH Protocol 2\n"
_(stdout).must_include "\nProfile Summary: 2 successful controls, 0 control failures, 1 control skipped\n"
_(stdout).must_include "\nTest Summary: 4 successful, 0 failures, 1 skipped\n"
end
_(stderr).must_equal ""
assert_exit_code 101, out
2016-03-25 00:31:19 +00:00
end
it "executes a minimum metadata-only profile" do
inspec("exec " + File.join(profile_path, "simple-metadata") + " --no-create-lockfile")
_(stdout).must_equal "
2016-06-14 12:41:45 +00:00
Profile: yumyum profile
Version: (not specified)
2016-06-16 07:19:25 +00:00
Target: local://
2016-06-14 12:41:45 +00:00
No tests executed.
2016-06-14 12:41:45 +00:00
Test Summary: 0 successful, 0 failures, 0 skipped
2016-06-14 12:41:45 +00:00
"
_(stderr).must_equal ""
assert_exit_code 0, out
2016-03-25 00:31:19 +00:00
end
it "can execute the profile and write to directory" do
outpath = Dir.tmpdir
inspec("exec #{example_profile} --no-create-lockfile --reporter json:#{outpath}/foo/bar/test.json")
_(File.exist?("#{outpath}/foo/bar/test.json")).must_equal true
_(File.stat("#{outpath}/foo/bar/test.json").size).must_be :>, 0
_(stderr).must_equal ""
assert_exit_code 101, out
end
it "can execute --help after exec command" do
inspec("exec --help")
_(stdout).must_include "Usage:\n inspec exec LOCATIONS"
_(stderr).must_equal ""
assert_exit_code 0, out
end
it "can execute help after exec command" do
inspec("exec help")
_(stdout).must_include "Usage:\n inspec exec LOCATIONS"
_(stderr).must_equal ""
assert_exit_code 0, out
end
it "can execute help before exec command" do
inspec("help exec")
_(stdout).must_include "Usage:\n inspec exec LOCATIONS"
_(stderr).must_equal ""
assert_exit_code 0, out
end
it "can execute the profile with a target_id passthrough" do
inspec("exec #{example_profile} --no-create-lockfile --target-id 1d3e399f-4d71-4863-ac54-84d437fbc444")
_(stdout).must_include "Target ID: 1d3e399f-4d71-4863-ac54-84d437fbc444"
_(stderr).must_equal ""
assert_exit_code 101, out
end
it "executes a metadata-only profile" do
inspec("exec " + File.join(profile_path, "complete-metadata") + " --no-create-lockfile")
_(stdout).must_equal "
2016-06-14 12:41:45 +00:00
Profile: title (name)
Version: 1.2.3
2016-06-16 07:19:25 +00:00
Target: local://
2016-06-14 12:41:45 +00:00
No tests executed.
2016-06-14 12:41:45 +00:00
Test Summary: 0 successful, 0 failures, 0 skipped
2016-06-14 12:41:45 +00:00
"
_(stderr).must_equal ""
assert_exit_code 0, out
2016-03-25 00:31:19 +00:00
end
it "executes a profile and reads inputs" do
inspec("exec #{File.join(examples_path, "profile-attribute")} --no-create-lockfile --input-file #{File.join(examples_path, "profile-attribute.yml")}")
_(stdout).must_include "Test Summary: 2 successful, 0 failures, 0 skipped"
_(stderr).must_equal ""
assert_exit_code 0, out
end
it "executes a specs-only profile" do
inspec("exec " + File.join(profile_path, "spec_only") + " --no-create-lockfile")
_(stdout).must_include "Target: local://"
_(stdout).must_include "working"
_(stdout).must_include "✔ is expected to eq \"working\""
_(stdout).must_include "skippy\n"
_(stdout).must_include "↺ This will be skipped intentionally"
_(stdout).must_include "failing"
_(stdout).must_include "× is expected to eq \"as intended\""
_(stdout).must_include "Test Summary: 1 successful, 1 failure, 1 skipped\n"
_(stderr).must_equal ""
assert_exit_code 100, out
end
it "executes only specified controls when selecting passing controls by literal names" do
inspec("exec " + File.join(profile_path, "filter_table") + " --no-create-lockfile --controls 2943_pass_undeclared_field_in_hash 2943_pass_irregular_row_key")
_(stdout).must_include "\nProfile Summary: 2 successful controls, 0 control failures, 0 controls skipped\n"
_(stderr).must_equal ""
assert_exit_code 0, out
end
it "executes only specified controls when selecting failing controls by literal names" do
inspec("exec " + File.join(profile_path, "filter_table") + " --no-create-lockfile --controls 2943_fail_derail_check")
_(stdout).must_include "\nProfile Summary: 0 successful controls, 1 control failure, 0 controls skipped"
_(stderr).must_equal ""
assert_exit_code 100, out
end
it "executes only specified controls when selecting passing controls by regex" do
inspec("exec " + File.join(profile_path, "filter_table") + " --no-create-lockfile --controls '/^2943_pass/'")
_(stdout).must_include "Profile Summary: 6 successful controls, 0 control failures, 0 controls skipped"
assert_exit_code 0, out
end
it "executes only specified controls when selecting failing controls by regex" do
inspec("exec " + File.join(profile_path, "filter_table") + " --no-create-lockfile --controls '/^2943_fail/'")
_(stdout).must_include "Profile Summary: 0 successful controls, 1 control failure, 0 controls skipped"
_(stderr).must_equal ""
assert_exit_code 100, out
end
it "can execute a simple file with the default formatter" do
inspec("exec " + example_control + " --no-create-lockfile")
_(stdout).must_include "\nProfile Summary: 1 successful control, 0 control failures, 0 controls skipped\n"
_(stdout).must_include "\nTest Summary: 2 successful, 0 failures, 0 skipped\n"
_(stderr).must_equal ""
assert_exit_code 0, out
2016-03-25 00:31:19 +00:00
end
it "does not vendor profiles when using the a local path dependecy" do
Dir.mktmpdir do |tmpdir|
command = "exec " + inheritance_profile + " --no-create-lockfile"
inspec_with_env(command, INSPEC_CONFIG_DIR: tmpdir)
if is_windows?
_(stdout).must_include "Profile Summary: 0 successful controls, 0 control failures, 2 controls skipped\n"
_(stdout).must_include "Test Summary: 2 successful, 1 failure, 3 skipped\n"
else
_(stdout).must_include "Profile Summary: 1 successful control, 0 control failures, 1 control skipped\n"
_(stdout).must_include "Test Summary: 3 successful, 1 failure, 2 skipped\n"
end
cache_dir = File.join(tmpdir, "cache")
_(Dir.exist?(cache_dir)).must_equal true
_(Dir.glob(File.join(cache_dir, "**", "*"))).must_be_empty
_(stderr).must_equal ""
assert_exit_code 100, out
end
end
describe "with a profile that is not supported on this OS/platform" do
let(:out) { inspec("exec " + File.join(profile_path, "skippy-profile-os") + " --no-create-lockfile") }
let(:json) { JSON.load(stdout) }
it "exits with skip message" do
_(stdout).must_include("Skipping profile: 'skippy' on unsupported platform:")
_(stderr).must_equal ""
assert_exit_code 101, out
end
2016-04-17 00:04:10 +00:00
end
describe "with a profile that contains skipped controls" do
let(:out) { inspec("exec " + File.join(profile_path, "skippy-controls") + " --no-create-lockfile") }
let(:json) { JSON.load(stdout) }
2016-09-20 16:03:43 +00:00
it "exits with an error" do
_(stdout).must_include "skippy\n ↺ This will be skipped super intentionally.\n"
_(stdout).must_include " ↺ CONTROL database: MySQL Session\n ↺ Can't run MySQL SQL checks without authentication\n"
_(stdout).must_include "Profile Summary: 0 successful controls, 0 control failures, 2 controls skipped\nTest Summary: 0 successful, 0 failures, 2 skipped\n"
_(stderr).must_equal ""
assert_exit_code 101, out
2016-09-20 16:03:43 +00:00
end
end
describe "with a profile that contains skipped controls and the --no-distinct-exit flag" do
let(:out) { inspec("exec " + File.join(profile_path, "skippy-controls") + " --no-distinct-exit --no-create-lockfile") }
it "exits with code 0 and skipped tests in output" do
_(stdout).must_include "Profile Summary: 0 successful controls, 0 control failures, 2 controls skipped\nTest Summary: 0 successful, 0 failures, 2 skipped\n"
_(stderr).must_equal ""
assert_exit_code 0, out
end
end
describe "with a profile that contains failing controls and the --no-distinct-exit flag" do
let(:out) { inspec("exec " + File.join(profile_path, "failures") + " --no-distinct-exit --no-create-lockfile") }
it "exits with code 1" do
_(stdout).must_include "Profile Summary: 0 successful controls, 2 control failures, 0 controls skipped"
_(stderr).must_equal ""
assert_exit_code 1, out
end
end
describe "with a profile that contains skipped resources" do
let(:out) { inspec("exec " + File.join(profile_path, "aws-profile")) }
it "exits with an error" do
skip if ENV["NO_AWS"]
_(stdout).must_include "Unsupported resource/backend combination: aws_iam_users"
_(stdout).must_include "Unsupported resource/backend combination: aws_iam_access_keys"
_(stdout).must_include "Unsupported resource/backend combination: aws_s3_bucket"
_(stdout).must_include "3 failures"
assert_exit_code 100, out
end
end
describe "with a profile that is supported on this version of inspec" do
let(:out) { inspec("exec " + File.join(profile_path, "supported_inspec") + " --no-create-lockfile") }
it "exits cleanly" do
_(stderr).must_equal ""
assert_exit_code 0, out
end
end
describe "with a profile that is not supported on this version of inspec" do
let(:out) { inspec("exec " + File.join(profile_path, "unsupported_inspec") + " --no-create-lockfile") }
it "does not support this profile" do
_(stderr).must_equal "This profile requires Chef InSpec version >= 99.0.0. You are running Chef InSpec v#{Inspec::VERSION}.\n"
assert_exit_code 1, out
end
end
describe "with a profile that loads a library and reference" do
let(:out) { inspec("exec " + File.join(profile_path, "library") + " --no-create-lockfile") }
it "executes the profile without error" do
_(stderr).must_equal ""
assert_exit_code 0, out
end
end
describe "given a profile with controls and anonymous describe blocks" do
let(:out) { inspec("exec " + example_control + " --no-create-lockfile") }
it "prints the control results, then the anonymous describe block results" do
_(stdout).must_match(/Profile: tests from .*test.fixtures.profiles.old-examples.profile.controls.example-tmp.rb/)
_(stdout).must_include "
Version: (not specified)
Target: local://
\xE2\x9C\x94 tmp-1.0: Create / directory
\xE2\x9C\x94 File / is expected to be directory
File /
\xE2\x9C\x94 is expected to be directory
Profile Summary: 1 successful control, 0 control failures, 0 controls skipped
Test Summary: 2 successful, 0 failures, 0 skipped\n"
end
end
2016-09-01 12:25:56 +00:00
describe "given a profile with an anonymous describe block" do
let(:out) { inspec("exec " + failure_control + " --no-create-lockfile") }
2016-09-01 12:25:56 +00:00
it "prints the exception message when a test has a syntax error" do
_(stdout).must_include "undefined method `should_nota' "
2016-09-01 12:25:56 +00:00
end
end
2016-09-01 22:54:03 +00:00
describe "given an inherited profile that has more that one test per control block" do
let(:out) { inspec("exec " + simple_inheritance + " --no-create-lockfile") }
2016-09-01 22:54:03 +00:00
it "should print all the results" do
_(stdout).must_include "× tmp-1.0: Create / directory (1 failed)"
_(stdout).must_include "× is expected not to be directory\n"
_(stdout).must_include "× undefined method `should_nota'"
_(stdout).must_include "× is expected not to be directory\n expected `File /.directory?` to return false, got true"
_(stdout).must_include "× 7 is expected to cmp >= 9\n"
_(stdout).must_include "× 7 is expected not to cmp == /^\\d$/\n"
_(stdout).must_include "✔ 7 is expected to cmp == \"7\""
_(stdout).must_include "expected: %s" % ["01147"]
_(stdout).must_include "got: %s" % [is_windows? ? "040755" : "0755"]
2016-09-01 22:54:03 +00:00
end
end
describe "when passing in two profiles given an inherited profile that has more that one test per control block" do
let(:out) { inspec("exec " + File.join(profile_path, "dependencies", "profile_d") + " " + simple_inheritance + " --no-create-lockfile") }
it "should print all the results" do
_(stdout).must_include "× tmp-1.0: Create / directory (1 failed)"
_(stdout).must_include "× cmp-1.0: Using the cmp matcher for numbers (2 failed)"
_(stdout).must_include "× undefined method `should_nota'"
_(stdout).must_include "× is expected not to be directory\n expected `File /.directory?` to return false, got true"
_(stdout).must_include "✔ profiled-1: Create / directory (profile d)"
end
end
describe "given an inherited profile" do
let(:out) { inspec("exec " + simple_inheritance) }
it "should print the profile information and then the test results" do
_(stdout).must_include " × tmp-1.0: Create / directory (1 failed)\n ✔ File / is expected to be directory\n × File / is expected not to be directory\n"
end
end
describe "using namespaced resources" do
it "works" do
inspec("exec " + File.join(profile_path, "dependencies", "resource-namespace") + " --no-create-lockfile")
_(stdout).must_include "Profile Summary: 1 successful control, 0 control failures, 0 controls skipped\n"
_(stderr).must_equal ""
assert_exit_code 0, out
end
end
describe "with require_controls" do
it "does not run rules you did not include" do
inspec("exec " + File.join(profile_path, "dependencies", "require_controls_test") + " --no-create-lockfile")
_(stdout).must_include "Profile Summary: 1 successful control, 0 control failures, 0 controls skipped\n"
_(stderr).must_equal ""
assert_exit_code 0, out
end
end
describe "with a 2-level dependency tree" do
it "correctly runs tests from the whole tree" do
inspec("exec " + File.join(profile_path, "dependencies", "inheritance") + " --no-create-lockfile")
_(stdout).must_include "Profile Summary: 6 successful controls, 0 control failures, 0 controls skipped\n"
_(stderr).must_equal ""
assert_exit_code 0, out
end
end
describe "when using profiles on the supermarket" do
it "can run supermarket profiles directly from the command line" do
skip_windows! # can't modify /tmp -> / because it is in supermarket
inspec("exec supermarket://nathenharvey/tmp-compliance-profile --no-create-lockfile")
if is_windows?
_(stdout).must_include "Profile Summary: 1 successful control, 1 control failure, 0 controls skipped\n"
else
_(stdout).must_include "Profile Summary: 2 successful controls, 0 control failures, 0 controls skipped\n"
end
_(stderr).must_equal ""
if is_windows?
assert_exit_code 100, out # references root
else
assert_exit_code 0, out
end
end
it "can run supermarket profiles from inspec.yml" do
skip_windows! # can't modify /tmp -> / because it is in supermarket
inspec("exec #{File.join(profile_path, "supermarket-dep")} --no-create-lockfile")
if is_windows?
_(stdout).must_include "Profile Summary: 1 successful control, 1 control failure, 0 controls skipped\n"
else
_(stdout).must_include "Profile Summary: 2 successful controls, 0 control failures, 0 controls skipped\n"
end
_(stderr).must_equal ""
if is_windows?
assert_exit_code 1, out
else
assert_exit_code 0, out
end
end
end
describe "when a dependency does not support our backend platform" do
it "skips the controls from that profile" do
inspec("exec #{File.join(profile_path, "profile-support-skip")} --no-create-lockfile")
_(stdout).must_include "WARN: Skipping profile"
_(stdout).must_include "0 successful, 0 failures, 0 skipped\n"
_(stderr).must_equal ""
assert_exit_code 0, out
end
end
describe "when trying to use --sudo with a local target" do
it "must print an error and exit" do
inspec("exec #{File.join(profile_path, "profile-support-skip")} --sudo")
str = "Sudo is only valid when running against a remote host. To run this locally with elevated privileges, run the command with `sudo ...`.\n"
_(stderr).must_include str
assert_exit_code 1, out
# TODO: check for stacktrace
end
end
describe "when --no-color is used" do
it "does not output color control characters" do
inspec("exec " + File.join(profile_path, "simple-metadata") + " --no-color")
_(stdout).wont_include "\e[38"
_(stderr).must_equal ""
assert_exit_code 0, out
end
end
describe "when --password is used" do
it "raises an exception if no password is provided" do
inspec("exec " + example_profile + " --password")
_(stderr).must_include "Please provide a value for --password. For example: --password=hello."
assert_exit_code 1, out
end
end
describe "when --sudo-password is used" do
it "raises an exception if no sudo password is provided" do
inspec("exec " + example_profile + " --sudo-password")
_(stderr).must_include "Please provide a value for --sudo-password. For example: --sudo-password=hello."
assert_exit_code 1, out
end
end
describe "when --bastion-host and --proxy_command is used" do
it "raises an exception when both flags are provided" do
inspec("exec " + example_profile + " -t ssh://dummy@dummy --password dummy --proxy_command dummy --bastion_host dummy")
_(stderr).must_include "Client error, can't connect to 'ssh' backend: Only one of proxy_command or bastion_host needs to be specified"
assert_exit_code 1, out
end
end
describe "when --winrm-transport is used" do
it "raises an exception when an invalid transport is given" do
inspec("exec " + example_profile + " -t winrm://administrator@dummy --password dummy --winrm-transport nonesuch")
_(stderr).must_include "Client error, can't connect to 'winrm' backend: Unsupported transport type: :nonesuch\n"
assert_exit_code 1, out
end
end
describe "with sensitive resources" do
it "hides sensitive output" do
inspec("exec " + sensitive_profile + " --no-create-lockfile")
_(stdout).must_include '× is expected to eq "billy"'
_(stdout).must_include 'expected: "billy"'
_(stdout).must_include 'got: "bob"'
_(stdout).must_include '× is expected to eq "secret"'
_(stdout).must_include "*** sensitive output suppressed ***"
_(stdout).must_include "\nTest Summary: 2 successful, 2 failures, 0 skipped\n"
_(stderr).must_equal ""
assert_exit_code 100, out
end
end
describe "with a profile that loads dependencies" do
let(:out) { inspec("exec " + File.join(profile_path, "profile-support-skip") + " --no-create-lockfile --reporter json") }
let(:json) { JSON.load(stdout) }
let(:controls) { json["profiles"][0]["controls"] }
Inspec 3.0 (#3512) * Remove deprecated yumrepo. (#3435) * Remove deprecations for cli `--format` and metadata.rb (#3452) * Remove deprecated database_helpers stderr/stdout methods. Update deprecation text for processes/apache. * Remove deprecations for `--format` and metadata.rb Remove deprecated `format` code. Remove deprecated code test and change json-config format test to use reporter. Remove deprecated metadata.rb code Remove deprecation notice for old supports syntax. Deprecate metadata.rb from source_reader Remove rubocop disables as they are no longer required for this code block. Remove deprecated legacy metadata.rb mock profiles. Remove deprecated metadata.rb profile tests. Remove deprecated yumrepo test. * Allow inspec-3.0 branch to be tested. * Allow appveyor to test inspec-3.0 branch * Change runner tests to use reporter rather than format. Remove deprecated `supports: linux` tests. * Remove skip from inherited profiles from showing up in reporting (breaking change) (#3332) * Skip loading dependency profiles if they are unsupported on the current platform. Skip loading dependencies if they are unsupported on the current platform. Wrap our log and next in a conditional checking if the platform is supported. Change a `if !` into a `unless` Check if the backend is a Train Mock Connection and if so say that the profile does support the platform. While iterating through tests being loaded skip when the platform is unsupported. We now log a WARN when a profile is skipped due to unsupported platform, so lets check that. Modified existing test to log that there are 0 skipped tests, instead of 2. Add functional test that loads profile-support-skip with a json reporter to check that our controls are not loaded and that stderr contains our warning. * Rather than iterating through each test return before recursion if the platform is unsupported. * Resolve tests using a supported platform different from testing platform Add a control to `test/unit/mock/profiles/complete-profile` that would work on any OS with a Internet connection. This allows the profile to execute on any OS with success. `filesystem_spec.rb` was a control that would only work on Linux and some BSD's. We want profile tests to consistently work across development and testing platforms, and not get 'skipped' in some cases. Travis-CI tests on Linux, Inspec Dev team uses Linux and MacOS, Appveyor tests on Windows Also Updated `file_provider_test.rb` for `complete-profile` content changes. If you `MockLoader.load_profile` on a unsupported platform you might not hit the usual skip. Lets handle situations where the tests array in Profile#load_checks_params could be nil. * Use safe navigation rather than checking if tests is nil. Update tests to point to unsupported_inspec and account for WARN changes. Make unsupported_inspec profile support os-family 'unsupported_inspec' * Fix skip bug when using include/require controls. (#3487) * Fix skip bug when using include/require controls. * fix test and feedback. * Remove need for UUID detection for Automate report (#3507) * Add json metadata for skipped profiles (#3495) * Add skip metadata to json reports * Unify skip messages. * Update with status field. * Add testing. * Fix tests. * lint * Add skip exit codes for profile skips. * Update website for 3.0 launch Add `plugins` to sidebar. Change 2.0 -> 3.0 in slim files. Update 3.0 features list. * Fix comments * Update float to numeric. * Change Float to numeric. * updated feature list and impact doc * Change "What's new in InSpec 3.0" -> "Announcing InSpec 3.0" * Bump VERSION to 3.0.0 (#3511) * Remove 3.0 testing checks. * Fix azure link.
2018-10-15 22:25:27 +00:00
it "skips loaded inherited profiles on unsupported platforms" do
_(json["profiles"][0]["depends"][0]["name"]).must_equal "unsupported_inspec"
_(controls).must_be_empty
_(stderr).must_include "WARN: Skipping profile"
Inspec 3.0 (#3512) * Remove deprecated yumrepo. (#3435) * Remove deprecations for cli `--format` and metadata.rb (#3452) * Remove deprecated database_helpers stderr/stdout methods. Update deprecation text for processes/apache. * Remove deprecations for `--format` and metadata.rb Remove deprecated `format` code. Remove deprecated code test and change json-config format test to use reporter. Remove deprecated metadata.rb code Remove deprecation notice for old supports syntax. Deprecate metadata.rb from source_reader Remove rubocop disables as they are no longer required for this code block. Remove deprecated legacy metadata.rb mock profiles. Remove deprecated metadata.rb profile tests. Remove deprecated yumrepo test. * Allow inspec-3.0 branch to be tested. * Allow appveyor to test inspec-3.0 branch * Change runner tests to use reporter rather than format. Remove deprecated `supports: linux` tests. * Remove skip from inherited profiles from showing up in reporting (breaking change) (#3332) * Skip loading dependency profiles if they are unsupported on the current platform. Skip loading dependencies if they are unsupported on the current platform. Wrap our log and next in a conditional checking if the platform is supported. Change a `if !` into a `unless` Check if the backend is a Train Mock Connection and if so say that the profile does support the platform. While iterating through tests being loaded skip when the platform is unsupported. We now log a WARN when a profile is skipped due to unsupported platform, so lets check that. Modified existing test to log that there are 0 skipped tests, instead of 2. Add functional test that loads profile-support-skip with a json reporter to check that our controls are not loaded and that stderr contains our warning. * Rather than iterating through each test return before recursion if the platform is unsupported. * Resolve tests using a supported platform different from testing platform Add a control to `test/unit/mock/profiles/complete-profile` that would work on any OS with a Internet connection. This allows the profile to execute on any OS with success. `filesystem_spec.rb` was a control that would only work on Linux and some BSD's. We want profile tests to consistently work across development and testing platforms, and not get 'skipped' in some cases. Travis-CI tests on Linux, Inspec Dev team uses Linux and MacOS, Appveyor tests on Windows Also Updated `file_provider_test.rb` for `complete-profile` content changes. If you `MockLoader.load_profile` on a unsupported platform you might not hit the usual skip. Lets handle situations where the tests array in Profile#load_checks_params could be nil. * Use safe navigation rather than checking if tests is nil. Update tests to point to unsupported_inspec and account for WARN changes. Make unsupported_inspec profile support os-family 'unsupported_inspec' * Fix skip bug when using include/require controls. (#3487) * Fix skip bug when using include/require controls. * fix test and feedback. * Remove need for UUID detection for Automate report (#3507) * Add json metadata for skipped profiles (#3495) * Add skip metadata to json reports * Unify skip messages. * Update with status field. * Add testing. * Fix tests. * lint * Add skip exit codes for profile skips. * Update website for 3.0 launch Add `plugins` to sidebar. Change 2.0 -> 3.0 in slim files. Update 3.0 features list. * Fix comments * Update float to numeric. * Change Float to numeric. * updated feature list and impact doc * Change "What's new in InSpec 3.0" -> "Announcing InSpec 3.0" * Bump VERSION to 3.0.0 (#3511) * Remove 3.0 testing checks. * Fix azure link.
2018-10-15 22:25:27 +00:00
end
end
describe "with a profile containing exceptions in the controls" do
let(:out) { inspec("exec " + File.join(profile_path, "exception-in-control") + " --no-create-lockfile --reporter json") }
let(:json) { JSON.load(stdout) }
let(:controls) { json["profiles"][0]["controls"] }
it "completes the run with failed controls but no exception" do
_(stderr).must_be_empty
_(controls.count).must_equal 10
_(controls.select { |c| c["results"][0]["status"] == "failed" }.count).must_be :>, 1
_(controls.select { |c| c["results"][0]["status"] == "passed" }.count).must_be :>, 1
assert_exit_code 100, out
end
end
describe "with a profile containing control overrides" do
let(:out) { inspec("exec " + File.join(profile_path, "wrapper-override") + " --no-create-lockfile --vendor-cache " + File.join(profile_path, "wrapper-override", "vendor") + " --reporter json") }
let(:json) { JSON.load(stdout) }
let(:controls) { json["profiles"][0]["controls"] }
let(:child_profile) { json["profiles"].select { |p| p["name"] == "myprofile1" }.first }
let(:child_control) { child_profile["controls"].select { |c| c["title"] == "Profile 1 - Control 2-updated" }.first }
let(:override) { controls.select { |c| c["title"] == "Profile 1 - Control 2-updated" }.first }
it "completes the run with parent control overrides" do
_(stderr).must_be_empty
if is_windows?
assert_exit_code 100, out
else
assert_exit_code 0, out
end
_(controls.count).must_equal 2
# check for json override
# TODO: Brittle test expects the leading spaces.
expected_value = <<-END
control 'pro1-con2' do
impact 0.999
title 'Profile 1 - Control 2-updated'
desc 'Profile 1 - Control 2 description-updated'
desc 'overwrite me', 'it is overwritten'
desc 'new entry', 'this is appended to the description list'
tag 'password-updated'
ref 'Section 3.5.2.1', url: 'https://example.com'
describe file('/etc/passwd') do
it { should exist }
end
end
END
_(override["code"]).must_equal expected_value
_(override["impact"]).must_equal 0.999
_(override["descriptions"]).must_equal([
{ "label" => "default",
"data" => "Profile 1 - Control 2 description-updated",
},
{ "label" => "overwrite me",
"data" => "it is overwritten",
},
{ "label" => "new entry",
"data" => "this is appended to the description list",
},
])
_(override["title"]).must_equal "Profile 1 - Control 2-updated"
tags_assert = { "password" => nil, "password-updated" => nil }
_(override["tags"]).must_equal tags_assert
_(child_profile["parent_profile"]).must_equal "wrapper-override"
# check for original code on child profile
expected_value = <<~END
control 'pro1-con2' do
impact 0.9
title 'Profile 1 - Control 2'
desc 'Profile 1 - Control 2 description'
desc 'overwrite me', 'overwrite this'
tag 'password'
describe file('/etc/passwdddddddddd') do
it { should exist }
end
end
END
_(child_control["code"]).must_equal expected_value
_(stderr).must_be_empty
if is_windows?
assert_exit_code 100, out
else
assert_exit_code 0, out
end
end
end
describe "when using multiple custom resources with each other" do
let(:out) { inspec("exec " + File.join(examples_path, "custom-resource") + " --no-create-lockfile") }
it "completes the run with failed controls but no exception" do
_(stderr).must_be_empty
assert_exit_code 0, out
end
end
describe "when using a profile with non-UTF characters and wrong encoding" do
let(:out) { inspec("exec " + File.join(profile_path, "wrong-char-profile") + " --no-create-lockfile") }
it "completes the run with failed controls but no exception" do
_(stderr).must_be_empty
assert_exit_code 0, out
end
end
describe "when targeting private GitHub profiles" do
let(:private_profile) do
URI.parse("https://github.com/chef/inspec-test-profile-private.git")
end
# This tests requires that a private SSH key be provided for a user that has
# access to the private profile repo
if ENV["INSPEC_TEST_SSH_KEY_PATH"]
it "can use SSH + Git" do
target = "git@" + private_profile.host + ":" + private_profile.path
ssh_prefix = 'GIT_SSH_COMMAND="ssh -i ' +
ENV["INSPEC_TEST_SSH_KEY_PATH"] +
'"'
inspec_command = "exec " + target + " --reporter json-min"
inspec(inspec_command, ssh_prefix)
_(JSON.parse(stdout)["controls"][0]["status"]).must_equal "passed"
_(stderr).must_equal ""
assert_exit_code 0, out
end
end
# This tests requires that a GitHub API token be provided for a user that
# has access to the private profile repo
if ENV["INSPEC_TEST_GITHUB_TOKEN"]
it "can use HTTPS + token + Git" do
private_profile.userinfo = ENV["INSPEC_TEST_GITHUB_TOKEN"]
inspec_command = "exec " + private_profile.to_s + " --reporter json-min"
inspec(inspec_command)
_(JSON.parse(stdout)["controls"][0]["status"]).must_equal "passed"
_(stderr).must_equal ""
assert_exit_code 0, out
end
end
end
describe "when specifying a config file" do
let(:run_result) { run_inspec_process("exec " + File.join(profile_path, "simple-metadata") + " " + cli_args, json: true, env: env) }
let(:seen_target_id) { @json["platform"]["target_id"] }
let(:stderr) { run_result.stderr }
let(:env) { {} }
describe "when using the legacy --json-config option" do
let(:cli_args) { "--json-config " + File.join(config_dir_path, "json-config", "good.json") }
it "should see the custom target ID value" do
_(stderr).must_be_empty # TODO: one day deprecate the --json-config option
_(seen_target_id).must_equal "from-config-file"
end
end
describe "when using the --config option to read from a custom file" do
let(:cli_args) { "--config " + File.join(config_dir_path, "json-config", "good.json") }
it "should see the custom target ID value" do
_(stderr).must_be_empty
_(seen_target_id).must_equal "from-config-file"
end
end
unless windows?
describe "when using the --config option to read from STDIN" do
let(:json_path) { File.join(config_dir_path, "json-config", "good.json") }
let(:cli_args) { "--config -" }
let(:opts) { { prefix: "cat " + json_path + " | ", json: true, env: env } }
let(:njopts) { opts.merge(json: false) }
# DO NOT use the `let`-defined run_result through here
# If you do, it will execute twice, and cause STDIN to read empty on the second time
it "exec should see the custom target ID value" do
result = run_inspec_process( "exec " + File.join(profile_path, "simple-metadata") + " " + cli_args + " ", opts )
_(result.stderr).must_be_empty
_(@json["platform"]["target_id"]).must_equal "from-config-file"
end
it "detect should exit 0" do
result = run_inspec_process( "detect " + cli_args + " ", njopts )
_(result.stderr).must_be_empty
assert_exit_code 0, result
end
it "shell should exit 0" do
result = run_inspec_process( 'shell -c "platform.family" ' + cli_args + " ", njopts )
_(result.stderr).must_be_empty
assert_exit_code 0, result
end
end
end
describe "when reading from the default location" do
# Should read from File.join(config_dir_path, 'fakehome-2', '.inspec', 'config.json')
let(:env) { { "HOME" => File.join(config_dir_path, "fakehome-2") } }
let(:cli_args) { "" }
it "should see the homedir target ID value" do
_(stderr).must_be_empty
_(seen_target_id).must_equal "from-fakehome-config-file"
end
end
describe "when --config points to a nonexistant location" do
let(:cli_args) { "--config " + "no/such/path" }
it "should issue an error with the file path" do
_(stderr).wont_match looks_like_a_stacktrace
_(stderr).must_include "Could not read configuration file" # Should specify error
_(stderr).must_include "no/such/path" # Should include error value seen
assert_exit_code 1, run_result
end
end
describe "when --config points to a malformed file" do
let(:cli_args) { "--config " + File.join(config_dir_path, "json-config", "malformed.json") }
it "should issue an error with the parse message" do
_(stderr).wont_match looks_like_a_stacktrace
_(stderr).must_include "Failed to load JSON"
_(stderr).must_include "Config was:"
assert_exit_code 1, run_result
end
end
describe "when --config points to an invalid file" do
let(:cli_args) { "--config " + File.join(config_dir_path, "json-config", "invalid.json") }
it "should issue an error with the parse message" do
_(stderr).wont_match looks_like_a_stacktrace
_(stderr).must_include "Unrecognized top-level configuration"
_(stderr).must_include "this_key_is_invalid"
assert_exit_code 1, run_result
end
end
end
describe "when specifying the execution target" do
let(:local_plat) do
json = run_inspec_process("detect --format json", {}).stdout
# .slice is available in ruby 2.5+
JSON.parse(json).select { |k, v| %w{name release}.include? k }
end
let(:run_result) { run_inspec_process("exec " + File.join(profile_path, "simple-metadata") + " " + cli_args, json: true) }
let(:seen_platform) { run_result; @json["platform"].select { |k, v| %w{name release target_id}.include? k } }
let(:stderr) { run_result.stderr }
describe "when neither target nor backend is specified" do
let(:cli_args) { "" }
it "should connect to the local platform" do
_(seen_platform).must_equal local_plat
end
end
describe "when local:// is specified" do
let(:cli_args) { " -t local:// " }
it "should connect to the local platform" do
_(seen_platform).must_equal local_plat
end
end
describe "when an unrecognized backend is specified" do
let(:cli_args) { "-b garble " }
it "should exit with an error" do
_(stderr).wont_match looks_like_a_stacktrace
# "Can't find train plugin garble. Please install it first"
_(stderr).must_include "Can't find train plugin"
_(stderr).must_include "garble"
assert_exit_code 1, run_result
end
end
describe "when an unrecognized target schema is specified" do
let(:cli_args) { "-t garble:// " }
it "should exit with an error" do
_(stderr).wont_match looks_like_a_stacktrace
# "Can't find train plugin garble. Please install it first"
_(stderr).must_include "Can't find train plugin"
_(stderr).must_include "garble"
assert_exit_code 1, run_result
end
end
describe "when a schemaless URI is specified" do
let(:cli_args) { "-t garble " }
it "should exit with an error" do
_(stderr).wont_match looks_like_a_stacktrace
# "Could not recognize a backend from the target garble - use a URI
# format with the backend name as the URI schema. Example: 'ssh://somehost.com'
# or 'transport://credset' or 'transport://' if credentials are provided
# outside of InSpec."
_(stderr).must_include "Could not recognize a backend"
_(stderr).must_include "garble"
_(stderr).must_include "ssh://somehost.com"
_(stderr).must_include "transport://credset"
assert_exit_code 1, run_result
end
end
describe "when a target URI with a known credset is used" do
let(:cli_args) { "--target mock://mycredset" + " --config " + File.join(config_dir_path, "json-config", "mock-credset.json") }
it "should connect to the mock platform" do
_(seen_platform).must_equal({ "name" => "mock", "release" => "unknown", "target_id" => "from-mock-credset-config-file" })
end
end
end
2016-03-25 00:31:19 +00:00
end