Plugins API v2: Loader, Base API, and Test Harness (#3278)
* Functional tests for userdir option
* Accepts --config-dir CLI option
* Actually loads a config file from the config dir, more cases to test
* Able to load config and verify contents from config-dir
* Functional tests to ensure precedence for config options
* Enable setting config dir via env var
* .inspec, not .inspec.d
* Begin converting PluginCtl to PluginLoader/Registry
* Able to load and partially validate the plugins.json file
* More work on the plugin loader
* Break the world, move next gen stuff to plugin/
* Be sure to require base cli in bundled plugins
* Move test file
* Revert changes to v1 plugin, so we can have a separate one
* Checkpoint commit
* Move v2 plugin work to v2 area
* Move plugins v1 code into an isolated directory
* rubocop fixes
* Rip out the stuff about a user-dir config file, just use a plugin file
* Two psuedocode test file
* Working base API, moock plugin type, and loader.
* Adjust load path to be more welcoming
* Silence circular depencency warning, which was breaking a unit test
* Linting
* Fix plugin type registry, add tests to cover
* Feedback from Jerry
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2018-08-16 22:16:32 +00:00
|
|
|
# Unit tests for Inspec::PluginLoader and Registry
|
|
|
|
|
|
|
|
require 'minitest/autorun'
|
|
|
|
require 'minitest/test'
|
|
|
|
require_relative '../../../../lib/inspec/plugin/v2'
|
|
|
|
|
|
|
|
class PluginLoaderTests < MiniTest::Test
|
|
|
|
|
|
|
|
@@orig_home = Dir.home
|
|
|
|
|
|
|
|
def reset_globals
|
|
|
|
# These are effectively globals
|
|
|
|
Inspec::Plugin::V2::Registry.instance.__reset
|
|
|
|
ENV['HOME'] = @@orig_home
|
|
|
|
ENV['INSPEC_CONFIG_DIR'] = nil
|
|
|
|
end
|
|
|
|
|
|
|
|
def setup
|
|
|
|
reset_globals
|
|
|
|
|
|
|
|
repo_path = File.expand_path(File.join( __FILE__, '..', '..', '..', '..', '..'))
|
|
|
|
mock_path = File.join(repo_path, 'test', 'unit', 'mock')
|
|
|
|
|
|
|
|
@config_dir_path = File.join(mock_path, 'config_dirs')
|
|
|
|
@bundled_plugins = [
|
|
|
|
:artifact,
|
|
|
|
:compliance,
|
|
|
|
:supermarket,
|
|
|
|
]
|
2018-09-18 04:00:54 +00:00
|
|
|
@core_plugins = [
|
2018-09-18 17:10:07 +00:00
|
|
|
:'inspec-habitat',
|
2018-09-18 19:54:33 +00:00
|
|
|
:'inspec-init',
|
2018-09-18 04:00:54 +00:00
|
|
|
]
|
Plugins API v2: Loader, Base API, and Test Harness (#3278)
* Functional tests for userdir option
* Accepts --config-dir CLI option
* Actually loads a config file from the config dir, more cases to test
* Able to load config and verify contents from config-dir
* Functional tests to ensure precedence for config options
* Enable setting config dir via env var
* .inspec, not .inspec.d
* Begin converting PluginCtl to PluginLoader/Registry
* Able to load and partially validate the plugins.json file
* More work on the plugin loader
* Break the world, move next gen stuff to plugin/
* Be sure to require base cli in bundled plugins
* Move test file
* Revert changes to v1 plugin, so we can have a separate one
* Checkpoint commit
* Move v2 plugin work to v2 area
* Move plugins v1 code into an isolated directory
* rubocop fixes
* Rip out the stuff about a user-dir config file, just use a plugin file
* Two psuedocode test file
* Working base API, moock plugin type, and loader.
* Adjust load path to be more welcoming
* Silence circular depencency warning, which was breaking a unit test
* Linting
* Fix plugin type registry, add tests to cover
* Feedback from Jerry
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2018-08-16 22:16:32 +00:00
|
|
|
end
|
|
|
|
|
|
|
|
def teardown
|
|
|
|
reset_globals
|
|
|
|
end
|
|
|
|
|
|
|
|
#====================================================================#
|
|
|
|
# basic constructor usage and bundle detection #
|
|
|
|
#====================================================================#
|
|
|
|
|
|
|
|
def test_constructor_should_not_load_anything_automatically
|
|
|
|
reg = Inspec::Plugin::V2::Registry.instance
|
|
|
|
loader = Inspec::Plugin::V2::Loader.new
|
|
|
|
assert_equal 0, reg.loaded_count, "\nRegistry load count"
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_constructor_should_detect_bundled_plugins
|
|
|
|
reg = Inspec::Plugin::V2::Registry.instance
|
|
|
|
loader = Inspec::Plugin::V2::Loader.new
|
|
|
|
@bundled_plugins.each do |bundled_plugin_name|
|
|
|
|
assert reg.known_plugin?(bundled_plugin_name), "\n#{bundled_plugin_name} should be detected as a bundled plugin"
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-09-18 04:00:54 +00:00
|
|
|
def test_constructor_should_detect_core_plugins
|
|
|
|
reg = Inspec::Plugin::V2::Registry.instance
|
|
|
|
loader = Inspec::Plugin::V2::Loader.new
|
|
|
|
@core_plugins.each do |core_plugin_name|
|
|
|
|
assert reg.known_plugin?(core_plugin_name), "\n#{core_plugin_name} should be detected as a core plugin"
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
Plugins API v2: Loader, Base API, and Test Harness (#3278)
* Functional tests for userdir option
* Accepts --config-dir CLI option
* Actually loads a config file from the config dir, more cases to test
* Able to load config and verify contents from config-dir
* Functional tests to ensure precedence for config options
* Enable setting config dir via env var
* .inspec, not .inspec.d
* Begin converting PluginCtl to PluginLoader/Registry
* Able to load and partially validate the plugins.json file
* More work on the plugin loader
* Break the world, move next gen stuff to plugin/
* Be sure to require base cli in bundled plugins
* Move test file
* Revert changes to v1 plugin, so we can have a separate one
* Checkpoint commit
* Move v2 plugin work to v2 area
* Move plugins v1 code into an isolated directory
* rubocop fixes
* Rip out the stuff about a user-dir config file, just use a plugin file
* Two psuedocode test file
* Working base API, moock plugin type, and loader.
* Adjust load path to be more welcoming
* Silence circular depencency warning, which was breaking a unit test
* Linting
* Fix plugin type registry, add tests to cover
* Feedback from Jerry
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2018-08-16 22:16:32 +00:00
|
|
|
def test_constructor_should_skip_bundles_when_option_is_set
|
|
|
|
reg = Inspec::Plugin::V2::Registry.instance
|
|
|
|
loader = Inspec::Plugin::V2::Loader.new(omit_bundles: true)
|
|
|
|
@bundled_plugins.each do |bundled_plugin_name|
|
|
|
|
refute reg.known_plugin?(bundled_plugin_name), "\n#{bundled_plugin_name} should not be detected when omit_bundles is set"
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2018-09-18 04:00:54 +00:00
|
|
|
def test_constructor_should_skip_core_when_option_is_set
|
|
|
|
reg = Inspec::Plugin::V2::Registry.instance
|
|
|
|
loader = Inspec::Plugin::V2::Loader.new(omit_core_plugins: true)
|
|
|
|
@core_plugins.each do |core_plugin_name|
|
|
|
|
refute reg.known_plugin?(core_plugin_name), "\n#{core_plugin_name} should not be detected when omit_core_plugins is set"
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
Plugins API v2: Loader, Base API, and Test Harness (#3278)
* Functional tests for userdir option
* Accepts --config-dir CLI option
* Actually loads a config file from the config dir, more cases to test
* Able to load config and verify contents from config-dir
* Functional tests to ensure precedence for config options
* Enable setting config dir via env var
* .inspec, not .inspec.d
* Begin converting PluginCtl to PluginLoader/Registry
* Able to load and partially validate the plugins.json file
* More work on the plugin loader
* Break the world, move next gen stuff to plugin/
* Be sure to require base cli in bundled plugins
* Move test file
* Revert changes to v1 plugin, so we can have a separate one
* Checkpoint commit
* Move v2 plugin work to v2 area
* Move plugins v1 code into an isolated directory
* rubocop fixes
* Rip out the stuff about a user-dir config file, just use a plugin file
* Two psuedocode test file
* Working base API, moock plugin type, and loader.
* Adjust load path to be more welcoming
* Silence circular depencency warning, which was breaking a unit test
* Linting
* Fix plugin type registry, add tests to cover
* Feedback from Jerry
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2018-08-16 22:16:32 +00:00
|
|
|
def test_constructor_when_using_home_dir_detects_declared_plugins
|
|
|
|
ENV['HOME'] = File.join(@config_dir_path, 'fakehome')
|
|
|
|
reg = Inspec::Plugin::V2::Registry.instance
|
|
|
|
loader = Inspec::Plugin::V2::Loader.new
|
|
|
|
assert reg.known_plugin?(:'inspec-test-home-marker'), "\ninspec-test-home-marker should be detected as a plugin"
|
|
|
|
end
|
|
|
|
|
|
|
|
#====================================================================#
|
|
|
|
# unusual plugin.json situations #
|
|
|
|
#====================================================================#
|
|
|
|
|
|
|
|
def test_constructor_when_the_plugin_config_is_absent_it_detects_bundled_plugins
|
|
|
|
ENV['INSPEC_CONFIG_DIR'] = File.join(@config_dir_path, 'empty')
|
|
|
|
reg = Inspec::Plugin::V2::Registry.instance
|
|
|
|
loader = Inspec::Plugin::V2::Loader.new
|
|
|
|
@bundled_plugins.each do |bundled_plugin_name|
|
|
|
|
assert reg.known_plugin?(bundled_plugin_name), "\n#{bundled_plugin_name} should be detected as a bundled plugin"
|
|
|
|
end
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_constuctor_when_the_plugin_config_is_corrupt_it_throws_an_exception
|
|
|
|
ENV['INSPEC_CONFIG_DIR'] = File.join(@config_dir_path, 'corrupt')
|
|
|
|
assert_raises(Inspec::Plugin::V2::ConfigError) { Inspec::Plugin::V2::Loader.new }
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_constuctor_when_the_plugin_config_is_a_bad_version_it_throws_an_exception
|
|
|
|
ENV['INSPEC_CONFIG_DIR'] = File.join(@config_dir_path, 'bad_plugin_conf_version')
|
|
|
|
assert_raises(Inspec::Plugin::V2::ConfigError) { Inspec::Plugin::V2::Loader.new }
|
|
|
|
end
|
|
|
|
|
|
|
|
#====================================================================#
|
|
|
|
# basic loading #
|
|
|
|
#====================================================================#
|
|
|
|
|
|
|
|
def test_load_no_plugins_should_load_no_plugins
|
|
|
|
reg = Inspec::Plugin::V2::Registry.instance
|
2018-09-18 04:00:54 +00:00
|
|
|
loader = Inspec::Plugin::V2::Loader.new(omit_bundles: true, omit_core_plugins: true)
|
Plugins API v2: Loader, Base API, and Test Harness (#3278)
* Functional tests for userdir option
* Accepts --config-dir CLI option
* Actually loads a config file from the config dir, more cases to test
* Able to load config and verify contents from config-dir
* Functional tests to ensure precedence for config options
* Enable setting config dir via env var
* .inspec, not .inspec.d
* Begin converting PluginCtl to PluginLoader/Registry
* Able to load and partially validate the plugins.json file
* More work on the plugin loader
* Break the world, move next gen stuff to plugin/
* Be sure to require base cli in bundled plugins
* Move test file
* Revert changes to v1 plugin, so we can have a separate one
* Checkpoint commit
* Move v2 plugin work to v2 area
* Move plugins v1 code into an isolated directory
* rubocop fixes
* Rip out the stuff about a user-dir config file, just use a plugin file
* Two psuedocode test file
* Working base API, moock plugin type, and loader.
* Adjust load path to be more welcoming
* Silence circular depencency warning, which was breaking a unit test
* Linting
* Fix plugin type registry, add tests to cover
* Feedback from Jerry
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2018-08-16 22:16:32 +00:00
|
|
|
loader.load_all
|
|
|
|
assert_equal 0, reg.loaded_count, "\nRegistry load count"
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_load_only_bundled_plugins_should_load_bundled_plugins
|
|
|
|
skip 'This keeps failing, only affects legacy bundles, will fix later'
|
|
|
|
# Skip rationale: I beleive this test is failing due to a test artifact - we
|
|
|
|
# keep loading v1 CLI plugins and then purging the registry, which results (depending
|
|
|
|
# on test order) in the Ruby `require` refusing to re-load the v1 plugin (since it was
|
|
|
|
# previously loaded). But since we purge the Registry, the Registry doesn't know
|
|
|
|
# about it either. Neither of those things are intended to happen as
|
|
|
|
# the plugin system is finished (the v1 plugins will be ported to v2, and registry
|
|
|
|
# purging should never happen in real-world use)
|
|
|
|
reg = Inspec::Plugin::V2::Registry.instance
|
|
|
|
loader = Inspec::Plugin::V2::Loader.new
|
|
|
|
loader.load_all
|
|
|
|
@bundled_plugins.each do |bundled_plugin_name|
|
|
|
|
assert reg.loaded_plugin?(bundled_plugin_name), "\n#{bundled_plugin_name} should be loaded"
|
|
|
|
assert_equal [ :cli_command ], reg[bundled_plugin_name].plugin_types, "annotate plugin type of bundled plugins"
|
|
|
|
assert_equal 0, reg[bundled_plugin_name].api_generation, "annotate API generation of bundled plugins"
|
|
|
|
assert_kind_of(Class, reg[bundled_plugin_name].plugin_class)
|
|
|
|
end
|
|
|
|
assert_equal @bundled_plugins.count, reg.loaded_count, "\nRegistry load count"
|
|
|
|
end
|
|
|
|
|
|
|
|
def test_load_cli_plugin_by_path
|
|
|
|
ENV['INSPEC_CONFIG_DIR'] = File.join(@config_dir_path, 'meaning_by_path')
|
|
|
|
reg = Inspec::Plugin::V2::Registry.instance
|
|
|
|
plugin_name = :'inspec-meaning-of-life'
|
|
|
|
loader = Inspec::Plugin::V2::Loader.new(omit_bundles: true)
|
|
|
|
assert reg.known_plugin?(plugin_name), "\n#{plugin_name} should be a known plugin"
|
|
|
|
refute reg.loaded_plugin?(plugin_name), "\n#{plugin_name} should not be loaded yet"
|
|
|
|
loader.load_all
|
|
|
|
assert reg.loaded_plugin?(plugin_name), "\n#{plugin_name} should be loaded"
|
|
|
|
end
|
|
|
|
|
|
|
|
#====================================================================#
|
|
|
|
# activation #
|
|
|
|
#====================================================================#
|
|
|
|
def test_activation
|
|
|
|
# Setup
|
|
|
|
ENV['INSPEC_CONFIG_DIR'] = File.join(@config_dir_path, 'meaning_by_path')
|
|
|
|
registry = Inspec::Plugin::V2::Registry.instance
|
|
|
|
loader = Inspec::Plugin::V2::Loader.new(omit_bundles: true)
|
|
|
|
loader.load_all
|
|
|
|
status = registry[:'inspec-meaning-of-life']
|
|
|
|
|
|
|
|
# Management methods for activation
|
|
|
|
assert_respond_to status, :activators, 'A plugin status should respond to `activators`'
|
|
|
|
assert_respond_to registry, :find_activators, 'Registry should respond to `find_activators`'
|
|
|
|
assert_respond_to loader, :activate, 'Loader should respond to `activate`'
|
|
|
|
|
|
|
|
# Finding an Activator
|
|
|
|
assert_kind_of Array, status.activators, 'status should have an array for activators'
|
|
|
|
assert_kind_of Array, registry.find_activators(), 'find_activators should return an array'
|
|
|
|
assert_equal 'Inspec::Plugin::V2::Activator', registry.find_activators()[0].class.name, 'find_activators should return an array of Activators'
|
|
|
|
activator = registry.find_activators(plugin_type: :mock_plugin_type, name: :'meaning-of-life-the-universe-and-everything')[0]
|
|
|
|
refute_nil activator, 'find_activators should find the test activator'
|
|
|
|
[ :plugin_name, :plugin_type, :activator_name, :activated, :exception, :activation_proc, :implementation_class ].each do |method_name|
|
|
|
|
assert_respond_to activator, method_name
|
|
|
|
end
|
|
|
|
|
|
|
|
# Activation preconditions
|
|
|
|
refute activator.activated, 'Test activator should start out unactivated'
|
|
|
|
assert_nil activator.exception, 'Test activator should have no exception prior to activation'
|
|
|
|
assert_nil activator.implementation_class, 'Test activator should not know implementation class prior to activation'
|
|
|
|
refute InspecPlugins::MeaningOfLife.const_defined?(:MockPlugin), 'impl_class should not be defined prior to activation'
|
|
|
|
|
2018-09-18 04:00:54 +00:00
|
|
|
loader.activate(:mock_plugin_type, :'meaning-of-life-the-universe-and-everything')
|
Plugins API v2: Loader, Base API, and Test Harness (#3278)
* Functional tests for userdir option
* Accepts --config-dir CLI option
* Actually loads a config file from the config dir, more cases to test
* Able to load config and verify contents from config-dir
* Functional tests to ensure precedence for config options
* Enable setting config dir via env var
* .inspec, not .inspec.d
* Begin converting PluginCtl to PluginLoader/Registry
* Able to load and partially validate the plugins.json file
* More work on the plugin loader
* Break the world, move next gen stuff to plugin/
* Be sure to require base cli in bundled plugins
* Move test file
* Revert changes to v1 plugin, so we can have a separate one
* Checkpoint commit
* Move v2 plugin work to v2 area
* Move plugins v1 code into an isolated directory
* rubocop fixes
* Rip out the stuff about a user-dir config file, just use a plugin file
* Two psuedocode test file
* Working base API, moock plugin type, and loader.
* Adjust load path to be more welcoming
* Silence circular depencency warning, which was breaking a unit test
* Linting
* Fix plugin type registry, add tests to cover
* Feedback from Jerry
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2018-08-16 22:16:32 +00:00
|
|
|
|
|
|
|
# Activation postconditions
|
|
|
|
assert activator.activated, 'Test activator should be activated after activate'
|
|
|
|
assert_nil activator.exception, 'Test activator should have no exception after activation'
|
|
|
|
|
|
|
|
# facts about the implementation class
|
|
|
|
impl_class = activator.implementation_class
|
|
|
|
refute_nil impl_class, 'Activation should set the implementation class'
|
|
|
|
assert_kind_of Class, impl_class, 'Should have a Class in the implementation class slot'
|
|
|
|
assert_includes impl_class.ancestors, Inspec::Plugin::V2::PluginBase, 'impl_class should derive from PluginBase'
|
|
|
|
assert_includes impl_class.ancestors, Inspec::Plugin::V2::PluginType::Mock, 'impl_class should derive from PluginType::Mock'
|
|
|
|
assert InspecPlugins::MeaningOfLife.const_defined?(:MockPlugin), 'impl_class should now be defined'
|
|
|
|
|
|
|
|
end
|
2018-09-18 17:10:07 +00:00
|
|
|
end
|