mirror of
https://github.com/superseriousbusiness/gotosocial
synced 2024-12-23 11:13:12 +00:00
de6e3e5f2a
* refactor visibility checking, add caching for visibility * invalidate visibility cache items on account / status deletes * fix requester ID passed to visibility cache nil ptr * de-interface caches, fix home / public timeline caching + visibility * finish adding code comments for visibility filter * fix angry goconst linter warnings * actually finish adding filter visibility code comments for timeline functions * move home timeline status author check to after visibility * remove now-unused code * add more code comments * add TODO code comment, update printed cache start names * update printed cache names on stop * start adding separate follow(request) delete db functions, add specific visibility cache tests * add relationship type caching * fix getting local account follows / followed-bys, other small codebase improvements * simplify invalidation using cache hooks, add more GetAccountBy___() functions * fix boosting to return 404 if not boostable but no error (to not leak status ID) * remove dead code * improved placement of cache invalidation * update license headers * add example follow, follow-request config entries * add example visibility cache configuration to config file * use specific PutFollowRequest() instead of just Put() * add tests for all GetAccountBy() * add GetBlockBy() tests * update block to check primitive fields * update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests * fix copy-pasted code * update envparsing test * whitespace * fix bun struct tag * add license header to gtscontext * fix old license header * improved error creation to not use fmt.Errorf() when not needed * fix various rebase conflicts, fix account test * remove commented-out code, fix-up mention caching * fix mention select bun statement * ensure mention target account populated, pass in context to customrenderer logging * remove more uncommented code, fix typeutil test * add statusfave database model caching * add status fave cache configuration * add status fave cache example config * woops, catch missed error. nice catch linter! * add back testrig panic on nil db * update example configuration to match defaults, slight tweak to cache configuration defaults * update envparsing test with new defaults * fetch followingget to use the follow target account * use accounnt.IsLocal() instead of empty domain check * use constants for the cache visibility type check * use bun.In() for notification type restriction in db query * include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable()) * use bun query building for nested select statements to ensure working with postgres * update public timeline future status checks to match visibility filter * same as previous, for home timeline * update public timeline tests to dynamically check for appropriate statuses * migrate accounts to allow unique constraint on public_key * provide minimal account with publicKey --------- Signed-off-by: kim <grufwub@gmail.com> Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
165 lines
4.9 KiB
Go
165 lines
4.9 KiB
Go
// GoToSocial
|
|
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
|
// SPDX-License-Identifier: AGPL-3.0-or-later
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package visibility
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"time"
|
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/cache"
|
|
"github.com/superseriousbusiness/gotosocial/internal/gtscontext"
|
|
"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"
|
|
"github.com/superseriousbusiness/gotosocial/internal/log"
|
|
)
|
|
|
|
// StatusHomeTimelineable checks if given status should be included on owner's home timeline. Primarily relying on status visibility to owner and the AP visibility setting, but also taking into account thread replies etc.
|
|
func (f *Filter) StatusHomeTimelineable(ctx context.Context, owner *gtsmodel.Account, status *gtsmodel.Status) (bool, error) {
|
|
// By default we assume no auth.
|
|
requesterID := noauth
|
|
|
|
if owner != nil {
|
|
// Use provided account ID.
|
|
requesterID = owner.ID
|
|
}
|
|
|
|
visibility, err := f.state.Caches.Visibility.Load("Type.RequesterID.ItemID", func() (*cache.CachedVisibility, error) {
|
|
// Visibility not yet cached, perform timeline visibility lookup.
|
|
visible, err := f.isStatusHomeTimelineable(ctx, owner, status)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
// Return visibility value.
|
|
return &cache.CachedVisibility{
|
|
ItemID: status.ID,
|
|
RequesterID: requesterID,
|
|
Type: cache.VisibilityTypeHome,
|
|
Value: visible,
|
|
}, nil
|
|
}, "home", requesterID, status.ID)
|
|
if err != nil {
|
|
if err == cache.SentinelError {
|
|
// Filter-out our temporary
|
|
// race-condition error.
|
|
return false, nil
|
|
}
|
|
|
|
return false, err
|
|
}
|
|
|
|
return visibility.Value, nil
|
|
}
|
|
|
|
func (f *Filter) isStatusHomeTimelineable(ctx context.Context, owner *gtsmodel.Account, status *gtsmodel.Status) (bool, error) {
|
|
if status.CreatedAt.After(time.Now().Add(24 * time.Hour)) {
|
|
// Statuses made over 1 day in the future we don't show...
|
|
log.Warnf(ctx, "status >24hrs in the future: %+v", status)
|
|
return false, nil
|
|
}
|
|
|
|
// Check whether status is visible to timeline owner.
|
|
visible, err := f.StatusVisible(ctx, owner, status)
|
|
if err != nil {
|
|
return false, err
|
|
}
|
|
|
|
if !visible {
|
|
log.Trace(ctx, "status not visible to timeline owner")
|
|
return false, nil
|
|
}
|
|
|
|
if status.AccountID == owner.ID {
|
|
// Author can always see their status.
|
|
return true, nil
|
|
}
|
|
|
|
if status.MentionsAccount(owner.ID) {
|
|
// Can always see when you are mentioned.
|
|
return true, nil
|
|
}
|
|
|
|
var (
|
|
parent *gtsmodel.Status
|
|
included bool
|
|
oneAuthor bool
|
|
)
|
|
|
|
for parent = status; parent.InReplyToURI != ""; {
|
|
// Fetch next parent to lookup.
|
|
parentID := parent.InReplyToID
|
|
if parentID == "" {
|
|
log.Warnf(ctx, "status not yet deref'd: %s", parent.InReplyToURI)
|
|
return false, cache.SentinelError
|
|
}
|
|
|
|
// Get the next parent in the chain from DB.
|
|
parent, err = f.state.DB.GetStatusByID(
|
|
gtscontext.SetBarebones(ctx),
|
|
parentID,
|
|
)
|
|
if err != nil {
|
|
return false, fmt.Errorf("isStatusHomeTimelineable: error getting status parent %s: %w", parentID, err)
|
|
}
|
|
|
|
if (parent.AccountID == owner.ID) ||
|
|
parent.MentionsAccount(owner.ID) {
|
|
// Owner is in / mentioned in
|
|
// this status thread.
|
|
included = true
|
|
break
|
|
}
|
|
|
|
if oneAuthor {
|
|
// Check if this is a single-author status thread.
|
|
oneAuthor = (parent.AccountID == status.AccountID)
|
|
}
|
|
}
|
|
|
|
if parent != status && !included && !oneAuthor {
|
|
log.Trace(ctx, "ignoring visible reply to conversation thread excluding owner")
|
|
return false, nil
|
|
}
|
|
|
|
// At this point status is either a top-level status, a reply in a single
|
|
// author thread (e.g. "this is my weird-ass take and here is why 1/10 🧵"),
|
|
// or a thread mentioning / including timeline owner.
|
|
|
|
if status.Visibility == gtsmodel.VisibilityFollowersOnly ||
|
|
status.Visibility == gtsmodel.VisibilityMutualsOnly {
|
|
// Followers/mutuals only post that already passed the status
|
|
// visibility check, (i.e. we follow / mutuals with author).
|
|
return true, nil
|
|
}
|
|
|
|
// Ensure owner follows author of public/unlocked status.
|
|
follow, err := f.state.DB.IsFollowing(ctx,
|
|
owner.ID,
|
|
status.AccountID,
|
|
)
|
|
if err != nil {
|
|
return false, fmt.Errorf("isStatusHomeTimelineable: error checking follow %s->%s: %w", owner.ID, status.AccountID, err)
|
|
}
|
|
|
|
if !follow {
|
|
log.Trace(ctx, "ignoring visible status from unfollowed author")
|
|
return false, nil
|
|
}
|
|
|
|
return true, nil
|
|
}
|