mirror of
https://github.com/superseriousbusiness/gotosocial
synced 2024-11-23 21:03:19 +00:00
de6e3e5f2a
* refactor visibility checking, add caching for visibility * invalidate visibility cache items on account / status deletes * fix requester ID passed to visibility cache nil ptr * de-interface caches, fix home / public timeline caching + visibility * finish adding code comments for visibility filter * fix angry goconst linter warnings * actually finish adding filter visibility code comments for timeline functions * move home timeline status author check to after visibility * remove now-unused code * add more code comments * add TODO code comment, update printed cache start names * update printed cache names on stop * start adding separate follow(request) delete db functions, add specific visibility cache tests * add relationship type caching * fix getting local account follows / followed-bys, other small codebase improvements * simplify invalidation using cache hooks, add more GetAccountBy___() functions * fix boosting to return 404 if not boostable but no error (to not leak status ID) * remove dead code * improved placement of cache invalidation * update license headers * add example follow, follow-request config entries * add example visibility cache configuration to config file * use specific PutFollowRequest() instead of just Put() * add tests for all GetAccountBy() * add GetBlockBy() tests * update block to check primitive fields * update and finish adding Get{Account,Block,Follow,FollowRequest}By() tests * fix copy-pasted code * update envparsing test * whitespace * fix bun struct tag * add license header to gtscontext * fix old license header * improved error creation to not use fmt.Errorf() when not needed * fix various rebase conflicts, fix account test * remove commented-out code, fix-up mention caching * fix mention select bun statement * ensure mention target account populated, pass in context to customrenderer logging * remove more uncommented code, fix typeutil test * add statusfave database model caching * add status fave cache configuration * add status fave cache example config * woops, catch missed error. nice catch linter! * add back testrig panic on nil db * update example configuration to match defaults, slight tweak to cache configuration defaults * update envparsing test with new defaults * fetch followingget to use the follow target account * use accounnt.IsLocal() instead of empty domain check * use constants for the cache visibility type check * use bun.In() for notification type restriction in db query * include replies when fetching PublicTimeline() (to account for single-author threads in Visibility{}.StatusPublicTimelineable()) * use bun query building for nested select statements to ensure working with postgres * update public timeline future status checks to match visibility filter * same as previous, for home timeline * update public timeline tests to dynamically check for appropriate statuses * migrate accounts to allow unique constraint on public_key * provide minimal account with publicKey --------- Signed-off-by: kim <grufwub@gmail.com> Co-authored-by: tsmethurst <tobi.smethurst@protonmail.com>
259 lines
7 KiB
Go
259 lines
7 KiB
Go
// GoToSocial
|
|
// Copyright (C) GoToSocial Authors admin@gotosocial.org
|
|
// SPDX-License-Identifier: AGPL-3.0-or-later
|
|
//
|
|
// This program is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU Affero General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// This program is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU Affero General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU Affero General Public License
|
|
// along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
package bundb
|
|
|
|
import (
|
|
"context"
|
|
"time"
|
|
|
|
"github.com/superseriousbusiness/gotosocial/internal/db"
|
|
"github.com/superseriousbusiness/gotosocial/internal/gtsmodel"
|
|
"github.com/superseriousbusiness/gotosocial/internal/id"
|
|
"github.com/superseriousbusiness/gotosocial/internal/log"
|
|
"github.com/superseriousbusiness/gotosocial/internal/state"
|
|
"github.com/uptrace/bun"
|
|
"golang.org/x/exp/slices"
|
|
)
|
|
|
|
type timelineDB struct {
|
|
conn *DBConn
|
|
state *state.State
|
|
}
|
|
|
|
func (t *timelineDB) GetHomeTimeline(ctx context.Context, accountID string, maxID string, sinceID string, minID string, limit int, local bool) ([]*gtsmodel.Status, db.Error) {
|
|
// Ensure reasonable
|
|
if limit < 0 {
|
|
limit = 0
|
|
}
|
|
|
|
// Make educated guess for slice size
|
|
statusIDs := make([]string, 0, limit)
|
|
|
|
q := t.conn.
|
|
NewSelect().
|
|
TableExpr("? AS ?", bun.Ident("statuses"), bun.Ident("status")).
|
|
// Select only IDs from table
|
|
Column("status.id").
|
|
// Find out who accountID follows.
|
|
Join("LEFT JOIN ? AS ? ON ? = ? AND ? = ?",
|
|
bun.Ident("follows"),
|
|
bun.Ident("follow"),
|
|
bun.Ident("follow.target_account_id"),
|
|
bun.Ident("status.account_id"),
|
|
bun.Ident("follow.account_id"),
|
|
accountID).
|
|
// Sort by highest ID (newest) to lowest ID (oldest)
|
|
Order("status.id DESC")
|
|
|
|
if maxID == "" {
|
|
const future = 24 * time.Hour
|
|
|
|
var err error
|
|
|
|
// don't return statuses more than 24hr in the future
|
|
maxID, err = id.NewULIDFromTime(time.Now().Add(future))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
|
|
// return only statuses LOWER (ie., older) than maxID
|
|
q = q.Where("? < ?", bun.Ident("status.id"), maxID)
|
|
|
|
if sinceID != "" {
|
|
// return only statuses HIGHER (ie., newer) than sinceID
|
|
q = q.Where("? > ?", bun.Ident("status.id"), sinceID)
|
|
}
|
|
|
|
if minID != "" {
|
|
// return only statuses HIGHER (ie., newer) than minID
|
|
q = q.Where("? > ?", bun.Ident("status.id"), minID)
|
|
}
|
|
|
|
if local {
|
|
// return only statuses posted by local account havers
|
|
q = q.Where("? = ?", bun.Ident("status.local"), local)
|
|
}
|
|
|
|
if limit > 0 {
|
|
// limit amount of statuses returned
|
|
q = q.Limit(limit)
|
|
}
|
|
|
|
// Use a WhereGroup here to specify that we want EITHER statuses posted by accounts that accountID follows,
|
|
// OR statuses posted by accountID itself (since a user should be able to see their own statuses).
|
|
//
|
|
// This is equivalent to something like WHERE ... AND (... OR ...)
|
|
// See: https://bun.uptrace.dev/guide/queries.html#select
|
|
q = q.WhereGroup(" AND ", func(*bun.SelectQuery) *bun.SelectQuery {
|
|
return q.
|
|
WhereOr("? = ?", bun.Ident("follow.account_id"), accountID).
|
|
WhereOr("? = ?", bun.Ident("status.account_id"), accountID)
|
|
})
|
|
|
|
if err := q.Scan(ctx, &statusIDs); err != nil {
|
|
return nil, t.conn.ProcessError(err)
|
|
}
|
|
|
|
statuses := make([]*gtsmodel.Status, 0, len(statusIDs))
|
|
|
|
for _, id := range statusIDs {
|
|
// Fetch status from db for ID
|
|
status, err := t.state.DB.GetStatusByID(ctx, id)
|
|
if err != nil {
|
|
log.Errorf(ctx, "error fetching status %q: %v", id, err)
|
|
continue
|
|
}
|
|
|
|
// Append status to slice
|
|
statuses = append(statuses, status)
|
|
}
|
|
|
|
return statuses, nil
|
|
}
|
|
|
|
func (t *timelineDB) GetPublicTimeline(ctx context.Context, maxID string, sinceID string, minID string, limit int, local bool) ([]*gtsmodel.Status, db.Error) {
|
|
// Ensure reasonable
|
|
if limit < 0 {
|
|
limit = 0
|
|
}
|
|
|
|
// Make educated guess for slice size
|
|
statusIDs := make([]string, 0, limit)
|
|
|
|
q := t.conn.
|
|
NewSelect().
|
|
TableExpr("? AS ?", bun.Ident("statuses"), bun.Ident("status")).
|
|
Column("status.id").
|
|
Where("? = ?", bun.Ident("status.visibility"), gtsmodel.VisibilityPublic).
|
|
WhereGroup(" AND ", whereEmptyOrNull("status.boost_of_id")).
|
|
Order("status.id DESC")
|
|
|
|
if maxID == "" {
|
|
const future = 24 * time.Hour
|
|
|
|
var err error
|
|
|
|
// don't return statuses more than 24hr in the future
|
|
maxID, err = id.NewULIDFromTime(time.Now().Add(future))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
|
|
// return only statuses LOWER (ie., older) than maxID
|
|
q = q.Where("? < ?", bun.Ident("status.id"), maxID)
|
|
|
|
if sinceID != "" {
|
|
q = q.Where("? > ?", bun.Ident("status.id"), sinceID)
|
|
}
|
|
|
|
if minID != "" {
|
|
q = q.Where("? > ?", bun.Ident("status.id"), minID)
|
|
}
|
|
|
|
if local {
|
|
q = q.Where("? = ?", bun.Ident("status.local"), local)
|
|
}
|
|
|
|
if limit > 0 {
|
|
q = q.Limit(limit)
|
|
}
|
|
|
|
if err := q.Scan(ctx, &statusIDs); err != nil {
|
|
return nil, t.conn.ProcessError(err)
|
|
}
|
|
|
|
statuses := make([]*gtsmodel.Status, 0, len(statusIDs))
|
|
|
|
for _, id := range statusIDs {
|
|
// Fetch status from db for ID
|
|
status, err := t.state.DB.GetStatusByID(ctx, id)
|
|
if err != nil {
|
|
log.Errorf(ctx, "error fetching status %q: %v", id, err)
|
|
continue
|
|
}
|
|
|
|
// Append status to slice
|
|
statuses = append(statuses, status)
|
|
}
|
|
|
|
return statuses, nil
|
|
}
|
|
|
|
// TODO optimize this query and the logic here, because it's slow as balls -- it takes like a literal second to return with a limit of 20!
|
|
// It might be worth serving it through a timeline instead of raw DB queries, like we do for Home feeds.
|
|
func (t *timelineDB) GetFavedTimeline(ctx context.Context, accountID string, maxID string, minID string, limit int) ([]*gtsmodel.Status, string, string, db.Error) {
|
|
// Ensure reasonable
|
|
if limit < 0 {
|
|
limit = 0
|
|
}
|
|
|
|
// Make educated guess for slice size
|
|
faves := make([]*gtsmodel.StatusFave, 0, limit)
|
|
|
|
fq := t.conn.
|
|
NewSelect().
|
|
Model(&faves).
|
|
Where("? = ?", bun.Ident("status_fave.account_id"), accountID).
|
|
Order("status_fave.id DESC")
|
|
|
|
if maxID != "" {
|
|
fq = fq.Where("? < ?", bun.Ident("status_fave.id"), maxID)
|
|
}
|
|
|
|
if minID != "" {
|
|
fq = fq.Where("? > ?", bun.Ident("status_fave.id"), minID)
|
|
}
|
|
|
|
if limit > 0 {
|
|
fq = fq.Limit(limit)
|
|
}
|
|
|
|
err := fq.Scan(ctx)
|
|
if err != nil {
|
|
return nil, "", "", t.conn.ProcessError(err)
|
|
}
|
|
|
|
if len(faves) == 0 {
|
|
return nil, "", "", db.ErrNoEntries
|
|
}
|
|
|
|
// Sort by favourite ID rather than status ID
|
|
slices.SortFunc(faves, func(a, b *gtsmodel.StatusFave) bool {
|
|
return a.ID > b.ID
|
|
})
|
|
|
|
statuses := make([]*gtsmodel.Status, 0, len(faves))
|
|
|
|
for _, fave := range faves {
|
|
// Fetch status from db for corresponding favourite
|
|
status, err := t.state.DB.GetStatusByID(ctx, fave.StatusID)
|
|
if err != nil {
|
|
log.Errorf(ctx, "error fetching status for fave %q: %v", fave.ID, err)
|
|
continue
|
|
}
|
|
|
|
// Append status to slice
|
|
statuses = append(statuses, status)
|
|
}
|
|
|
|
nextMaxID := faves[len(faves)-1].ID
|
|
prevMinID := faves[0].ID
|
|
return statuses, nextMaxID, prevMinID, nil
|
|
}
|