Mirrors/gophish
2
0
Fork 0
mirror of https://github.com/gophish/gophish synced 2024-11-14 00:07:19 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix code quality issues (#2118)

Browse source
This commit is contained in:
Shubhendra Singh Chauhan 2021-02-25 05:04:38 +05:30 committed by GitHub
parent e6533e9993
commit 15303e32cf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
controllers/route.go
View file

@ -301,7 +301,7 @@ func (as *AdminServer) nextOrIndex(w http.ResponseWriter, r *http.Request) {
next = path
}
}
http.Redirect(w, r, next, 302)
http.Redirect(w, r, next, http.StatusFound)
}
func (as *AdminServer) handleInvalidLogin(w http.ResponseWriter, r *http.Request, message string) {
@ -386,7 +386,7 @@ func (as *AdminServer) Login(w http.ResponseWriter, r *http.Request) {
as.handleInvalidLogin(w, r, "Invalid Username/Password")
return
}
if u.AccountLocked == true {
if u.AccountLocked {
as.handleInvalidLogin(w, r, "Account Locked")
return
}

2
imap/monitor.go
View file

@ -174,7 +174,7 @@ func checkForNewEmails(im models.IMAP) {
log.Error("Error updating GoPhish email with rid ", rid, ": ", err.Error())
continue
}
if im.DeleteReportedCampaignEmail == true {
if im.DeleteReportedCampaignEmail {
deleteEmails = append(deleteEmails, m.SeqNum)
}
}

2
middleware/ratelimit/ratelimit.go
View file

@ -91,7 +91,7 @@ func (limiter *PostLimiter) Cleanup() {
limiter.Lock()
defer limiter.Unlock()
for ip, bucket := range limiter.visitors {
if time.Now().Sub(bucket.lastSeen) >= limiter.expiry {
if time.Since(bucket.lastSeen) >= limiter.expiry {
delete(limiter.visitors, ip)
}
}

2
models/email_request.go
View file

@ -144,7 +144,7 @@ func (s *EmailRequest) Generate(msg *gomail.Message) error {
log.Error(err)
}
// don't set the Subject header if it is blank
if len(subject) != 0 {
if subject != "" {
msg.SetHeader("Subject", subject)
}

2
models/maillog.go
View file

@ -215,7 +215,7 @@ func (m *MailLog) Generate(msg *gomail.Message) error {
log.Warn(err)
}
// don't set Subject header if the subject is empty
if len(subject) != 0 {
if subject != "" {
msg.SetHeader("Subject", subject)
}