fish-shell/printf/src/arg.rs
Peter Ammon 974ad882fa
Clean up fish-printf in preparation for publishing
Make fish-printf no longer depend on the widestring crate, as other clients
won't use it; instead this is an optional feature.

Make format strings a generic type, so that both narrow and wide strings can
serve. This removes a lot of the complexity around converting from narrow to
wide.

Add a README.md to this crate.
2024-09-21 17:52:11 -07:00

252 lines
7.5 KiB
Rust

use super::printf_impl::Error;
use std::result::Result;
#[cfg(feature = "widestring")]
use widestring::{Utf32Str as wstr, Utf32String as WString};
/// Printf argument types.
/// Note no implementation of `ToArg` constructs the owned variants (String and WString);
/// callers can do so explicitly.
#[derive(Debug, PartialEq)]
pub enum Arg<'a> {
Str(&'a str),
#[cfg(feature = "widestring")]
WStr(&'a wstr),
String(String),
#[cfg(feature = "widestring")]
WString(WString),
UInt(u64),
SInt(i64, u8), // signed integers track their width as the number of bits
Float(f64),
USizeRef(&'a mut usize), // for use with %n
}
impl<'a> Arg<'a> {
pub fn set_count(&mut self, count: usize) -> Result<(), Error> {
match self {
Arg::USizeRef(p) => **p = count,
_ => return Err(Error::BadArgType),
}
Ok(())
}
// Convert this to a narrow string, using the provided storage if necessary.
// In practice 'storage' is only used if the widestring feature is enabled.
#[allow(unused_variables, clippy::ptr_arg)]
pub fn as_str<'s>(&'s self, storage: &'s mut String) -> Result<&'s str, Error>
where
'a: 's,
{
match self {
Arg::Str(s) => Ok(s),
Arg::String(s) => Ok(s),
#[cfg(feature = "widestring")]
Arg::WStr(s) => {
storage.clear();
storage.extend(s.chars());
Ok(storage)
}
#[cfg(feature = "widestring")]
Arg::WString(s) => {
storage.clear();
storage.extend(s.chars());
Ok(storage)
}
_ => Err(Error::BadArgType),
}
}
// Return this value as an unsigned integer. Negative signed values will report overflow.
pub fn as_uint(&self) -> Result<u64, Error> {
match *self {
Arg::UInt(u) => Ok(u),
Arg::SInt(i, _w) => i.try_into().map_err(|_| Error::Overflow),
_ => Err(Error::BadArgType),
}
}
// Return this value as a signed integer. Unsigned values > i64::MAX will report overflow.
pub fn as_sint(&self) -> Result<i64, Error> {
match *self {
Arg::UInt(u) => u.try_into().map_err(|_| Error::Overflow),
Arg::SInt(i, _w) => Ok(i),
_ => Err(Error::BadArgType),
}
}
// If this is a signed value, then return the sign (true if negative) and the magnitude,
// masked to the value's width. This allows for e.g. -1 to be returned as 0xFF, 0xFFFF, etc.
// depending on the original width.
// If this is an unsigned value, simply return (false, u64).
pub fn as_wrapping_sint(&self) -> Result<(bool, u64), Error> {
match *self {
Arg::UInt(u) => Ok((false, u)),
Arg::SInt(i, w) => {
// Need to shift twice in case w is 64.
debug_assert!(w > 0);
let mask = ((1u64 << (w - 1)) << 1).wrapping_sub(1);
let ui = (i as u64) & mask;
Ok((i < 0, ui))
}
_ => Err(Error::BadArgType),
}
}
// Note we allow passing ints as floats, even allowing precision loss.
pub fn as_float(&self) -> Result<f64, Error> {
#[allow(clippy::cast_precision_loss)]
match *self {
Arg::Float(f) => Ok(f),
Arg::UInt(u) => Ok(u as f64),
Arg::SInt(i, _w) => Ok(i as f64),
_ => Err(Error::BadArgType),
}
}
pub fn as_char(&self) -> Result<char, Error> {
let v: u32 = self.as_uint()?.try_into().map_err(|_| Error::Overflow)?;
v.try_into().map_err(|_| Error::Overflow)
}
}
/// Conversion from a raw value to a printf argument.
pub trait ToArg<'a> {
fn to_arg(self) -> Arg<'a>;
}
impl<'a> ToArg<'a> for &'a str {
fn to_arg(self) -> Arg<'a> {
Arg::Str(self)
}
}
impl<'a> ToArg<'a> for &'a String {
fn to_arg(self) -> Arg<'a> {
Arg::Str(self)
}
}
#[cfg(feature = "widestring")]
impl<'a> ToArg<'a> for &'a wstr {
fn to_arg(self) -> Arg<'a> {
Arg::WStr(self)
}
}
#[cfg(feature = "widestring")]
impl<'a> ToArg<'a> for &'a WString {
fn to_arg(self) -> Arg<'a> {
Arg::WStr(self)
}
}
impl<'a> ToArg<'a> for f32 {
fn to_arg(self) -> Arg<'a> {
Arg::Float(self.into())
}
}
impl<'a> ToArg<'a> for f64 {
fn to_arg(self) -> Arg<'a> {
Arg::Float(self)
}
}
impl<'a> ToArg<'a> for char {
fn to_arg(self) -> Arg<'a> {
Arg::UInt((self as u32).into())
}
}
impl<'a> ToArg<'a> for &'a mut usize {
fn to_arg(self) -> Arg<'a> {
Arg::USizeRef(self)
}
}
impl<'a, T> ToArg<'a> for &'a *const T {
fn to_arg(self) -> Arg<'a> {
Arg::UInt((*self) as usize as u64)
}
}
/// All signed types.
macro_rules! impl_to_arg {
($($t:ty),*) => {
$(
impl<'a> ToArg<'a> for $t {
fn to_arg(self) -> Arg<'a> {
Arg::SInt(self as i64, <$t>::BITS as u8)
}
}
)*
};
}
impl_to_arg!(i8, i16, i32, i64, isize);
/// All unsigned types.
macro_rules! impl_to_arg_u {
($($t:ty),*) => {
$(
impl<'a> ToArg<'a> for $t {
fn to_arg(self) -> Arg<'a> {
Arg::UInt(self as u64)
}
}
)*
};
}
impl_to_arg_u!(u8, u16, u32, u64, usize);
#[cfg(test)]
mod tests {
use super::*;
#[cfg(feature = "widestring")]
use widestring::utf32str;
#[test]
fn test_to_arg() {
const SIZE_WIDTH: u8 = isize::BITS as u8;
assert!(matches!("test".to_arg(), Arg::Str("test")));
assert!(matches!(String::from("test").to_arg(), Arg::Str(_)));
#[cfg(feature = "widestring")]
assert!(matches!(utf32str!("test").to_arg(), Arg::WStr(_)));
#[cfg(feature = "widestring")]
assert!(matches!(WString::from("test").to_arg(), Arg::WStr(_)));
assert!(matches!(42f32.to_arg(), Arg::Float(_)));
assert!(matches!(42f64.to_arg(), Arg::Float(_)));
assert!(matches!('x'.to_arg(), Arg::UInt(120)));
let mut usize_val: usize = 0;
assert!(matches!((&mut usize_val).to_arg(), Arg::USizeRef(_)));
assert!(matches!(42i8.to_arg(), Arg::SInt(42, 8)));
assert!(matches!(42i16.to_arg(), Arg::SInt(42, 16)));
assert!(matches!(42i32.to_arg(), Arg::SInt(42, 32)));
assert!(matches!(42i64.to_arg(), Arg::SInt(42, 64)));
assert!(matches!(42isize.to_arg(), Arg::SInt(42, SIZE_WIDTH)));
assert_eq!((-42i8).to_arg(), Arg::SInt(-42, 8));
assert_eq!((-42i16).to_arg(), Arg::SInt(-42, 16));
assert_eq!((-42i32).to_arg(), Arg::SInt(-42, 32));
assert_eq!((-42i64).to_arg(), Arg::SInt(-42, 64));
assert_eq!((-42isize).to_arg(), Arg::SInt(-42, SIZE_WIDTH));
assert!(matches!(42u8.to_arg(), Arg::UInt(42)));
assert!(matches!(42u16.to_arg(), Arg::UInt(42)));
assert!(matches!(42u32.to_arg(), Arg::UInt(42)));
assert!(matches!(42u64.to_arg(), Arg::UInt(42)));
assert!(matches!(42usize.to_arg(), Arg::UInt(42)));
let ptr = &42f32 as *const f32;
assert!(matches!(ptr.to_arg(), Arg::UInt(_)));
}
#[test]
fn test_negative_to_arg() {
assert_eq!((-1_i8).to_arg().as_sint(), Ok(-1));
assert_eq!((-1_i16).to_arg().as_sint(), Ok(-1));
assert_eq!((-1_i32).to_arg().as_sint(), Ok(-1));
assert_eq!((-1_i64).to_arg().as_sint(), Ok(-1));
assert_eq!((u64::MAX).to_arg().as_sint(), Err(Error::Overflow));
}
}