mirror of
https://github.com/fish-shell/fish-shell
synced 2024-12-27 05:13:10 +00:00
509ee64fc9
I recently upgraded the software on my macOS server and was dismayed to see that cppcheck reported a huge number of format string errors due to mismatches between the format string and its arguments from calls to `assert()`. It turns out they are due to the macOS header using `%lu` for the line number which is obviously wrong since it is using the C preprocessor `__LINE__` symbol which evaluates to a signed int. I also noticed that the macOS implementation writes to stdout, rather than stderr. It also uses `printf()` which can be a problem on some platforms if the stream is already in wide mode which is the normal case for fish. So implement our own `assert()` implementation. This also eliminates double-negative warnings that we get from some of our calls to `assert()` on some platforms by oclint. Also reimplement the `DIE()` macro in terms of our internal implementation. Rewrite `assert(0 && msg)` statements to `DIE(msg)` for clarity and to eliminate oclint warnings about constant expressions. Fixes #3276, albeit not in the fashion I originally envisioned.
51 lines
2.1 KiB
C++
51 lines
2.1 KiB
C++
// Prototypes for functions for executing a program.
|
|
#ifndef FISH_EXEC_H
|
|
#define FISH_EXEC_H
|
|
|
|
#include <stddef.h>
|
|
|
|
#include <vector>
|
|
|
|
#include "common.h"
|
|
|
|
/// Pipe redirection error message.
|
|
#define PIPE_ERROR _(L"An error occurred while setting up pipe")
|
|
|
|
/// Execute the processes specified by j.
|
|
///
|
|
/// I've put a fair bit of work into making builtins behave like other programs as far as pipes are
|
|
/// concerned. Unlike i.e. bash, builtins can pipe to other builtins with arbitrary amounts of data,
|
|
/// and so on. To do this, after a builtin is run in the real process, it forks and a dummy process
|
|
/// is created, responsible for writing the output of the builtin. This is surprisingly cheap on my
|
|
/// computer, probably because of the marvels of copy on write forking.
|
|
///
|
|
/// This rule is short circuited in the case where a builtin does not output to a pipe and does in
|
|
/// fact not output anything. The speed improvement from this optimization is not noticable on a
|
|
/// normal computer/OS in regular use, but the promiscous amounts of forking that resulted was
|
|
/// responsible for a huge slowdown when using Valgrind as well as when doing complex
|
|
/// command-specific completions.
|
|
class job_t;
|
|
class parser_t;
|
|
void exec_job(parser_t &parser, job_t *j);
|
|
|
|
/// Evaluate the expression cmd in a subshell, add the outputs into the list l. On return, the
|
|
/// status flag as returned bu \c proc_gfet_last_status will not be changed.
|
|
///
|
|
/// \param cmd the command to execute
|
|
/// \param outputs The list to insert output into.
|
|
///
|
|
/// \return the status of the last job to exit, or -1 if en error was encountered.
|
|
int exec_subshell(const wcstring &cmd, std::vector<wcstring> &outputs, bool preserve_exit_status);
|
|
int exec_subshell(const wcstring &cmd, bool preserve_exit_status);
|
|
|
|
/// Loops over close until the syscall was run without being interrupted.
|
|
void exec_close(int fd);
|
|
|
|
/// Call pipe(), and add resulting fds to open_fds, the list of opened file descriptors for pipes.
|
|
/// The pipes are marked CLO_EXEC.
|
|
int exec_pipe(int fd[2]);
|
|
|
|
/// Gets the interpreter for a given command.
|
|
char *get_interpreter(const char *command, char *interpreter, size_t buff_size);
|
|
|
|
#endif
|