fish-shell/share/functions/funcsave.fish
Mahmoud Al-Qudsi 7f402cdae7 Make funcsave update the function <-> file mapping
This makes `funced` after `funcsave` behave as expected rather than a
potential source of data loss.

Closes #6113.
2020-03-20 10:03:05 -05:00

47 lines
1.8 KiB
Fish

function funcsave --description "Save the current definition of all specified functions to file"
set -l options h/help
argparse -n funcsave $options -- $argv
or return
if set -q _flag_help
__fish_print_help funcsave
return 0
end
if not set -q argv[1]
printf (_ "%ls: Expected at least %d args, got only %d\n") funcsave 1 0
return 1
end
if not mkdir -p $__fish_config_dir/functions
printf (_ "%s: Could not create configuration directory\n") funcsave
return 1
end
set -l retval 0
for funcname in $argv
if functions -q -- $funcname
functions -- $funcname >$__fish_config_dir/functions/$funcname.fish
# https://github.com/fish-shell/fish-shell/issues/6113
# Use the newly saved file as the source of the function, allowing
# a subsequent `funced` to modify the correct version of the file.
#
# Ideally this would be done in fish core and would simply update the
# function <-> file mapping, but as funcsave/funced are fish scripts,
# this is close enough. It's guaranteed to be free of side effects
# because `functions $funcname` returns only a function declaration
# without any initialization code, etc. you may find in a fish script.
functions -e $funcname
# `functions -e` is not enough on its own since it prevents future
# autoloading of a function by the same name, even from a different
# location. Possibly something to improve in the future?
source $__fish_config_dir/functions/$funcname.fish
else
printf (_ "%s: Unknown function '%s'\n") funcsave $funcname
set retval 1
end
end
return $retval
end