fish-shell

mirror of https://github.com/fish-shell/fish-shell synced 2024-12-28 05:43:11 +00:00

History

Kurtis Rader 509ee64fc9 implement our own `assert()` function I recently upgraded the software on my macOS server and was dismayed to see that cppcheck reported a huge number of format string errors due to mismatches between the format string and its arguments from calls to `assert()`. It turns out they are due to the macOS header using `%lu` for the line number which is obviously wrong since it is using the C preprocessor `__LINE__` symbol which evaluates to a signed int. I also noticed that the macOS implementation writes to stdout, rather than stderr. It also uses `printf()` which can be a problem on some platforms if the stream is already in wide mode which is the normal case for fish. So implement our own `assert()` implementation. This also eliminates double-negative warnings that we get from some of our calls to `assert()` on some platforms by oclint. Also reimplement the `DIE()` macro in terms of our internal implementation. Rewrite `assert(0 && msg)` statements to `DIE(msg)` for clarity and to eliminate oclint warnings about constant expressions. Fixes #3276, albeit not in the fashion I originally envisioned.		2017-02-14 18:48:27 -08:00
..
autoload.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
autoload.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
builtin.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
builtin.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
builtin_commandline.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
builtin_commandline.h	restyle builtin modules to match project style	2016-04-26 21:58:59 -07:00
builtin_complete.cpp	more IWYU fixes	2017-02-12 20:36:37 -08:00
builtin_complete.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
builtin_jobs.cpp	Switch a job's process list from a linked list to a vector of pointers	2017-01-23 09:28:34 -08:00
builtin_jobs.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
builtin_printf.cpp	more IWYU fixes	2017-02-12 20:36:37 -08:00
builtin_printf.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
builtin_set.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
builtin_set.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
builtin_set_color.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
builtin_set_color.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
builtin_string.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
builtin_string.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
builtin_test.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
builtin_test.h	restyle builtin modules to match project style	2016-04-26 21:58:59 -07:00
builtin_ulimit.cpp	improve converting strings to ints/longs	2016-11-25 18:52:15 -08:00
builtin_ulimit.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
color.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
color.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
common.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
common.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
complete.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
complete.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
env.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
env.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
env_universal_common.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
env_universal_common.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
event.cpp	more IWYU fixes	2017-02-12 20:36:37 -08:00
event.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
exec.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
exec.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
expand.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
expand.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
fallback.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
fallback.h	more IWYU fixes	2017-02-12 20:36:37 -08:00
fish.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
fish_indent.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
fish_key_reader.cpp	more IWYU fixes	2017-02-12 20:36:37 -08:00
fish_tests.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
fish_version.cpp	restyle fish modules to match project style	2016-04-30 19:52:13 -07:00
fish_version.h	restyle fish modules to match project style	2016-04-30 19:52:13 -07:00
function.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
function.h	implement means to learn about a functions source	2017-01-20 21:48:41 -08:00
highlight.cpp	lint cleanups	2017-02-11 21:30:38 -08:00
highlight.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
history.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
history.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
input.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
input.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
input_common.cpp	lint cleanups	2017-02-11 21:30:38 -08:00
input_common.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
intern.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
intern.h	restyle intern module to match project style	2016-05-01 20:28:46 -07:00
io.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
io.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
iothread.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
iothread.h	lint cleanups	2017-02-11 21:30:38 -08:00
kill.cpp	fix random lint issues	2016-05-29 22:24:29 -07:00
kill.h	restyle kill module to match project style	2016-05-01 22:18:59 -07:00
lru.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
output.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
output.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
pager.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
pager.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
parse_constants.h	convert narrow stderr output to wide forms	2017-01-03 16:14:42 -08:00
parse_execution.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
parse_execution.h	Eliminate moved_ref	2017-01-26 15:43:46 -08:00
parse_productions.cpp	convert narrow stderr output to wide forms	2017-01-03 16:14:42 -08:00
parse_productions.h	use enum_map for parser enums	2016-11-11 18:56:56 -08:00
parse_tree.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
parse_tree.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
parse_util.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
parse_util.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
parser.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
parser.h	lint cleanups	2017-02-11 21:30:38 -08:00
parser_keywords.cpp	fix some style bogosities that crept in	2016-05-27 14:44:30 -07:00
parser_keywords.h	Make IWYU output in lint.cpp less messy	2016-06-23 17:26:08 -07:00
path.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
path.h	Make IWYU output in lint.cpp less messy	2016-06-23 17:26:08 -07:00
postfork.cpp	Make job_get_flag and job_set_flag instance methods of jobs	2017-01-26 15:06:58 -08:00
postfork.h	more IWYU fixes	2017-02-12 20:36:37 -08:00
print_help.cpp	lint: "collapsible if statements" warnings	2016-10-22 19:09:40 -07:00
print_help.h	restyle proc module to match project style	2016-05-02 22:07:58 -07:00
proc.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
proc.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
reader.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
reader.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
sanity.cpp	improve sanity check code	2017-01-24 15:24:13 -08:00
sanity.h	improve sanity check code	2017-01-24 15:24:13 -08:00
screen.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
screen.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
signal.cpp	Add a SIGALRM handler that does nothing	2017-01-21 14:07:54 -08:00
signal.h	remove unnecessary signal management	2017-01-14 20:51:54 -08:00
tokenizer.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
tokenizer.h	Make IWYU output in lint.cpp less messy	2016-06-23 17:26:08 -07:00
utf8.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
utf8.h	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
util.cpp	improve converting strings to ints/longs	2016-11-25 18:52:15 -08:00
util.h	restyle remaining modules to match project style	2016-05-03 16:09:45 -07:00
wcstringutil.cpp	fix some style bogosities that crept in	2016-05-27 14:44:30 -07:00
wcstringutil.h	Be a bit more consistent and proper.	2016-06-05 21:32:57 -07:00
wgetopt.cpp	lint: Use early exit/continue	2016-10-31 13:29:10 -07:00
wgetopt.h	Restyle touched .cpp files	2016-06-12 11:34:35 -07:00
wildcard.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
wildcard.h	Make IWYU output in lint.cpp less messy	2016-06-23 17:26:08 -07:00
wutil.cpp	implement our own `assert()` function	2017-02-14 18:48:27 -08:00
wutil.h	add unsigned long long variant to fish_wcsto*	2016-12-20 16:40:12 -08:00