mirror of
https://github.com/fish-shell/fish-shell
synced 2024-12-27 13:23:09 +00:00
0874dd6a96
This used expect_re with a regex ending in `.*`, followed by an `expect_prompt`. This meant that, depending on the timing, the regex could swallow the prompt marker, which caused extremely confusing output like >Testing file pexpects/generic.py:Failed to match pattern: prompt 14 > ... > OUTPUT +1.33 ms (Line 70): \rprompt 13>functions\r\nN_, abbr, > alias, bg, cd, [SNIP], up-or-search, vared, wait\r\n⏎ > \r⏎ \r\rprompt 14> Yeah - it shows that "prompt 14" was in the output and it can't find "prompt 14". I could reproduce the failure locally when running the tests repeatedly. I got one after 17 attempts and so far haven't been able to reproduce it with this change applied. |
||
---|---|---|
.. | ||
checks | ||
pexpects | ||
test_functions | ||
.gitignore | ||
history_sample_bash | ||
history_sample_corrupt1 | ||
history_sample_fish_1_x | ||
history_sample_fish_2_0 | ||
interactive.config | ||
interactive.fish | ||
test.fish | ||
test_driver.sh | ||
test_env.sh | ||
test_util.fish |