Mirrors/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell synced 2025-01-07 18:48:49 +00:00
Code Issues Projects Releases Packages Wiki Activity
12165 commits 37 branches 81 tags 126 MiB
Commit graph

148 commits

Author SHA1 Message Date
Rosen Penev
6ab2da0e25 Fix -Wundef warnings 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-04-12 17:02:17 -07:00
Rosen Penev
ca57bcbb00 add several noreturn statements 
Found with clang's -Wmissing-noreturn

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-04-12 17:02:17 -07:00
Rosen Penev
473a5250ae [clang-tidy] change several member functions to const 
Found with readability-make-member-function-const

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-04-05 10:13:13 +02:00
Rosen Penev
220f0a132d [clang-tidy] use auto when casting 
Found with modernize-use-auto

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-04-05 10:13:13 +02:00
Rosen Penev
925c7a998a [clang-tidy] mark single argument constructors explicit 
Found with hicpp-explicit-conversions

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2020-02-22 09:33:17 +01:00
Johannes Altmanninger
7517128b68 Update exports when an exported universal variable changes 
Fixes #6612
 2020-02-16 18:51:19 +01:00
ridiculousfish
2c4e15e267 Fix the Cygwin build for uvar notifiers 2020-01-30 20:44:29 -08:00
ridiculousfish
d22c6af7a3 clang-format all C++ files 2020-01-30 10:50:11 -08:00
ridiculousfish
28a8d0dbf7 Continued adoption of autoclose_fd_t and exec_close 2020-01-29 14:16:16 -08:00
ridiculousfish
3d47f042ac Be more consistent about using autoclose_fd_t and exec_close 
Simplifying and improving file descriptor handling discipline.
 2020-01-29 13:55:20 -08:00
ridiculousfish
f27958ef4d Clean up the open_cloexec interface 
Remove the ability to make it non-cloexec - nobody was using it.
 2020-01-28 10:25:49 -08:00
Fabian Homborg
14c2c623b4 Add flog category for uvar file 
This used debug level 5, which means it was basically unusable.
 2020-01-19 14:22:50 +01:00
Fabian Homborg
024e03ab1e Replace debug(1) with FLOGF(warning) 2020-01-19 14:22:39 +01:00
Fabian Homborg
759d5a1fb3 Fix uvar error message 
This used a wstring format when it was a narrow string.
 2020-01-13 17:48:09 +01:00
Rosen Penev
06cb0bbe9a
[clang-tidy] Add several references 
Found with performance-unnecessary-value-param

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2019-12-26 21:55:53 -08:00
Rosen Penev
b1349f44f6
[clang-tidy] Add const to reference 
Found with performance-unnecessary-copy-initialization
 2019-12-26 21:37:15 -08:00
Johannes Altmanninger
3f10da0d01 Persist new zero-length universal variables 
Because of default initialization to an empty list, code that relies on
set -U __fish_init_3_x was run every time.
 2019-12-11 11:32:58 +01:00
Rosen Penev
586ac3dfa7 [clang-tidy] Convert loops to range based 
Found with modernize-loop-convert

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2019-11-25 14:50:40 -08:00
Rosen Penev
1055ff321c [clang-tidy] Replace NULL with nullptr 
Found with modernize-use-nullptr

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2019-11-25 14:23:03 -08:00
Rosen Penev
0dfa7421f3 [clang-tidy] Convert C casts to C++ ones 
Found with google-readability-casting

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2019-11-25 14:17:49 -08:00
ridiculousfish
82eca4bc86 Run clang-format on all files 
The main change here is to reorder headers.
 2019-10-13 15:50:48 -07:00
ridiculousfish
e8c6de8055 Correctly export empty universal variables 
Fixes #5992
 2019-07-21 12:45:29 -07:00
ridiculousfish
421cf92380 Use a generation count for uvars exports 
Because an exported universal variable must be exported in all variable
stacks, explicit invalidation is infeasible. Switch the universal variables
to a generation count.
 2019-06-09 13:48:07 -07:00
ridiculousfish
fc99d6c7af clang-format all files 2019-06-03 20:30:48 -07:00
Fabian Homborg
6c1d29e14d fixup! Fix build 
I deleted the lines that defined "narrow_path" and
"explicit_vars_path", but didn't see the two remaining uses.

Sorry!
 2019-06-01 10:32:30 +02:00
Fabian Homborg
5ca14904d0 Store narrow version of uvar path 
This sets the explicit path to the default one, which should be okay,
since the default path never changes (not even if $XDG_CONFIG_HOME
does).

Then it saves a narrow version of that, which saves most of the time
needed to `sync` in most cases.

Fixes #5905.
 2019-06-01 09:56:57 +02:00
Fabian Homborg
d73ee4d54b More using FLOGF when formatting is needed 
sed-patched, every time a "%" is used in a call to `FLOG`, we use
`FLOGF` instead.
 2019-05-30 11:54:09 +02:00
Fabian Homborg
9d62d8e3fd Use FLOGF when formatting is needed 
This passed a format string in a variable which is why it was
presumably overlooked.

[ci skip]
 2019-05-30 11:48:56 +02:00
ridiculousfish
ea9d1ad82f Convert debug(0) calls to FLOG 2019-05-27 17:31:17 -07:00
Fabian Homborg
752b5362ee Only widen string if necessary 
This tried a bunch of times, but only the final one is important.
 2019-05-14 09:49:51 +02:00
Fabian Homborg
c2970f9618 Reformat all files 
This runs build_tools/style.fish, which runs clang-format on C++, fish_indent on fish and (new) black on python.

If anything is wrong with the formatting, we should fix the tools, but automated formatting is worth it.
 2019-05-05 12:09:25 +02:00
Aaron Gyes
a2a9709fd9 Don't truncate hostnames over 32 characters 
I believe this was selected to be artificially low for the sake
of it displaying well in prompts. But people should expect to get
the same output as can be gotten from `hostname`.

Fixes #5758
 2019-03-23 12:34:48 -07:00
Aaron Gyes
f92c2921d2 Remove mini() and maxi() 
C++11 provides std::min/std::max which we're using all over,
obviating the need for our own templates for this.

util.h now only provides two things: get_time and wcsfilecmp.
This commit removes everything that includes it which doesn't
use either; most because they no longer need mini or maxi from
it but some others were #including it unnecessarily.
 2019-03-12 23:25:15 -07:00
Aaron Gyes
aaacdb89b6 Switches over to cstring from string.h. 2019-03-12 15:09:36 -07:00
Aaron Gyes
d5ac239f68 This commit changes wchar.h includes to cwchar, and uses std:: 
for everything it provides.
 2019-03-12 15:09:36 -07:00
Aaron Gyes
fe67cc4f6e Revert "Show how fish was executed, using argv[0] for program_name" 
This reverts commit 1cb8b2a87b.

argv[0] has the full path in it for a user when he executes it
out of $PATH. This is really annoying in the title which uses $_.
 2018-11-28 06:08:24 -08:00
Aaron Gyes
1cb8b2a87b Show how fish was executed, using argv[0] for program_name 
... rather than hard code it to "fish". This affects
what is found in $_ and improves the errors:

For example, if fish was ran with ./fish, instead of
something like:

  fish: Expected 3 surprises, only got 2 surprises

we'll see:

 ./fish: Expected 3 surprises, only got 2 surprises

like most other shell utilities. It's just a tiny bit
of detail that can avoid confusion.
 2018-11-27 11:57:09 -08:00
Fabian Homborg
278cbc5ff1 env_universal_common: Constref env_var_t as well 2018-11-14 12:15:40 +01:00
ridiculousfish
5899694233 Allow setting universal path variables 
Support for path and unpath in universal variables.
Fixes #5271
 2018-10-27 01:05:00 -07:00
ridiculousfish
9690ac5974 Rename fish_universal_variables file to fish_variables 
This is to avoid development versions of fish 3.0 freaking out when the
file format is changed. We now have better support for for future universal
variable formats so it's unlikely we'll have to change the file name again.
 2018-10-26 16:06:50 -07:00
ridiculousfish
7b5296817a Teach universal variables to not overwrite future file formats 2018-10-26 16:06:50 -07:00
ridiculousfish
d18e2d970c Switch to new universal variable format 
Example line:

SETUVAR --export foo:bar
 2018-10-26 16:06:50 -07:00
ridiculousfish
11c77abc8c Make universal variable matching case sensitive 2018-10-26 16:06:50 -07:00
ridiculousfish
fe485f2485 Adopt populate_varabless in universal variables 2018-10-26 16:06:50 -07:00
ridiculousfish
adc69f94da Support parsing the new universal variable format 2018-10-26 16:06:50 -07:00
ridiculousfish
d98874bd08 Improve testability factoring of env_universal_t 2018-10-26 16:06:47 -07:00
ridiculousfish
11d523e61a Build out support for multiple file formats in uvars 
This is in preparation for adjusting the file format to support path
variables.
 2018-10-21 15:56:05 -07:00
ridiculousfish
a23894ca37 Simplify callback_data_t 
SET_EXPORT no longer makes sense; remove it.
 2018-10-21 15:56:05 -07:00
ridiculousfish
00b1dd861e Merge branch 'splitenv_1.8' 
This merges support for PATH variables. Closes #5245
 2018-10-20 12:51:51 -07:00
Fabian Homborg
d4db4f40a4 Remove another unnecessary wcstring->wchar conversion 2018-10-20 20:52:02 +02:00