Mahmoud Al-Qudsi
4dfaa33d95
Switch to wait_by_process when waitpid
without WNOHANG returns nothing
...
By exclusively waiting by pgrp, we can fail to reap processes that
change their own pgrp then either crash or close their fds. If we wind
up in a situation where `waitpid(2)` returns 0 or ECHLD even though we
did not specify `WNOHANG` but we still have unreaped child processes,
wait on them by pid.
Closes #5596 .
2019-02-02 16:06:29 -06:00
Mahmoud Al-Qudsi
b54f1842d5
Switch to wait_by_process when waitpid
without WNOHANG returns nothing
...
By exclusively waiting by pgrp, we can fail to reap processes that
change their own pgrp then either crash or close their fds. If we wind
up in a situation where `waitpid(2)` returns 0 or ECHLD even though we
did not specify `WNOHANG` but we still have unreaped child processes,
wait on them by pid.
Closes #5596 .
2019-02-02 16:05:57 -06:00
Fabian Homborg
93c0d3f4a5
functions -q
: Return false without an argument
...
This erroneously listed functions and returned true.
2019-02-02 14:12:31 +01:00
ridiculousfish
fd1908e973
Switch TMUX check to FISH_UNIT_TESTS_RUNNING
...
Per discussion in https://github.com/fish-shell/fish-shell/commit/0c17210f056
2019-02-01 16:59:05 -08:00
Fabian Homborg
ff89c61afa
functions -q
: Return false without an argument
...
This erroneously listed functions and returned true.
2019-02-01 18:34:45 +01:00
Birger J. Nordølum
df375ea12d
brew.fish: Add update-reset
subcommand completion ( #5608 )
...
* brew.fish: Add `update-reset` subcommand
This command resets all tap's remotes to the latest available upstream. Ideal for debugging before reporting bugs or just housekeeping.
Add missing newlines.
* Add `brew.fish` changes to CHANGELOG.md
2019-02-01 18:02:05 +01:00
ridiculousfish
b00f039489
Clean up the io_chain_t interface
2019-01-31 18:49:52 -08:00
ridiculousfish
371f67f1b5
Remove pipe_read_fd
...
In practice it was always STDIN_FILENO.
2019-01-31 17:58:59 -08:00
ridiculousfish
0c17210f05
Fix the expect tests under tmux by inspecting TERM
...
We were checking for the $TMUX variable to determine if we were
running under tmux. However when running the tests, the terminal becomes
expect, even though the TMUX variable is still set, so we spew tmux-isms
at expect. Check the value of $TERM for 'screen'.
2019-01-31 12:30:41 -08:00
ridiculousfish
a2aab24db7
Switch io_mode to an enum class
2019-01-31 12:12:46 -08:00
raichoo
aebe040fdc
document private mode in fish completion
2019-01-31 20:30:41 +01:00
Fabian Homborg
0770fd1f89
src/function.cpp: Fix possible NULL-dereference
...
UBSan complained, so let's check.
2019-01-31 16:02:02 +01:00
Ashe Connor
bfa051e466
***.fish* ->
**.fish`
...
(cherry picked from commit c7635ed2c0
)
2019-01-31 22:05:13 +08:00
Ashe Connor
f0c03ab73e
fix "are equivalent" with same example
...
This was introduced in 87eb073
when ^ redirection was removed from the
docs.
(cherry picked from commit 09ca268d50
)
2019-01-31 22:05:13 +08:00
Ashe Connor
9103dc2c23
pcre2 -> regex
...
(cherry picked from commit d9d2ad1cd6
)
2019-01-31 22:05:12 +08:00
Ashe Connor
c7635ed2c0
***.fish* ->
**.fish`
2019-01-31 22:03:12 +08:00
Mahmoud Al-Qudsi
d15de117b9
Resolve CMAKE_* directories before saving as build defines
...
Since fish began resolving symlinks it broke the running-from-build-dir
detection in fish.cpp if the build directory were a symlink (which is
common on some platforms where the default user HOME directory is a
symlink in the first place, e.g. FreeBSD).
2019-01-30 14:27:13 -06:00
Ashe Connor
09ca268d50
fix "are equivalent" with same example
...
This was introduced in 87eb073
when ^ redirection was removed from the
docs.
2019-01-30 10:51:56 +01:00
Ashe Connor
d9d2ad1cd6
pcre2 -> regex
2019-01-30 10:47:07 +01:00
Aaron Gyes
38db3adbf6
Makefile.in: run make depend
...
Nobody has done this in a long while. May speed up the build.
2019-01-28 21:12:49 -08:00
Aaron Gyes
276d00e0cf
Fix invocation tests.
...
6b16975359
broke tests. My bad.
2019-01-28 20:44:07 -08:00
Aaron Gyes
6b16975359
Add a colon to command-not-found dealio.
...
The previous commits to fix #5588 removed quoting.
2019-01-28 19:35:17 -08:00
Aaron Gyes
46c967903d
env.cpp: swap entries of fallback PATH
...
I had this backwards. Thanks @mqudsi
2019-01-28 19:28:02 -08:00
ridiculousfish
4064ab8183
Stop emitting extra new lines under tmux
2019-01-28 16:49:31 -08:00
Fabian Homborg
0e282deb92
CHANGELOG: Vi-mode-spinning
...
The last bit for 3.0.1
[ci skip]
2019-01-28 21:26:41 +01:00
Fabian Homborg
a958617425
CHANGELOG: Vi-mode-spinning
...
The last bit for 3.0.1
[ci skip]
2019-01-28 21:26:10 +01:00
Fabian Homborg
8feabae131
Quit immediately with R_EOF
...
If we read an R_EOF, we'd try to match mappings to it.
In emacs mode, that's not an issue because the generic binding was
always available, but in vi-normal mode there is no generic binding,
so we'd endlessly loop, waiting for another character.
Fixes #5528 .
2019-01-28 18:20:57 +01:00
Fabian Homborg
ac3d3c399c
Quit immediately with R_EOF
...
If we read an R_EOF, we'd try to match mappings to it.
In emacs mode, that's not an issue because the generic binding was
always available, but in vi-normal mode there is no generic binding,
so we'd endlessly loop, waiting for another character.
Fixes #5528 .
2019-01-28 18:12:48 +01:00
David Adam
d8d9cfdc10
interactive tests: exit quietly if expect not available
...
It seems that 44cfe3e34
inadvertently included the requirement for the
expect tests to pass; revert this to its original sense.
2019-01-28 21:51:57 +08:00
Siteshwar Vashisht
aa32fc92ac
packaging: Disable expect
based tests
...
`expect` based tests fail randomly and can cause build failures. Do not
run them while doing package builds.
2019-01-28 19:28:56 +08:00
Fabian Homborg
7eee158292
Don't test with one argument
...
[ci skip]
2019-01-27 15:38:03 +01:00
Fabian Homborg
c776414674
functions/trap: Don't test
with one argument
...
That's a POSIX misfeature.
Also there was one actually wrong `test sig` that should have been
`test $sig`.
2019-01-27 15:38:03 +01:00
Jeremy
dc885d70b3
Rename Fisherman to Fisher in FAQ
...
Fisherman became Fisher and moved to a new repo. The previous link still worked, but the name and URL change was needed to avoid confusion.
2019-01-27 12:28:24 +01:00
ridiculousfish
0047523cf4
Relnote new pager color options
2019-01-26 16:33:30 -08:00
ridiculousfish
730effa0d9
Remove an errant space from the docs
2019-01-26 16:32:37 -08:00
Dan Zimmerman
50448e4319
Enable configuring more pager colors
...
Originally I sought out to configure the foreground color of the
selected text in the pager. After reading a thread on a github issue I
was inpired to do more: now you can conifgure any part of the pager when
selected, and when a row is secondary. More specifically this commit adds the
ability to specify a pager row's:
- Prefix
- Completion text
- Description
- Background
when said row is selected or secondary.
2019-01-26 15:43:23 -08:00
Dan Zimmerman
f73b4fb746
Connect highlight env vars to their specs better
...
I was hacking on this part of the codebase and found this comment
mentioning to keep two things in sync, and felt like we could do better.
2019-01-26 15:43:23 -08:00
Fabian Homborg
28ee5716fb
default_command_not_found_handler: Only use $argv[1]
...
That's probably the nicer fix, otherwise this would print things like
Unknown command 'aiohsd 1 2 3'
when it should just say
Unknown command aiohsd
2019-01-26 21:53:32 +01:00
Fabian Homborg
63c072e225
default_command_not_found_handler: Only use $argv[1]
...
That's probably the nicer fix, otherwise this would print things like
Unknown command 'aiohsd 1 2 3'
when it should just say
Unknown command aiohsd
2019-01-26 21:50:49 +01:00
Fabian Homborg
6b060a54e3
CHANGELOG: Add the PRs
...
I missed the PRs without associated issue.
[ci skip]
2019-01-26 21:37:00 +01:00
Fabian Homborg
f01e8d9afe
CHANGELOG: Update for 3.0.1
...
This should now contain all closed issues for 3.0.1.
[ci skip]
2019-01-26 21:36:59 +01:00
Fabian Homborg
368787060b
CHANGELOG: Add the PRs
...
I missed the PRs without associated issue.
[ci skip]
2019-01-26 21:36:27 +01:00
Fabian Homborg
0d0a686ea2
CHANGELOG: Update for 3.0.1
...
This should now contain all closed issues for 3.0.1.
[ci skip]
2019-01-26 21:34:51 +01:00
Fabian Homborg
77b7f5513e
default_command_not_found_handler: Join arguments
...
Without it, this would print the error multiple times, like
Unknown command: echs
Unknown command: 1
Unknown command: 2
Unknown command: 3
Fixes #5588 .
2019-01-26 21:22:55 +01:00
Fabian Homborg
02628d1b02
default_command_not_found_handler: Join arguments
...
Without it, this would print the error multiple times, like
Unknown command: echs
Unknown command: 1
Unknown command: 2
Unknown command: 3
Fixes #5588 .
2019-01-26 21:21:20 +01:00
Fabian Homborg
a0fbb8dea7
Redraw vi cursor if tmux pane focus changes
...
Fixes #4788 .
2019-01-26 19:38:28 +01:00
Fabian Homborg
1cad15b01f
Stringify a few more completions
...
[ci skip]
2019-01-26 19:29:25 +01:00
Fabian Homborg
c775335b2a
functions/__fish_print_cmd_args_without_options: Stringify
...
[ci skip]
2019-01-26 19:20:16 +01:00
Fabian Homborg
b8fd08811c
functions/__terlar_git_prompt: Stringify
...
[ci skip]
2019-01-26 19:20:11 +01:00
Fabian Homborg
0640e7bae9
Move prt-get functions into the completion script
...
These were not used elsewhere.
Part of #5279 .
[ci skip]
2019-01-26 19:16:25 +01:00