Kurtis Rader
9b0d45d4fa
lint: unnecessary else statement
2016-11-02 14:44:27 -07:00
Kurtis Rader
5709c81fe0
lint: empty while statement
2016-11-02 14:22:34 -07:00
Kurtis Rader
e35b91d38c
lint: empty else block
2016-11-02 14:17:26 -07:00
Kurtis Rader
4f4d34e664
lint: missing break in switch statement
2016-11-02 14:07:12 -07:00
Kurtis Rader
f6047f02d6
lint: constant conditional operator
2016-11-01 21:19:34 -07:00
Kurtis Rader
71e69b6d75
lint: empty if statement
2016-11-01 20:42:02 -07:00
Kurtis Rader
60c47deca9
lint: avoid branching statement as last in loop
2016-11-01 20:00:09 -07:00
Kurtis Rader
e73226d7e8
lint: unused parameter
2016-11-01 19:12:39 -07:00
Kurtis Rader
50fc3d72df
lint: Use early exit/continue
2016-10-31 18:17:38 -07:00
Kurtis Rader
feaeca4999
lint: Use early exit/continue
2016-10-31 18:17:38 -07:00
Kurtis Rader
d4fb9a0e65
lint: Use early exit/continue
2016-10-31 18:17:38 -07:00
Kurtis Rader
2c38978115
lint: Use early exit/continue
2016-10-31 18:17:37 -07:00
Kurtis Rader
520f810bf9
lint: Use early exit/continue
2016-10-31 18:17:37 -07:00
Kurtis Rader
d441de33e5
lint: Use early exit/continue
2016-10-31 18:17:37 -07:00
Kurtis Rader
46b791240a
lint: Use early exit/continue
2016-10-31 18:17:33 -07:00
Kurtis Rader
3bd24ddb17
lint: Use early exit/continue
2016-10-31 18:14:57 -07:00
Kurtis Rader
26c1430e82
lint: Use early exit/continue
2016-10-31 18:05:10 -07:00
Kurtis Rader
6c3900ff64
lint: Use early exit/continue
2016-10-31 18:05:10 -07:00
Kurtis Rader
6192e2453e
lint: Use early exit/continue
2016-10-31 18:05:09 -07:00
Kurtis Rader
eab836864e
lint: Use early exit/continue
2016-10-31 18:05:01 -07:00
Kurtis Rader
225caa2fe8
lint: Use early exit/continue
2016-10-31 18:03:03 -07:00
Kurtis Rader
4fe2a2921f
lint: Use early exit/continue
2016-10-31 18:00:59 -07:00
Kurtis Rader
7779132595
lint: Use early exit/continue
2016-10-31 17:58:41 -07:00
Kurtis Rader
ca5a4ec1d5
lint: Use early exit/continue
2016-10-31 13:29:10 -07:00
Kurtis Rader
49ed20c8cb
lint: Use early exit/continue
2016-10-31 13:29:10 -07:00
Kurtis Rader
f0ab1331a5
lint: Use early exit/continue
2016-10-29 21:46:11 -07:00
Kurtis Rader
99b729eb4d
lint: Use early exit/continue
2016-10-29 21:20:29 -07:00
Kurtis Rader
9af0797334
lint: Use early exit/continue
2016-10-29 20:51:03 -07:00
Kurtis Rader
6bef7b7be9
lint: constant if expression
2016-10-29 19:01:19 -07:00
Kurtis Rader
b0b2182535
lint: missing default in switch statements
2016-10-29 18:27:51 -07:00
Kurtis Rader
b663b0e818
lint: redundant if statement
2016-10-28 19:15:05 -07:00
Kurtis Rader
4a2aed1f8e
lint: unnecessary else statement
2016-10-28 17:43:20 -07:00
Kurtis Rader
f382fa8e8a
lint: multiple unary operator
2016-10-27 21:21:54 -07:00
Kurtis Rader
075be74cc4
fix regression introduced by commit 851e449
...
My earlier attempt with commit 851e449
to eliminate all the compiler
warnings about mixing signed and unsigned ints in an expression
introduced a subtle bug. This fixes that mistake.
Fixes #3488
2016-10-25 20:56:15 -07:00
Kurtis Rader
2bb52c65c2
fix bug introduced by 42458ff7
...
There was one block of code modified by commit 42458ff7
that had
convoluted, inverted, logic. In the process of collapsing nested
"if" blocks the logic was modified to avoid using "!" everywhere the
bool was tested. Unfortunately I neglected to modify two of the
conditions used to set that var to reflect the changed polarity.
2016-10-24 17:13:39 -07:00
Kurtis Rader
cdb82e45ac
lint: remove another "too few branches in switch statement"
2016-10-22 22:12:22 -07:00
Kurtis Rader
a90b521eb4
lint: remove unused function
2016-10-22 21:28:46 -07:00
Kurtis Rader
25e0a39165
fix bug introduced by lint cleanup commit 42458ff
2016-10-22 21:14:21 -07:00
Kurtis Rader
d982427216
remove unused function
...
The fish_key_reader program was the only user of the
`set_wait_on_escape_ms()` function and that use was removed with commit
0461743
. So remove it from the main fish code. This was found by `make
lint`.
2016-10-22 21:08:53 -07:00
Kurtis Rader
21521b2953
lint: too few branches in switch statement
...
Someone was way too enamored of the `switch` statement. Using it in
places where a simple `if...else if...else` was clearer and shorter.
2016-10-22 21:01:27 -07:00
Kurtis Rader
42458ff7ab
lint: "collapsible if statements" warnings
2016-10-22 19:09:40 -07:00
Kurtis Rader
6e6b294a3f
lint: deal with "double negative" warnings
2016-10-20 21:14:40 -07:00
Kurtis Rader
00303ed07f
lint cleanup: parameter reassignment
2016-10-20 18:53:31 -07:00
Kurtis Rader
8a2d6a9752
fix/unify tests for chars in fish reserved ranges
2016-10-17 18:46:53 -07:00
Aaron Gyes
8a7b30d3f0
Fix null pointer deref in job_reap()
...
Coverity believes in this one in job_reap().
Proactively apply same check to format_job_info().
2016-10-17 14:38:52 -07:00
Kurtis Rader
a26f68d63f
handle multiline commands in history search output
...
Fixes #31
2016-10-16 21:33:12 -07:00
Kurtis Rader
bff6a6e66a
eliminate compile warnings and augment changelog
...
Update the CHANGELOG to more accurately reflect what will be included in
the 2.4.0 release vis-a-vis the `history` command behavior.
I noticed that the compiler was emitting some harmless warnings related
to the history changes so deal with those as well.
2016-10-16 21:15:40 -07:00
Kurtis Rader
f490b56378
make history searching case insensitive by default
...
Fixes #3236
2016-10-16 20:18:16 -07:00
Kurtis Rader
dc6b538f56
improve set PATH
warning message
...
This modifies the code path for `set PATH` and `set CDPATH` to emit an
easier to understand warning when an entry in those vars is invalid. For
example
$ set PATH $PATH /tmp/arglebargle
set: Warning: $PATH entry "/tmp/arglebargle": No such file or directory
$ mkdir /tmp/d
$ chmod 0 /tmp/d
$ set PATH $PATH /tmp/d
set: Warning: $PATH entry "/tmp/d": Permission denied
$ touch /tmp/x
$ set PATH $PATH /tmp/x
set: Warning: $PATH entry "/tmp/x": Not a directory
Fixes #3450
2016-10-16 19:58:57 -07:00
Kurtis Rader
4f397e86d7
fix use after free bug
...
Fixes #3466
2016-10-16 12:51:31 -07:00