Aaron Gyes
19c575e116
builtin functions: colorize output if interactive
...
We can also get rid of the | fish_indent --ansi stuff in type.fish
2019-09-25 04:18:06 -07:00
Aaron Gyes
8230755bfd
Make sure rgb_color_t doesn't grow
...
For years the comment above the class claimed it was 4 bytes, but
it had grown to 5. Add a static_assert() to prevent that from
happening again.
2019-09-24 23:34:10 -07:00
Aaron Gyes
e6c72f74a8
make rgb_color_t smaller
...
rgb_color_t was 5 bytes, now it's 4 again.
big arrays holding colors are going to be smaller.
2019-09-22 21:16:30 -07:00
ridiculousfish
91c4dad812
Revert "use std::tolower"
...
This reverts commit a3db4128bc
.
This broke the build.
2019-09-22 15:33:08 -07:00
Aaron Gyes
a3db4128bc
use std::tolower
2019-09-22 15:47:22 -07:00
ridiculousfish
a19d9b2e73
Add a test for #6130
2019-09-22 14:06:38 -07:00
Johannes Altmanninger
bc533ad939
Fix completion inside command substitution inserting spurious quote
...
Reproducer: type `: (: ""`, move the cursor after the second colon and press tab.
2019-09-22 14:06:38 -07:00
ridiculousfish
70a1d8314c
Optimize parse_color
2019-09-21 19:36:56 -07:00
ridiculousfish
18b56637f7
self-insert bindings to insert their own sequence
...
Prior to this fix, self-insert would always wait for a new character.
Track in char_event what sequence generated the readline event, and then
if the sequence is not empty, insert that sequence.
This will support implementing the space binding via pure readline
functions.
2019-09-21 15:58:57 -07:00
ridiculousfish
1ecbe363d0
Correct an assertion message
2019-09-21 15:17:09 -07:00
ridiculousfish
3f7bc7232e
yank_POP -> yank_pop
2019-09-21 14:31:22 -07:00
ridiculousfish
5f64972908
Do not try the same (command, wraps) pair more than once when completing
...
This prevents runaway wrap chains. Fixes #5638 .
2019-09-21 14:09:38 -07:00
ridiculousfish
77dbe109e0
Allow cancellation out of expanding a runaway wrap chain
...
This makes it easier to control-C out of a completion.
2019-09-21 13:11:45 -07:00
ridiculousfish
3f2f44ce73
Introduce reader_test_should_cancel
...
This centralizes the logic around cancellation due to either sigint or a
stale threaded operation.
2019-09-21 13:07:55 -07:00
ridiculousfish
95aea7839d
Show wrap targets when printing a function
...
Fixes #1625
2019-09-21 12:48:51 -07:00
ridiculousfish
a1f1abc137
Stop passing true to escape_string
...
It wants a flags, not a boolean.
2019-09-21 12:40:24 -07:00
Johannes Altmanninger
a7ea7648c3
Completion: maintain cursor position when there is no completion
...
Previously, tab-completion would move the cursor to the end of the current token, even
if no completion is inserted. This commit defers moving the cursor until we insert a completion.
Fixes #4124
2019-09-21 12:50:52 -07:00
Johannes Altmanninger
e9e92178a9
completions: simplify prefix computation
2019-09-21 12:50:52 -07:00
Johannes Altmanninger
6c5c0a73eb
remove useless call, fix comment
2019-09-21 12:50:52 -07:00
Aaron Gyes
2b7b70a64f
Ellipsis OCD
2019-09-19 11:48:37 -07:00
Aaron Gyes
fda8ad429b
parse_util.cpp: remove truncate_string()
...
We already have something that does this
2019-09-19 10:32:07 -07:00
Aaron Gyes
cb79d8fa97
Colorize complete
output
...
If interactive, `complete` commands are highlighted like they would
be if typed. Adds a little fun contrast and it's easier to read.
Moved a function out of fish_indent to highlight.h
2019-09-19 04:27:33 -07:00
Aaron Gyes
620761b9b9
complete: print long option names for less common ones
...
we now print --long options for ones I arbitrarily decided
are less likely to be remembered.
Also fixed the `--wraps` items at the end not being escaped
2019-09-19 04:21:24 -07:00
Aaron Gyes
e9ee2fb089
complete: support -k (--keep-files) in printed completions
2019-09-19 02:01:33 -07:00
Aaron Gyes
7302dcc12b
complete: terser output with short options
...
Most of our completion scripts are written using the short options
anyhow, and this makes it less likely the output will span several
lines per command
2019-09-19 01:50:26 -07:00
David Adam
3ae12ac4d3
Revert "Escape separators (colon and equals) to improve completion"
...
This reverts commit f7dac82ed6
from pull
request #6059 .
As discussed in #6099 , this caused a regression in some completions (eg
dd).
2019-09-19 14:38:16 +08:00
Aaron Gyes
f35e18bb9b
complete.cpp: don't double escape commands in complete
output
...
The argument to --command was escaped both here and in
append_switch(), potentially producing incorrect output
2019-09-18 16:21:21 -07:00
Johannes Altmanninger
8baea8b157
Do not add a space after completion if one is already there
...
Example: type `cd --help --help`, move the cursor inside the first `--help` and press tab.
This used to add redundant spaces.
2019-09-18 14:02:24 -05:00
Aaron Gyes
22811ebcf6
Remove unused macros
...
Most just left behind after actual code was moved into different files.
2019-09-18 01:31:03 -07:00
Aaron Gyes
715836cb0a
builtin_set_color.cpp: remove unnecessary .c_str()
2019-09-18 00:09:23 -07:00
Aaron Gyes
5f05d9734c
builtin_set_color.cpp: colorize set_color --print-colors
...
Each named color is now printed in that color, only if
hooked up to a TTY. Shouldn't affect scripts.
2019-09-18 00:05:09 -07:00
Aaron Gyes
61f0756fe6
builtins: Use standard builtin.h error macros more
2019-09-17 22:04:33 -07:00
ridiculousfish
533ee65963
Allow binding nul (zero byte)
...
This sequence can be generatd by control-spacebar. Allow it to be bound
properly.
To do this we must be sure that we never round-trip the key sequence
through a C string.
2019-09-14 16:37:57 -07:00
ridiculousfish
5afcc439a5
Clean up input_terminfo_get_sequence
2019-09-14 14:59:01 -07:00
ridiculousfish
5ebcd3de98
Remove some unnecessary string formatting
2019-09-14 14:22:37 -07:00
ridiculousfish
06269ed67d
Remove NOT_A_WCHAR
...
It's now unused.
2019-09-14 13:18:04 -07:00
ridiculousfish
8747018cbc
Use maybe_t in unescape_string_internal
2019-09-14 13:17:22 -07:00
ridiculousfish
fa1dab040b
Use maybe_t in read_unquoted_escape
2019-09-14 12:54:38 -07:00
ridiculousfish
cc5e29734b
Use maybe_t in string_last_char
2019-09-14 11:56:02 -07:00
Johannes Altmanninger
0ecfc25961
Fix highlighting of redirection to -
(close file descriptor)
...
Fixes #6092
2019-09-14 13:04:27 -05:00
David Adam
77ef2ef6c3
jobs: return success when a job is found via --last
...
Closes #6104 .
2019-09-14 13:01:36 -05:00
ridiculousfish
56d2942f59
Minor cleanup of how jobs store their command string
2019-09-09 09:07:25 -07:00
ridiculousfish
535a448d0e
Remove an errant fprintf
2019-09-08 15:44:07 -07:00
ridiculousfish
b2fe2f9ff3
Correct escaping and add tests for bracket completion
...
Add some tests for new bracket completion behavior, and fix an escaping
bug where \\[ was incorrectly marked as escaping.
2019-09-08 15:43:20 -07:00
Johannes Altmanninger
bc3dde997d
escape square brackets in an argument before completing it
...
fixes #5831
2019-09-08 12:27:58 -07:00
ridiculousfish
e79df33e3a
Disallow parsing 'and' and 'or' as commands
...
Except for and --help and or --help
Fixes #6089
2019-09-08 11:09:32 -07:00
ridiculousfish
fa6bac1283
Correctly implement and --help and or --help
2019-09-08 10:42:24 -07:00
Johannes Altmanninger
962bfa9668
Escape literal dollar signs in quoted completions
...
Closes #6060 .
2019-09-07 13:52:40 -05:00
Mahmoud Al-Qudsi
f854e3dc29
Try fixing __has_attribute errors on Travis macOS
2019-09-05 23:11:59 -05:00
Mahmoud Al-Qudsi
80610addf8
Avoid warnings about unsupported clang::weak_import w/ GCC on macOS
2019-09-05 23:00:46 -05:00