Soumya
8dd2d4f15d
Change builtins to return maybe_t<int> instead of int
2020-08-05 12:23:49 -07:00
Rosen Penev
d9ad5a2627
remove unreachable break statements
...
Found with clang's -Wunreachable-code-break
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2020-04-12 17:02:17 -07:00
Rosen Penev
1055ff321c
[clang-tidy] Replace NULL with nullptr
...
Found with modernize-use-nullptr
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2019-11-25 14:23:03 -08:00
Rosen Penev
8d54e928cd
[clang-tidy] C to C++ headers
...
Found with modernize-deprecated-headers
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2019-11-25 14:17:49 -08:00
ridiculousfish
82eca4bc86
Run clang-format on all files
...
The main change here is to reorder headers.
2019-10-13 15:50:48 -07:00
Fabian Homborg
c2970f9618
Reformat all files
...
This runs build_tools/style.fish, which runs clang-format on C++, fish_indent on fish and (new) black on python.
If anything is wrong with the formatting, we should fix the tools, but automated formatting is worth it.
2019-05-05 12:09:25 +02:00
ridiculousfish
070a43989f
Mark a null variable const in builtin_echo
2018-10-01 09:47:45 -07:00
ridiculousfish
d7b2576fb5
Mark short_options as const everywhere
...
These were needlessly mutable file-scoped variables.
2018-09-29 00:18:36 -04:00
Mahmoud Al-Qudsi
dcced5f1bc
Replace \e with \x1B, as the former is a gcc extension
...
While supported by gcc and clang, \e is a gcc-specific extension and not
formally defined in the C or C++ standards.
See [0] for a list of valid escapes.
[0]: https://stackoverflow.com/a/10220539/17027
2018-06-18 00:01:47 -05:00
Kurtis Rader
1e6bd2d968
use the UNUSED(); pattern for the prev change
2017-07-09 19:55:04 -07:00
ridiculousfish
a4eec25447
Fix unused varibale warning
2017-07-09 18:17:20 -07:00
Kurtis Rader
ec1e9ac98d
standardize on builtin_missing_argument()
2017-07-01 14:03:47 -07:00
Kurtis Rader
dd191a9d4b
more wgetopt_long() normalization
2017-06-29 21:49:57 -07:00
Kurtis Rader
82f5fb507d
fix echo -h
...
In addition to fixing `echo -h` this includes some debugging related
cleanups I made while investigating the issue.
Fixes #4120
2017-06-18 22:10:19 -07:00
Kurtis Rader
37b8cfaeba
avoid struct name clashes
...
Running the tests on travis revealed that some compilers (or at least
with some options) call the wrong struct constructor if there is more
than one struct with the same name but differing definitions.
2017-06-16 21:01:57 -07:00
Kurtis Rader
1d4a0fb091
split builtin echo into its own module
2017-06-16 21:01:56 -07:00
