Mirrors/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell synced 2025-01-01 07:38:46 +00:00
Code Issues Projects Releases Packages Wiki Activity

clang-tidy: replace push_back with emplace_back

Browse source 
clang-tidy marks these as needing emplace_back as the types to not
match.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev 2021-08-17 13:36:52 -07:00 committed by Johannes Altmanninger
parent 6bd25ed599
commit ffd5716e70
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/fish_tests.cpp
View file

@ -171,7 +171,7 @@ static bool pushd(const char *path) {
err(L"getcwd() from pushd() failed: errno = %d", errno); err(L"getcwd() from pushd() failed: errno = %d", errno);
return false; return false;
} }
pushed_dirs.push_back(cwd); pushed_dirs.emplace_back(cwd);
// We might need to create the directory. We don't care if this fails due to the directory // We might need to create the directory. We don't care if this fails due to the directory
// already being present. // already being present.
@ -2099,7 +2099,7 @@ struct pwd_environment_t : public test_environment_t {
auto res = test_environment_t::get_names(flags); auto res = test_environment_t::get_names(flags);
res.clear(); res.clear();
if (std::count(res.begin(), res.end(), L"PWD") == 0) { if (std::count(res.begin(), res.end(), L"PWD") == 0) {
res.push_back(L"PWD"); res.emplace_back(L"PWD");
} }
return res; return res;
} }
@ -5508,7 +5508,7 @@ static void test_highlighting() {
for (const highlight_component_t &comp : components) { for (const highlight_component_t &comp : components) {
if (!text.empty() && !comp.nospace) { if (!text.empty() && !comp.nospace) {
text.push_back(L' '); text.push_back(L' ');
expected_colors.push_back(highlight_spec_t{}); expected_colors.emplace_back();
} }
text.append(comp.txt); text.append(comp.txt);
expected_colors.resize(text.size(), comp.color); expected_colors.resize(text.size(), comp.color);

2
src/iothread.cpp
View file

@ -329,7 +329,7 @@ void iothread_perform_on_main(const void_function_t &func) {
wait_until_done.set_value(); wait_until_done.set_value();
}; };
// Append it. Ensure we don't hold the lock after. // Append it. Ensure we don't hold the lock after.
s_main_thread_queue.acquire()->requests.push_back(std::move(handler)); s_main_thread_queue.acquire()->requests.emplace_back(std::move(handler));
// Tell the signaller and then wait until our future is set. // Tell the signaller and then wait until our future is set.
get_notify_signaller().post(); get_notify_signaller().post();