Mirrors/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell synced 2025-01-15 06:24:01 +00:00
Code Issues Projects Releases Packages Wiki Activity

Remove signal_block_t

Browse source 
Bravely removing more signal blocks, now that our signal handling is so
simple.
This commit is contained in:
ridiculousfish 2019-02-23 13:48:16 -08:00
parent 0ff4046b8c
commit ec65ba3427
2 changed files with 0 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/proc.cpp
View file

@ -701,10 +701,6 @@ bool terminal_give_to_job(const job_t *j, bool restore_attrs) {
return true; return true;
} }
// RAII wrappers must have a name so that their scope is tied to the function as it is legal for
// the compiler to construct and then immediately deconstruct unnamed objects otherwise.
signal_block_t signal_block;
// It may not be safe to call tcsetpgrp if we've already done so, as at that point we are no // It may not be safe to call tcsetpgrp if we've already done so, as at that point we are no
// longer the controlling process group for the terminal and no longer have permission to set // longer the controlling process group for the terminal and no longer have permission to set
// the process group that is in control, causing tcsetpgrp to return EPERM, even though that's // the process group that is in control, causing tcsetpgrp to return EPERM, even though that's

12
src/signal.h
View file

@ -41,16 +41,4 @@ bool signal_is_blocked();
/// Returns signals with non-default handlers. /// Returns signals with non-default handlers.
void get_signals_with_handlers(sigset_t *set); void get_signals_with_handlers(sigset_t *set);
/// A RAII wrapper for signal_block/signal_unblock that triggers a signal block on creation, and then
/// automatically releases the block when the object is destroyed, handling control flow and exceptions.
struct signal_block_t {
signal_block_t() {
signal_block();
}
~signal_block_t() {
signal_unblock();
}
};
#endif #endif