mirror of
https://github.com/fish-shell/fish-shell
synced 2025-01-12 21:18:53 +00:00
Another effort to make the cd completion work without running command substitutions off of the main thread
This commit is contained in:
parent
71a8d39372
commit
e0baab2722
2 changed files with 2 additions and 4 deletions
|
@ -1163,8 +1163,7 @@ void completer_t::complete_from_args( const wcstring &str,
|
|||
std::vector<completion_t> possible_comp;
|
||||
|
||||
bool is_autosuggest = (this->type == COMPLETE_AUTOSUGGEST);
|
||||
bool show_errors = ! is_autosuggest;
|
||||
parser_t parser(PARSER_TYPE_COMPLETIONS_ONLY, show_errors);
|
||||
parser_t parser(is_autosuggest ? PARSER_TYPE_COMPLETIONS_ONLY : PARSER_TYPE_GENERAL, false);
|
||||
|
||||
/* If type is COMPLETE_AUTOSUGGEST, it means we're on a background thread, so don't call proc_push_interactive */
|
||||
if (! is_autosuggest)
|
||||
|
|
|
@ -767,8 +767,7 @@ int parser_t::eval_args( const wchar_t *line, std::vector<completion_t> &args )
|
|||
expand_flags_t eflags = 0;
|
||||
if (! show_errors)
|
||||
eflags |= EXPAND_NO_DESCRIPTIONS;
|
||||
// Completions need command substitution (for example, the cd completion uses this)
|
||||
if (this->parser_type != PARSER_TYPE_GENERAL && this->parser_type != PARSER_TYPE_COMPLETIONS_ONLY)
|
||||
if (this->parser_type != PARSER_TYPE_GENERAL)
|
||||
eflags |= EXPAND_SKIP_CMDSUBST;
|
||||
|
||||
/*
|
||||
|
|
Loading…
Reference in a new issue