Mirrors/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell synced 2024-12-26 04:43:10 +00:00
Code Issues Projects Releases Packages Wiki Activity

Rewrite __fish_urlencode to not encode valid characters

Browse source 
Much better to only encode the characters that are not URL-safe. This
also doesn't involve any forking, and it even handles newlines and NULs
in the input.
This commit is contained in:
Kevin Ballard 2016-02-27 00:14:52 -08:00
parent 211829c586
commit d8a497434f
1 changed files with 16 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
share/functions/__fish_urlencode.fish
View file

@ -1,11 +1,22 @@
function __fish_urlencode --description "URL-encode stdin"
set -l output
set -l join ''
set -l chars
# Set locale to C and IFS to "" in order to split a line into bytes.
while begin; set -lx LC_ALL C; set -lx IFS ''; read --array chars; end
if count $chars > /dev/null
set output $output (printf '%%%02x' "'"$chars)
while begin; set -lx LC_ALL C; set -lx IFS ''; read -az chars; end
printf '%s' $join
# chomp off a trailing newline
if test "$chars[-1]" = \n
set -e chars[-1]
set join '%0A%00'
else
set join '%00'
end
for c in $chars
if string match -q -r '[/._~A-Za-z0-9-]' $c
printf '%s' $c
else
printf '%%%02X' "'$c"
end
end
end
echo -s $output | sed -e 's/%2[fF]/\//g'
end