mirror of
https://github.com/fish-shell/fish-shell
synced 2024-12-27 05:13:10 +00:00
Silence some more clippy lints
bool_assert_comparison is stupid, the reason they give is "it's shorter". Well, `assert!(!foo)` is nowhere near as readable as `assert_eq!(foo, false)` because of the ! noise from the macro. Uninlined format args is a stupid lint that Rust actually walked back when they made it an official warning because you still have to use a mix of inlined and un-inlined format args (the latter of which won't complain) since only idents can be inlined.
This commit is contained in:
parent
4828346f8b
commit
d839fea748
2 changed files with 6 additions and 1 deletions
|
@ -3,6 +3,9 @@
|
||||||
#![allow(non_upper_case_globals)]
|
#![allow(non_upper_case_globals)]
|
||||||
#![allow(clippy::needless_return)]
|
#![allow(clippy::needless_return)]
|
||||||
#![allow(clippy::manual_is_ascii_check)]
|
#![allow(clippy::manual_is_ascii_check)]
|
||||||
|
#![allow(clippy::bool_assert_comparison)]
|
||||||
|
#![allow(clippy::uninlined_format_args)]
|
||||||
|
#![allow(clippy::derivable_impls)]
|
||||||
|
|
||||||
#[macro_use]
|
#[macro_use]
|
||||||
mod common;
|
mod common;
|
||||||
|
|
|
@ -96,7 +96,9 @@ impl ItemMaker {
|
||||||
fn write42(&self) {
|
fn write42(&self) {
|
||||||
let buf = [0u8; 42];
|
let buf = [0u8; 42];
|
||||||
let mut writer = self.writer.lock().expect("Mutex poisoned!");
|
let mut writer = self.writer.lock().expect("Mutex poisoned!");
|
||||||
writer.write_all(&buf).expect("Error writing 42 bytes to pipe!");
|
writer
|
||||||
|
.write_all(&buf)
|
||||||
|
.expect("Error writing 42 bytes to pipe!");
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue