Mirrors/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell synced 2024-12-26 12:53:13 +00:00
Code Issues Projects Releases Packages Wiki Activity

Print message in fish_add_path -v when a path doesnt exist (#8884)

Browse source 
* Print message in set_fish_path -v when a path doesnt exist

* Update changelog

* Remove "; or continue"

* use printf instead of echo, avoid localizing the path
This commit is contained in:
Andrew Cassidy 2022-04-18 00:58:05 -07:00 committed by GitHub
parent e3c4cde042
commit d22f22c3b3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
CHANGELOG.rst
View file

@ -54,6 +54,7 @@ Interactive improvements
- ``ulimit`` learned a number of new options for the resource limits available on Linux, FreeBSD and NetBSD, and returns a specific warning if the limit specified is not available on the active operating system (:issue:`8823`). - ``ulimit`` learned a number of new options for the resource limits available on Linux, FreeBSD and NetBSD, and returns a specific warning if the limit specified is not available on the active operating system (:issue:`8823`).
- The ``vared`` command can now successfully edit variables named "tmp" or "prompt" (:issue:`8836`). - The ``vared`` command can now successfully edit variables named "tmp" or "prompt" (:issue:`8836`).
- ``time`` now emits an error if used after the first command in a pipeline (:issue:`8841`). - ``time`` now emits an error if used after the first command in a pipeline (:issue:`8841`).
- ``fish_add_path`` now prints a message for skipped non-existent paths when using the ``-v`` flag.
New or improved bindings New or improved bindings
^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^

4
po/en.po
View file

@ -62480,6 +62480,10 @@ msgstr ""
msgid "Edit variable value" msgid "Edit variable value"
msgstr "Edit variable value" msgstr "Edit variable value"
#: /tmp/fish/implicit/share/functions/fish_add_path.fish:1
msgid "Skipping non-existent path: %s\n"
msgstr "Skipping non-existent path: %s\n"
#~ msgid "%ls: No function name given\n" #~ msgid "%ls: No function name given\n"
#~ msgstr "%ls: No function name given\n" #~ msgstr "%ls: No function name given\n"

9
share/functions/fish_add_path.fish
View file

@ -47,7 +47,14 @@ function fish_add_path --description "Add paths to the PATH"
set -l p (builtin realpath -s -- $path 2>/dev/null) set -l p (builtin realpath -s -- $path 2>/dev/null)
# Ignore non-existing paths # Ignore non-existing paths
test -d "$p"; or continue if not test -d "$p"
# path does not exist
if set -q _flag_verbose;
# print a message in verbose mode
printf (_ "Skipping non-existent path: %s\n") "$p"
end
continue
end
if set -l ind (contains -i -- $p $$var) if set -l ind (contains -i -- $p $$var)
# In move-mode, we remove it from its current position and add it back. # In move-mode, we remove it from its current position and add it back.