Mirrors/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell synced 2025-01-16 06:54:03 +00:00
Code Issues Projects Releases Packages Wiki Activity

Reword confusing comments about quoted cmdsub tokenization

Browse source
This commit is contained in:
Johannes Altmanninger 2021-12-04 14:48:43 +01:00
parent b5739ddacf
commit c706b1d6cb
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/tokenizer.cpp
View file

@ -214,11 +214,11 @@ tok_t tokenizer_t::read_string() {
mode &= ~(tok_modes::subshell); mode &= ~(tok_modes::subshell);
} }
expecting.pop_back(); expecting.pop_back();
// Check if the ) did complete a quoted command substituion. // Check if the ) completed a quoted command substitution.
if (!quoted_cmdsubs.empty() && quoted_cmdsubs.back() == paran_offsets.size()) { if (!quoted_cmdsubs.empty() && quoted_cmdsubs.back() == paran_offsets.size()) {
quoted_cmdsubs.pop_back(); quoted_cmdsubs.pop_back();
// Quoted command substitutions temporarily close double quotes, after ), // The "$(" part of a quoted command substitution closes double quotes. To keep
// we need to act as if there was an invisible double quote. // quotes balanced, act as if there was an invisible double quote after the ")".
if (const wchar_t *error_loc = process_opening_quote(L'"')) { if (const wchar_t *error_loc = process_opening_quote(L'"')) {
if (!this->accept_unfinished) { if (!this->accept_unfinished) {
return this->call_error(tokenizer_error_t::unterminated_quote, buff_start, return this->call_error(tokenizer_error_t::unterminated_quote, buff_start,