From b1c61bcf1f737919f4c1813bee1e8cd2e6acd337 Mon Sep 17 00:00:00 2001 From: axel Date: Mon, 12 Dec 2005 08:27:30 +1000 Subject: [PATCH] Do not call fcntl before fully reading block.Escalates bug severity without any practical benefit. darcs-hash:20051211222730-ac50b-bdb2e1dc612ba6a9dd425f514baa2423f8b0d4e5.gz --- io.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/io.c b/io.c index 41e0892cd..2e4f4f303 100644 --- a/io.c +++ b/io.c @@ -42,12 +42,12 @@ void io_buffer_read( io_data_t *d ) if( d->io_mode == IO_BUFFER ) { - if( fcntl( d->param1.pipe_fd[0], F_SETFL, 0 ) ) +/* if( fcntl( d->param1.pipe_fd[0], F_SETFL, 0 ) ) { wperror( L"fcntl" ); return; - } - debug( 4, L"exec_read_io_buffer: blocking read on fd %d", d->param1.pipe_fd[0] ); + } */ + debug( 4, L"io_buffer_read: blocking read on fd %d", d->param1.pipe_fd[0] ); while(1) { char b[4096]; @@ -71,7 +71,7 @@ void io_buffer_read( io_data_t *d ) debug( 1, L"An error occured while reading output from code block on fd %d", d->param1.pipe_fd[0] ); - wperror( L"exec_read_io_buffer" ); + wperror( L"io_buffer_read" ); } break;