respond to feedback

This commit is contained in:
Kurtis Rader 2016-01-09 18:06:34 -08:00 committed by ridiculousfish
parent f8ed1d182e
commit a77ce393ba
3 changed files with 6 additions and 15 deletions

View file

@ -312,10 +312,6 @@ body {
height: 12px;
}
.colorpicker_text_notice {
margin: 0px 20px 10px 20px; /* top right bottom left */
}
.colorpicker_text_sample, .colorpicker_text_sample_tight {
font-size: 12pt;
padding: 25px;

View file

@ -92,10 +92,10 @@ controllers.controller("colorsController", function($scope, $http) {
$scope.changeSelectedColorScheme(currentScheme);
})};
$scope.saveThemeButtonTitle = "Set Theme";
$scope.saveThemeButtonTitle = "Set Theme w/o Background Color";
$scope.noteThemeChanged = function() {
$scope.saveThemeButtonTitle = "Set Theme";
$scope.saveThemeButtonTitle = "Set Theme w/o Background Color";
}
$scope.setTheme = function() {

View file

@ -1,16 +1,11 @@
<div>
<div title="Background color for illustration only.
fish cannot change the background color of your terminal and it will not be saved. Refer to your terminal documentation to set its background color.">
<!-- ko with: color_picker -->
<div class="colorpicker_text_notice">
The background color in the theme preview box below is for
illustration only. The displayed background color is not part of the
theme and will not be saved. Fish is not able to change the terminal
window background color. See your terminal documentation for how to
set its background color.
</div>
<div class="colorpicker_text_sample" ng-style="{'background-color': terminalBackgroundColor}">
<span style="position: absolute; left: 10px; top: 3px;" data-ng-style="{'color': text_color_for_color(terminalBackgroundColor || 'white')}">{{ selectedColorScheme.name }}</span><br>
<div class="color_picker_background_cells">
<span data-ng-style="{'color': text_color_for_color(terminalBackgroundColor || 'white')}">Background: </span>
<span data-ng-style="{'color': text_color_for_color(terminalBackgroundColor || 'white')}">Background Color (illustration only): </span>
<div ng-style="{'background-color': color}" ng-repeat="color in sampleTerminalBackgroundColors" ng-click="changeTerminalBackgroundColor(color)" title="Preview with this background color.
fish cannot change the background color of your terminal. Refer to your terminal documentation to set its background color."></div>