Mirrors/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell synced 2024-12-26 21:03:12 +00:00
Code Issues Projects Releases Packages Wiki Activity

fix exiting breakpoint interactive context

Browse source 
Commit 8d27f81a to change how background jobs are handled (killed rather
than left running) when the shell is exited did not correctly handle
the nested interactive context created by the `breakpoint` command. This
fixes that mistake. Now any background jobs that already existed, or were
created within the `breakpoint` context, are left running when exiting
that context.
This commit is contained in:
Kurtis Rader 2016-12-19 20:35:57 -08:00
parent 8d27f81a7b
commit 9870cf838a
1 changed files with 33 additions and 30 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

49
src/reader.cpp
View file

@ -14,29 +14,30 @@
#include "config.h"
// IWYU pragma: no_include <type_traits>
#include <assert.h>
#include <errno.h>
#include <fcntl.h>
#include <pthread.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <sys/time.h>
#include <termios.h>
#include <time.h>
#include <unistd.h>
#include <wctype.h>
#include <algorithm>
#include <stack>
#ifdef HAVE_SIGINFO_H
#include <siginfo.h>
#endif
#include <signal.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#ifdef HAVE_SYS_SELECT_H
#include <sys/select.h>
#endif
#include <assert.h>
#include <fcntl.h>
#include <signal.h>
#include <sys/time.h>
#include <sys/types.h>
#include <termios.h>
#include <time.h>
#include <unistd.h>
#include <wchar.h>
#include <wctype.h>
#include <algorithm>
#include <stack>
#include <memory>
#include "color.h"
@ -2222,17 +2223,18 @@ bool shell_is_exiting() {
/// This function is called when the main loop notices that end_loop has been set while in
/// interactive mode. It checks if it is ok to exit.
static void handle_end_loop() {
bool bg_jobs = false;
bool is_breakpoint = false;
if (!reader_exit_forced()) {
const parser_t &parser = parser_t::principal_parser();
for (size_t i = 0; i < parser.block_count(); i++) {
if (parser.block_at_index(i)->type() == BREAKPOINT) {
is_breakpoint = true;
break;
// We're executing within a breakpoint so we do not want to terminate the shell and
// kill background jobs.
return;
}
}
}
bool bg_jobs = false;
job_iterator_t jobs;
while (job_t *j = jobs.next()) {
if (!job_is_completed(j)) {
@ -2241,14 +2243,16 @@ static void handle_end_loop() {
}
}
if (!reader_exit_forced() && !data->prev_end_loop && bg_jobs && !is_breakpoint) {
if (!data->prev_end_loop && bg_jobs) {
writestr(_(L"There are stopped or running jobs.\n"));
writestr(_(L"A second attempt to exit will force their termination.\n"));
reader_exit(0, 0);
data->prev_end_loop = 1;
} else {
// Kill background jobs.
job_iterator_t jobs;
return;
}
// Kill background jobs before exiting.
jobs.reset();
while (job_t *j = jobs.next()) {
if (!job_is_completed(j)) {
if (job_is_stopped(j)) job_signal(j, SIGCONT);
@ -2256,7 +2260,6 @@ static void handle_end_loop() {
}
}
}
}
static bool selection_is_at_top() {
const pager_t *pager = &data->pager;