From 97e514d7fff7a3cf0014a60dca4fd25134e7d26b Mon Sep 17 00:00:00 2001 From: Mahmoud Al-Qudsi Date: Sat, 31 Jul 2021 15:26:09 -0500 Subject: [PATCH] Use more consistent names for event_t function impls The names in the implementation differed from those in the header, but the header names were definitely better (because they correlated across function calls). --- src/event.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/event.cpp b/src/event.cpp index 684253732..4daa8bc28 100644 --- a/src/event.cpp +++ b/src/event.cpp @@ -527,20 +527,20 @@ event_t event_t::process_exit(pid_t pid, int status) { } // static -event_t event_t::job_exit(pid_t pid, internal_job_id_t jid) { +event_t event_t::job_exit(pid_t pgid, internal_job_id_t jid) { event_t evt{event_type_t::job_exit}; - evt.desc.param1.jobspec = {pid, jid}; + evt.desc.param1.jobspec = {pgid, jid}; evt.arguments.reserve(3); evt.arguments.push_back(L"JOB_EXIT"); - evt.arguments.push_back(to_string(pid)); + evt.arguments.push_back(to_string(pgid)); evt.arguments.push_back(L"0"); // historical return evt; } // static -event_t event_t::caller_exit(uint64_t caller_id, int job_id) { +event_t event_t::caller_exit(uint64_t internal_job_id, int job_id) { event_t evt{event_type_t::caller_exit}; - evt.desc.param1.caller_id = caller_id; + evt.desc.param1.caller_id = internal_job_id; evt.arguments.reserve(3); evt.arguments.push_back(L"JOB_EXIT"); evt.arguments.push_back(to_string(job_id));