Mirrors/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell synced 2025-01-13 05:28:49 +00:00
Code Issues Projects Releases Packages Wiki Activity

make unit tests more hermetic regarding env vars

Browse source 
Specifically, the `TERM` and `ITERM_PROFILE` env vars. If we don't set
them to known values the unit tests can fail in unexpected ways.

Fixes #3395
This commit is contained in:
Kurtis Rader 2016-09-19 22:08:33 -07:00
parent 2c8bc05826
commit 93bea5b321
2 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
tests/interactive.fish
View file

@ -10,6 +10,12 @@ set TESTS_TO_RETRY bind.expect
# Change to directory containing this script # Change to directory containing this script
cd (dirname (status -f)) cd (dirname (status -f))
# These env vars should not be inherited from the user environment because they can affect the
# behavior of the tests. So either remove them or set them to a known value.
# See also tests/test.fish.
set TERM xterm
set -e ITERM_PROFILE
# Test files specified on commandline, or all *.expect files # Test files specified on commandline, or all *.expect files
if set -q argv[1] if set -q argv[1]
set files_to_test $argv.expect set files_to_test $argv.expect

6
tests/test.fish
View file

@ -14,6 +14,12 @@ else
set files_to_test *.in set files_to_test *.in
end end
# These env vars should not be inherited from the user environment because they can affect the
# behavior of the tests. So either remove them or set them to a known value.
# See also tests/interactive.fish.
set TERM xterm
set -e ITERM_PROFILE
source test_util.fish (status -f) $argv; or exit source test_util.fish (status -f) $argv; or exit
say -o cyan "Testing high level script functionality" say -o cyan "Testing high level script functionality"