Mirrors/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell synced 2025-01-15 06:24:01 +00:00
Code Issues Projects Releases Packages Wiki Activity

math: Don't match longer function names

Browse source 
The comparison here is a bit naive, so "n" matches "ncr", so
technically

   math 'n(2, 3)'

is equivalent to

   math 'ncr(2, 3)'

Work towards #7508.
This commit is contained in:
Fabian Homborg 2020-11-26 12:32:46 +01:00
parent 6d98939445
commit 903a9fbf0c
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/tinyexpr.cpp
View file

@ -222,7 +222,7 @@ static const te_builtin *find_builtin(const char *name, int len) {
return std::strncmp(lhs.name, rhs, len) < 0; return std::strncmp(lhs.name, rhs, len) < 0;
}); });
// We need to compare again because we might have gotten the first "larger" element. // We need to compare again because we might have gotten the first "larger" element.
if (found != end && std::strncmp(found->name, name, len) == 0) return found; if (found != end && std::strncmp(found->name, name, len) == 0 && found->name[len] == 0) return found;
return nullptr; return nullptr;
} }