Mirrors/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell synced 2024-12-26 12:53:13 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix off-by-one in complete_cmd_desc

Browse source 
The substring constructor (string(str, pos)) includes pos, so we need
to add one. Also be careful not to go over the length again.
This commit is contained in:
Fabian Homborg 2018-06-03 17:59:11 +02:00
parent ebc5e18956
commit 8de5af5f9e
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/complete.cpp
View file

@ -545,7 +545,8 @@ void completer_t::complete_cmd_desc(const wcstring &str) {
wcstring cmd; wcstring cmd;
size_t pos = str.find_last_of(L'/'); size_t pos = str.find_last_of(L'/');
if (pos != std::string::npos) { if (pos != std::string::npos) {
cmd = wcstring(str, pos); if (pos + 1 > str.length()) return;
cmd = wcstring(str, pos + 1);
} else { } else {
cmd = str; cmd = str;
} }