Mirrors/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell synced 2025-01-13 05:28:49 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix completion bug for special fish characters.

Browse source 
Issue #1108: If there are special characters like '{' in the
completion suggestions, then we fail to parse it successfully
as we are passing an unescaped version of the character to
parser_t::eval_args(...).

This causes us to retun w/o completion suggestions.

This bug was discovered while implementing 'git stash' completion
as the suggestion contained strings like 'stash@\{0\}'.

Th fix is to properly escape the string before parsing it.
This commit is contained in:
Mandeep Sandhu 2013-12-20 16:58:20 +05:30 committed by David Adam
parent 541db5fbbe
commit 8078d29fda
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
complete.cpp
View file

@ -1240,7 +1240,7 @@ void completer_t::complete_from_args(const wcstring &str,
if (! is_autosuggest)
proc_pop_interactive();
this->complete_strings(str, desc.c_str(), 0, possible_comp, flags);
this->complete_strings(escape_string(str, ESCAPE_ALL), desc.c_str(), 0, possible_comp, flags);
}
/**