Mirrors/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell synced 2024-12-27 21:33:09 +00:00
Code Issues Projects Releases Packages Wiki Activity

parse_execution: Remove some useless no_exec checks

Browse source 
These are both clearly behind early returns, there is no need to check it again.

This isn't a case where we're doing logic gymnastics to see that it
can't be run without no_exec() being handled, this is

```c++
if (no_exec()) return;
// ..
// ..
// ..

if (no_exec()) foo;
```
This commit is contained in:
Fabian Boehm 2023-08-07 17:41:03 +02:00
parent ab6abaa114
commit 73d30ac4f8
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/parse_execution.cpp
View file

@ -904,8 +904,6 @@ end_execution_reason_t parse_execution_context_t::populate_plain_process(
}
if (!has_command && !use_implicit_cd) {
// No command. If we're --no-execute return okay - it might be a function.
if (no_exec()) return end_execution_reason_t::ok;
return this->handle_command_not_found(
external_cmd.path.empty() ? cmd : external_cmd.path, statement, external_cmd.err);
}
@ -1334,8 +1332,7 @@ end_execution_reason_t parse_execution_context_t::run_1_job(const ast::job_pipel
// is significantly faster.
if (job_is_simple_block(job_node)) {
bool do_time = job_node.has_time();
// If no-exec has been given, there is nothing to time.
auto timer = push_timer(do_time && !no_exec());
auto timer = push_timer(do_time);
const block_t *block = nullptr;
end_execution_reason_t result =
this->apply_variable_assignments(nullptr, job_node.variables(), &block);