Mirrors/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell synced 2025-01-26 03:35:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fixes use-after-free issue.

Browse source 
Calling writer() might fail in which case launch_buff gets freed.
This patch prevents the subsequent use of memory after it was freed.
This commit is contained in:
Daniel J. Hofmann 2014-05-10 16:01:44 +02:00 committed by ridiculousfish
parent 18c1b12741
commit 706286c289
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
mimedb.cpp
View file

@ -1190,6 +1190,12 @@ static void launch(char *filter, const string_list_t &files, size_t fileno)
writer('&'); writer('&');
writer('\0'); writer('\0');
/*
Calling writer might fail in which case launch_buff gets freed.
*/
if (error)
return;
if (system(launch_buff) == -1) if (system(launch_buff) == -1)
{ {
fprintf(stderr, _(ERROR_SYSTEM), MIMEDB, launch_buff); fprintf(stderr, _(ERROR_SYSTEM), MIMEDB, launch_buff);