Mirrors/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell synced 2025-01-27 12:15:08 +00:00
Code Issues Projects Releases Packages Wiki Activity

Remove 4 cppcheck suppressions reported unmatched.

Browse source
This commit is contained in:
Aaron Gyes 2016-11-28 11:53:13 -08:00
parent 7c6527e9cf
commit 682af2f83f
4 changed files with 1 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/common.h
View file

@ -670,7 +670,7 @@ ssize_t read_loop(int fd, void *buff, size_t count);
/// ///
/// will print the string 'fish: Pi = 3.141', given that debug_level is 1 or higher, and that /// will print the string 'fish: Pi = 3.141', given that debug_level is 1 or higher, and that
/// program_name is 'fish'. /// program_name is 'fish'.
void __attribute__((noinline)) debug(int level, const char *msg, ...); void __attribute__((noinline)) debug(int level, const char *msg, ...) __attribute__ ((format (printf, 2, 3)));
void __attribute__((noinline)) debug(int level, const wchar_t *msg, ...); void __attribute__((noinline)) debug(int level, const wchar_t *msg, ...);
/// Replace special characters with backslash escape sequences. Newline is replaced with \n, etc. /// Replace special characters with backslash escape sequences. Newline is replaced with \n, etc.

1
src/complete.cpp
View file

@ -1372,7 +1372,6 @@ void complete(const wcstring &cmd_with_subcmds, std::vector<completion_t> *out_c
} }
} }
// cppcheck-suppress nullPointerRedundantCheck
if (cmd_node && cmd_node->location_in_or_at_end_of_source_range(pos)) { if (cmd_node && cmd_node->location_in_or_at_end_of_source_range(pos)) {
// Complete command filename. // Complete command filename.
completer.complete_cmd(current_token, use_function, use_builtin, use_command, completer.complete_cmd(current_token, use_function, use_builtin, use_command,

1
src/env_universal_common.cpp
View file

@ -1059,7 +1059,6 @@ class universal_notifier_shmem_poller_t : public universal_notifier_t {
// Read the current seed. // Read the current seed.
this->poll(); this->poll();
// cppcheck-suppress memleak // addr not really leaked
} }
public: public:

2
src/parse_tree.cpp
View file

@ -127,7 +127,6 @@ const wchar_t *token_type_description(parse_token_type_t type) {
// This leaks memory but it should never be run unless we have a bug elsewhere in the code. // This leaks memory but it should never be run unless we have a bug elsewhere in the code.
const wcstring d = format_string(L"unknown_token_type_%ld", static_cast<long>(type)); const wcstring d = format_string(L"unknown_token_type_%ld", static_cast<long>(type));
wchar_t *d2 = new wchar_t[d.size() + 1]; wchar_t *d2 = new wchar_t[d.size() + 1];
// cppcheck-suppress memleak
return std::wcscpy(d2, d.c_str()); return std::wcscpy(d2, d.c_str());
} }
@ -138,7 +137,6 @@ const wchar_t *keyword_description(parse_keyword_t type) {
// This leaks memory but it should never be run unless we have a bug elsewhere in the code. // This leaks memory but it should never be run unless we have a bug elsewhere in the code.
const wcstring d = format_string(L"unknown_keyword_%ld", static_cast<long>(type)); const wcstring d = format_string(L"unknown_keyword_%ld", static_cast<long>(type));
wchar_t *d2 = new wchar_t[d.size() + 1]; wchar_t *d2 = new wchar_t[d.size() + 1];
// cppcheck-suppress memleak
return std::wcscpy(d2, d.c_str()); return std::wcscpy(d2, d.c_str());
} }