Revert "Enable gettext without the _nl_msg_cat_cntr gnuism"

This built on my test system, might be version differences.

(it's also not enough to make it *work*, but a necessary step)

This reverts commit 6fded249cd.

build.rs

@@ -84,13 +84,6 @@ fn detect_cfgs(target: &mut Target) {
         ),
         ("bsd", &detect_bsd),
         ("gettext", &have_gettext),
-        ("HAVE_NL_MSG_CAT_CNTR", &|target| {
-            Ok(
-            target.has_symbol_in("_nl_msg_cat_cntr", &["intl"])
-                ||
-            target.has_symbol_in("_nl_msg_cat_cntr", &["gettextlib"])
-                    )
-        }),
         ("small_main_stack", &has_small_stack),
         // See if libc supports the thread-safe localeconv_l(3) alternative to localeconv(3).
         ("localeconv_l", &|target| {
@@ -166,7 +159,7 @@ fn have_gettext(target: &Target) -> Result<bool, Box<dyn Error>> {
     // symbol _nl_msg_cat_cntr, we cannot use gettext even if we find it.
     let mut libraries = Vec::new();
     let mut found = 0;
-    let symbols = ["gettext"];
+    let symbols = ["gettext", "_nl_msg_cat_cntr"];
     for symbol in &symbols {
         // Historically, libintl was required in order to use gettext() and co, but that
         // functionality was subsumed by some versions of libc.
@@ -185,6 +178,7 @@ fn have_gettext(target: &Target) -> Result<bool, Box<dyn Error>> {
     }
     match found {
         0 => Ok(false),
+        1 => Err(format!("gettext found but cannot be used without {}", symbols[1]).into()),
         _ => {
             rsconf::link_libraries(&libraries, LinkType::Default);
             Ok(true)

src/env_dispatch.rs

@@ -751,7 +751,7 @@ fn init_locale(vars: &EnvStack) {
         new_msg_locale.to_string_lossy()
     );
 
-    #[cfg(all(gettext, HAVE_NL_MSG_CAT_CNTR))]
+    #[cfg(gettext)]
     {
         if old_msg_locale.as_c_str() != new_msg_locale {
             // Make change known to GNU gettext.