Mirrors/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell synced 2024-11-10 07:04:29 +00:00
Code Issues Projects Releases Packages Wiki Activity

Replace a HashMap w/ a BTreeMap

Browse source 
The HashMap is used to generate the __fish_describe_command integration
completions. Given the nature of the allocations and the numbers that we use, a
BTreeMap would theoretically perform better. Benchmarks show a 2-9%
improvement in completion times consistently in favor of BTreeMap.
This commit is contained in:
Mahmoud Al-Qudsi 2024-08-31 14:13:41 -05:00
parent 73908f1218
commit 50a6dfd10d
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/complete.rs
View file

@ -988,7 +988,7 @@ impl<'ctx> Completer<'ctx> {
// Then discard anything that is not a possible completion and put the result into a // Then discard anything that is not a possible completion and put the result into a
// hashtable with the completion as key and the description as value. // hashtable with the completion as key and the description as value.
let mut lookup = HashMap::new(); let mut lookup = BTreeMap::new();
// A typical entry is the command name, followed by a tab, followed by a description. // A typical entry is the command name, followed by a tab, followed by a description.
for elstr in &mut list { for elstr in &mut list {
// Skip keys that are too short. // Skip keys that are too short.