Mirrors/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell synced 2024-12-26 21:03:12 +00:00
Code Issues Projects Releases Packages Wiki Activity

CONTRIBUTING: Document tests some more

Browse source
This commit is contained in:
Fabian Homborg 2020-11-15 12:07:35 +01:00
parent 9c2d22e452
commit 4e69ccba2e
1 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
CONTRIBUTING.rst
View file

@ -289,7 +289,7 @@ Testing
------- -------
The source code for fish includes a large collection of tests. If you The source code for fish includes a large collection of tests. If you
are making any changes to fish, running these tests is mandatory to make are making any changes to fish, running these tests is a good way to make
sure the behaviour remains consistent and regressions are not sure the behaviour remains consistent and regressions are not
introduced. Even if you don’t run the tests on your machine, they will introduced. Even if you don’t run the tests on your machine, they will
still be run via Github Actions. still be run via Github Actions.
@ -298,6 +298,19 @@ You are strongly encouraged to add tests when changing the functionality
of fish, especially if you are fixing a bug to help ensure there are no of fish, especially if you are fixing a bug to help ensure there are no
regressions in the future (i.e., we don’t reintroduce the bug). regressions in the future (i.e., we don’t reintroduce the bug).
The tests can be found in three places:
- src/fish_tests.cpp for tests to the core C++ code
- tests/checks for script tests
- tests/pexpects for interactive tests using pexpect
When in doubt, the bulk of the tests should be added as a littlecheck test in tests/checks, as they are the easiest to modify and run, and much faster and more dependable than pexpect tests. The syntax is fairly self-explanatory. It's a fish script with the expected output in ``# CHECK:`` or ``# CHECKERR:`` (for stderr) comments.
fish_tests.cpp is mostly useful for unit tests - if you wish to test that a function does the correct thing for given input, use it.
The pexpects are written in python and can simulate input and output to/from a terminal, so they are needed for anything that needs actual interactivity.
Local testing Local testing
~~~~~~~~~~~~~ ~~~~~~~~~~~~~