Mirrors/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell synced 2024-12-27 21:33:09 +00:00
Code Issues Projects Releases Packages Wiki Activity

Use move semantics when returning completions

Browse source 
Avoids some string copies
This commit is contained in:
ridiculousfish 2018-08-06 23:58:48 -07:00
parent 00dcc2a12d
commit 3175ccf266
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/complete.cpp
View file

@ -313,7 +313,7 @@ class completer_t {
completer_t(wcstring c, completion_request_flags_t f) : flags(f), initial_cmd(std::move(c)) {} completer_t(wcstring c, completion_request_flags_t f) : flags(f), initial_cmd(std::move(c)) {}
bool empty() const { return completions.empty(); } bool empty() const { return completions.empty(); }
const std::vector<completion_t> &get_completions() { return completions; } std::vector<completion_t> acquire_completions() { return std::move(completions); }
bool try_complete_variable(const wcstring &str); bool try_complete_variable(const wcstring &str);
bool try_complete_user(const wcstring &str); bool try_complete_user(const wcstring &str);
@ -1534,7 +1534,7 @@ void complete(const wcstring &cmd_with_subcmds, std::vector<completion_t> *out_c
} }
} }
*out_comps = completer.get_completions(); *out_comps = completer.acquire_completions();
} }
/// Print the GNU longopt style switch \c opt, and the argument \c argument to the specified /// Print the GNU longopt style switch \c opt, and the argument \c argument to the specified