Mirrors/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell synced 2024-12-27 05:13:10 +00:00
Code Issues Projects Releases Packages Wiki Activity

Remove errant profiling enabling

Browse source 
This enabled the profile in fish_setlocale, which caused startup
profile to always be on, so

```fish
fish --profile file -c 'foo'
```

would show the entire startup as well
This commit is contained in:
Fabian Boehm 2024-05-26 10:30:50 +02:00
parent 08f8983085
commit 2c3894993f
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/common.rs
View file

@ -1485,7 +1485,6 @@ pub fn fish_setlocale() {
Ordering::Relaxed, Ordering::Relaxed,
); );
} }
PROFILING_ACTIVE.store(true);
} }
/// Test if the character can be encoded using the current locale. /// Test if the character can be encoded using the current locale.

6
tests/checks/invocation.fish
View file

@ -79,6 +79,12 @@ string match -rq "echo thisshouldneverbeintheconfig" < $tmp/full.prof
and echo matched and echo matched
# CHECK: matched # CHECK: matched
# See that profiling without startup actually gives us just the command
$fish --no-config --profile $tmp/nostartup.prof -c 'echo foo'
# CHECK: foo
count < $tmp/nostartup.prof
# CHECK: 2
$fish --no-config -c 'echo notprinted; echo foo | exec true; echo banana' $fish --no-config -c 'echo notprinted; echo foo | exec true; echo banana'
# CHECKERR: fish: The 'exec' command can not be used in a pipeline # CHECKERR: fish: The 'exec' command can not be used in a pipeline
# CHECKERR: echo notprinted; echo foo | exec true; echo banana # CHECKERR: echo notprinted; echo foo | exec true; echo banana