Mirrors/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell synced 2024-12-25 12:23:09 +00:00
Code Issues Projects Releases Packages Wiki Activity

Use BC_LINE_LENGTH=2 for bc.

Browse source 
It's not the case that macOS and old BC doesn't respect this environment
variable, just that they don't have special behavior when it's set to 0.
However, there is rather universal favorable behavior with a value of 2.

Output is of the form:
\
999999999999999999999999999999999...

with the second line being arbitrarily long. So just grab that line
instead of stitching with `string`.

This can yield a 25-30% speedup.
This commit is contained in:
Aaron Gyes 2016-12-29 03:42:08 -08:00
parent ee6691458e
commit 26e781ef5a
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
share/functions/math.fish
View file

@ -21,9 +21,12 @@ function math --description "Perform math calculations in bc"
return 2 # no arguments is an error
end
# Stitch lines together manually. We can't rely on BC_LINE_LENGTH because some systems don't
# have a new enough version of bc.
set -l out (echo "scale=$scale; $argv" | bc | string replace -r '\\\\$' '' | string join '')
# With BC_LINE_LENGTH set to 2, the first line is a slash and the following line can be arbitrarily long.
# We can't set this to 0 because some systems don't have a new enough version of bc.
set -lx BC_LINE_LENGTH 2
set -l out (echo "scale=$scale; $argv" | bc)
set -q out[2]
and set out $out[2]
switch "$out"
case ''
# No output indicates an error occurred.