Mirrors/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell synced 2025-01-27 20:25:12 +00:00
Code Issues Projects Releases Packages Wiki Activity

Real fix for https://github.com/fish-shell/fish-shell/issues/278

Browse source 
We forget to set the parent group ID in posix_spawn (!)
This commit is contained in:
ridiculousfish 2012-08-15 17:32:57 -07:00
parent a9b119833a
commit 26857fabdc
2 changed files with 3 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
postfork.cpp
View file

@ -412,6 +412,9 @@ bool fork_actions_make_spawn_properties(posix_spawnattr_t *attr, posix_spawn_fil
if (! err) if (! err)
err = posix_spawnattr_setflags(attr, flags); err = posix_spawnattr_setflags(attr, flags);
if (! err && should_set_parent_group_id)
err = posix_spawnattr_setpgroup(attr, desired_parent_group_id);
/* Everybody gets default handlers */ /* Everybody gets default handlers */
if (! err && reset_signal_handlers) if (! err && reset_signal_handlers)
{ {

8
signal.cpp
View file

@ -633,14 +633,6 @@ void get_signals_with_handlers(sigset_t *set)
sigemptyset(set); sigemptyset(set);
for( int i=0; lookup[i].desc ; i++ ) for( int i=0; lookup[i].desc ; i++ )
{ {
/* Don't include SIGTTIN or SIGTTOU until we figure out how to set the controlling terminal in POSIX_SPAWN */
#ifdef SIGTTIN
if (lookup[i].signal == SIGTTIN) continue;
#endif
#ifdef SIGTTOU
if (lookup[i].signal == SIGTTOU) continue;
#endif
struct sigaction act = {}; struct sigaction act = {};
sigaction(lookup[i].signal, NULL, &act); sigaction(lookup[i].signal, NULL, &act);
if (act.sa_handler != SIG_DFL) if (act.sa_handler != SIG_DFL)