Mirrors/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell synced 2024-12-27 21:33:09 +00:00
Code Issues Projects Releases Packages Wiki Activity

[math] Fail without arguments

Browse source 
See #4768.
This commit is contained in:
Fabian Homborg 2018-03-01 22:27:24 +01:00
parent b49e1d7703
commit 0da8022081
3 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/builtin_math.cpp
View file

@ -186,5 +186,9 @@ int builtin_math(parser_t &parser, io_streams_t &streams, wchar_t **argv) {
expression.append(arg); expression.append(arg);
} }
if (expression.empty()) {
streams.err.append_format(BUILTIN_ERR_MIN_ARG_COUNT1, L"math", 1, 0);
return STATUS_CMD_ERROR;
}
return evaluate_expression(cmd, parser, streams, opts, expression); return evaluate_expression(cmd, parser, streams, opts, expression);
} }

2
tests/math.err
View file

@ -22,3 +22,5 @@ math: Error: Too few arguments
math: Error: Too many arguments math: Error: Too many arguments
'2 + 2 4' '2 + 2 4'
^ ^
math: Expected at least 1 args, got only 0
math: Expected at least 1 args, got only 0

2
tests/math.in
View file

@ -29,3 +29,5 @@ not math 'ncr(1)'
not math 'max()' not math 'max()'
not math 'sin()' not math 'sin()'
not math '2 + 2 4' not math '2 + 2 4'
not math
not math -s 12