Underline every valid entered path (#5872)

* src/highlight: Underline every valid entered path

* update CHANGELOG

* fix highlight test

CHANGELOG.md

@@ -13,6 +13,7 @@
 - $PATH is no longer reordered in child fishes (#5456).
 - `eval` is now implemented internally rather than being a function; as such, the evaluated code now shares the same argument scope as `eval` rather than being executed in a new scope (#4443).
 - An issue resulting in a certain class of parser errors not resulting in a non-zero `$status` has been corrected (3e055f).
+- fish now underlines every valid entered path instead of just the last one.
 
 ### Syntax changes and new commands
 - None yet.

src/fish_tests.cpp

@@ -4418,7 +4418,7 @@ static void test_highlighting() {
 
     highlight_tests.push_back({
         {L"cat", highlight_role_t::command},
-        {L"/dev/null", highlight_role_t::param},
+        {L"/dev/null", param_valid_path},
         {L"|", highlight_role_t::statement_terminator},
         // This is bogus, but we used to use "less" here and that doesn't have to be installed.
         {L"cat", highlight_role_t::command},

src/highlight.cpp

@@ -1265,11 +1265,8 @@ const highlighter_t::color_array_t &highlighter_t::highlight() {
         // Must be an argument with source.
         if (node.type != symbol_argument || !node.has_source()) continue;
 
-        // See if this node contains the cursor. We check <= source_length so that, when backspacing
+        // Underline every valid path.
-        // (and the cursor is just beyond the last token), we may still underline it.
+        if (node_is_potential_path(buff, node, vars, working_directory)) {
-        if (this->cursor_pos >= node.source_start &&
-            this->cursor_pos - node.source_start <= node.source_length &&
-            node_is_potential_path(buff, node, vars, working_directory)) {
             // It is, underline it.
             for (size_t i = node.source_start; i < node.source_start + node.source_length; i++) {
                 // Don't color highlight_role_t::error because it looks dorky. For example,