From 04bde6cf5b67518d3e88dc6fc801c4c8dbd9f827 Mon Sep 17 00:00:00 2001 From: Mahmoud Al-Qudsi Date: Thu, 5 Oct 2017 13:32:56 +0200 Subject: [PATCH] Document reasons for commmand name replacement in pip2/3 completions (cherry picked from commit 429bdce4f130d033e1cdb8cc41c40317b7146645) --- share/completions/pip2.fish | 4 ++++ share/completions/pip3.fish | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/share/completions/pip2.fish b/share/completions/pip2.fish index 894e87634..8cc6457eb 100644 --- a/share/completions/pip2.fish +++ b/share/completions/pip2.fish @@ -1,3 +1,7 @@ if command -sq pip2 + # pip[2|3] emits (or emitted) completions with the wrong command name + # See discussion at https://github.com/fish-shell/fish-shell/pull/4448 + # and pip bug at https://github.com/pypa/pip/pull/4755 + # Keep this even after pip fix is upstreamed for users not on the latest pip pip2 completion --fish | string replace -r "\b-c\s+pip\b" -- "-c pip2" | source end diff --git a/share/completions/pip3.fish b/share/completions/pip3.fish index fd12cc224..1d1da95e8 100644 --- a/share/completions/pip3.fish +++ b/share/completions/pip3.fish @@ -1,3 +1,7 @@ if command -sq pip3 + # pip[2|3] emits (or emitted) completions with the wrong command name + # See discussion at https://github.com/fish-shell/fish-shell/pull/4448 + # and pip bug at https://github.com/pypa/pip/pull/4755 + # Keep this even after pip fix is upstreamed for users not on the latest pip pip3 completion --fish | string replace -r "\b-c\s+pip\b" -- "-c pip3" | source end