Mirrors/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell synced 2025-01-13 13:39:02 +00:00
Code Issues Projects Releases Packages Wiki Activity

lint: too few branches in switch statement

Browse source
This commit is contained in:
Kurtis Rader 2016-11-03 16:41:51 -07:00
parent de87419df9
commit 003ea83410
1 changed files with 4 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/parse_util.cpp
View file

@ -1171,21 +1171,16 @@ parser_test_error_bits_t parse_util_detect_errors(const wcstring &buff_src,
break; break;
} }
switch (parse_node_tree_t::statement_boolean_type(*spec_statement)) { parse_bool_statement_type_t bool_type =
case parse_bool_and: { // this is not allowed parse_node_tree_t::statement_boolean_type(*spec_statement);
if (bool_type == parse_bool_and) { // this is not allowed
errored = append_syntax_error( errored = append_syntax_error(
&parse_errors, spec_statement->source_start, &parse_errors, spec_statement->source_start,
BOOL_AFTER_BACKGROUND_ERROR_MSG, L"and"); BOOL_AFTER_BACKGROUND_ERROR_MSG, L"and");
break; } else if (bool_type == parse_bool_or) { // this is not allowed
}
case parse_bool_or: { // this is not allowed
errored = append_syntax_error( errored = append_syntax_error(
&parse_errors, spec_statement->source_start, &parse_errors, spec_statement->source_start,
BOOL_AFTER_BACKGROUND_ERROR_MSG, L"or"); BOOL_AFTER_BACKGROUND_ERROR_MSG, L"or");
break;
}
// All others are OK.
default: { break; }
} }
break; break;
} }