fish-shell/tests/checks/status-value.fish

# RUN: %fish %s

# Empty commands should be 123
set empty_var
$empty_var
echo $status
# CHECK: 123
# CHECKERR: {{.*}} The expanded command was empty.
# CHECKERR: $empty_var
# CHECKERR: ^~~~~~~~~^

# Failed expansions
echo "$abc["
echo $status
# CHECK: 121
# CHECKERR: {{.*}} Invalid index value
# CHECKERR: echo "$abc["
# CHECKERR:            ^

# Failed wildcards
echo *gibberishgibberishgibberish*
echo $status
# CHECK: 124
# CHECKERR: {{.*}} No matches for wildcard '*gibberishgibberishgibberish*'. {{.*}}
# CHECKERR: echo *gibberishgibberishgibberish*
# CHECKERR:      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~^
Rationalize $status and errors Prior to this fix, fish was rather inconsistent in when $status gets set in response to an error. For example, a failed expansion like "$foo[" would not modify $status. This makes the following inter-related changes: 1. String expansion now directly returns the value to set for $status on error. The value is always used. 2. parser_t::eval() now directly returns the proc_status_t, which cleans up a lot of call sites. 3. We expose a new function exec_subshell_for_expand() which ignores $status but returns errors specifically related to subshell expansion. 4. We reify the notion of "expansion breaking" errors. These include command-not-found, expand syntax errors, and others. The upshot is we are more consistent about always setting $status on errors. 2020-01-24 01:34:46 +00:00			`# RUN: %fish %s`

			`# Empty commands should be 123`
			`set empty_var`
			`$empty_var`
			`echo $status`
			`# CHECK: 123`
			`# CHECKERR: {{.*}} The expanded command was empty.`
			`# CHECKERR: $empty_var`
Add more tests These were correct, but littlecheck escapes quotes! 2022-08-11 16:20:40 +00:00			`# CHECKERR: ^~~~~~~~~^`
Rationalize $status and errors Prior to this fix, fish was rather inconsistent in when $status gets set in response to an error. For example, a failed expansion like "$foo[" would not modify $status. This makes the following inter-related changes: 1. String expansion now directly returns the value to set for $status on error. The value is always used. 2. parser_t::eval() now directly returns the proc_status_t, which cleans up a lot of call sites. 3. We expose a new function exec_subshell_for_expand() which ignores $status but returns errors specifically related to subshell expansion. 4. We reify the notion of "expansion breaking" errors. These include command-not-found, expand syntax errors, and others. The upshot is we are more consistent about always setting $status on errors. 2020-01-24 01:34:46 +00:00
			`# Failed expansions`
			`echo "$abc["`
			`echo $status`
			`# CHECK: 121`
			`# CHECKERR: {{.*}} Invalid index value`
			`# CHECKERR: echo "$abc["`
Clamp error carets to the end instead of refusing to print This skipped printing a "^" line if the start or length of the error was longer than the source. That seems like the correc thing at first glance, however it means that the caret line isn't skipped if the file goes on. So, for example ```fish echo "$abc[" ``` by itself, in a file or via `fish -c`, would not print an error, but ```fish echo "$abc[" true ``` would. That's not a great way to print errors. So instead we just.. imagine the start was at most at the end. The underlying issue why `echo "$abc["` causes this is that `wcstol` didn't move the end pointer for the index value (because there is no number there). I'd fix this, but apparently some of our recursive variable calls absolutely rely on this position value. 2022-08-11 17:24:41 +00:00			`# CHECKERR: ^`
Rationalize $status and errors Prior to this fix, fish was rather inconsistent in when $status gets set in response to an error. For example, a failed expansion like "$foo[" would not modify $status. This makes the following inter-related changes: 1. String expansion now directly returns the value to set for $status on error. The value is always used. 2. parser_t::eval() now directly returns the proc_status_t, which cleans up a lot of call sites. 3. We expose a new function exec_subshell_for_expand() which ignores $status but returns errors specifically related to subshell expansion. 4. We reify the notion of "expansion breaking" errors. These include command-not-found, expand syntax errors, and others. The upshot is we are more consistent about always setting $status on errors. 2020-01-24 01:34:46 +00:00
			`# Failed wildcards`
			`echo gibberishgibberishgibberish`
			`echo $status`
			`# CHECK: 124`
			`# CHECKERR: {{.}} No matches for wildcard 'gibberishgibberishgibberish'. {{.}}`
			`# CHECKERR: echo gibberishgibberishgibberish`
Add acceptable errors to tests 2022-08-11 15:22:03 +00:00			`# CHECKERR: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~^`