Mirrors/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell synced 2025-01-26 03:35:17 +00:00
Code Issues Projects Releases Packages Wiki Activity
fish-shell/tests/checks/signal.fish

77 lines
1.7 KiB
Fish
Raw Normal View History

Make tests usable with path with spaces This is somewhat subtle: The #RUN line in a littlecheck file will be run by a posix shell, which means the substitutions will also be mangled by it. Now, we *have* shell-quoted them, but unfortunately what we need is to quote them for inside a pre-existing layer of quotes, e.g. # RUN: fish -C 'set -g fish %fish' here, %fish can't be replaced with `'path with spaces/fish'`, because that ends up as # RUN: fish -C 'set -g fish 'path with spaces/fish'' which is just broken. So instead, we pass it as a variable to that fish: # RUN: fish=%fish fish... In addition, we need to not mangle the arguments in our test_driver. For that, because we insist on posix shell, which has only one array, and we source a file, we *need* to stop having that file use arguments. Which is okay - test_env.sh could previously be used to start a test, and now it no longer can because that is test_*driver*.sh's job. For the interactive tests, it's slightly different: pexpect.spawn(foo) is sensitive to shell metacharacters like space. So we shell-quote it. But if you pass any args to pexpect.spawn, it no longer uses a shell, and so we cannot shell-quote it. There could be a better way to fix this?
2024-12-27 19:54:43 +00:00
# RUN: env fish_test_helper=%fish_test_helper fish=%fish %fish %s
tests: Specifically #require fish_test_helper when needed
2024-12-26 12:30:09 +00:00
#REQUIRES: command -v %fish_test_helper
Fix status when function/block evaluation is cancelled It looks like the last status already contains the signal that cancelled execution. Also make `fish -c something` always return the last exit status of "something", instead of hardcoded 127 if exited or signalled. Fixes #6444
2019-12-23 12:49:40 +00:00
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-13 19:34:22 +00:00
$fish -c 'function main; exit 4; true; end; main'
echo $status
Fix status when function/block evaluation is cancelled It looks like the last status already contains the signal that cancelled execution. Also make `fish -c something` always return the last exit status of "something", instead of hardcoded 127 if exited or signalled. Fixes #6444
2019-12-23 12:49:40 +00:00
#CHECK: 4
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-13 19:34:22 +00:00
$fish -c 'begin; exit 5; true; end'
echo $status
Fix status when function/block evaluation is cancelled It looks like the last status already contains the signal that cancelled execution. Also make `fish -c something` always return the last exit status of "something", instead of hardcoded 127 if exited or signalled. Fixes #6444
2019-12-23 12:49:40 +00:00
#CHECK: 5
Purge remnants of process expansion, document {fish,last}_pid
2020-05-16 09:20:18 +00:00
$fish -c 'kill -SIGHUP $fish_pid'
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-13 19:34:22 +00:00
echo $status
Fix status when function/block evaluation is cancelled It looks like the last status already contains the signal that cancelled execution. Also make `fish -c something` always return the last exit status of "something", instead of hardcoded 127 if exited or signalled. Fixes #6444
2019-12-23 12:49:40 +00:00
#CHECK: 129
Purge remnants of process expansion, document {fish,last}_pid
2020-05-16 09:20:18 +00:00
$fish -c 'function main; kill -SIGTERM $fish_pid; true; end; main'
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-13 19:34:22 +00:00
echo $status
Fix status when function/block evaluation is cancelled It looks like the last status already contains the signal that cancelled execution. Also make `fish -c something` always return the last exit status of "something", instead of hardcoded 127 if exited or signalled. Fixes #6444
2019-12-23 12:49:40 +00:00
#CHECK: 143
Port signal tests to littlecheck
2019-06-26 18:07:46 +00:00
Add basic signal test
2019-02-21 01:07:29 +00:00
function alarm --on-signal ALRM
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-13 19:34:22 +00:00
echo ALRM received
Add basic signal test
2019-02-21 01:07:29 +00:00
end
kill -s ALRM $fish_pid
Port signal tests to littlecheck
2019-06-26 18:07:46 +00:00
# CHECK: ALRM received
Add basic signal test
2019-02-21 01:07:29 +00:00
Enhance the signal test
2019-02-23 20:41:01 +00:00
function anychild --on-process-exit 0
Separate on-job-exit and and on-process-exit events It is possible to run a function when a process exits via `function --on-process-exit`, or when a job exits via `function --on-job-exits`. Internally these were distinguished by the pid in the event: if it was positive, then it was a process exit. If negative, it represents a pgid and is a job exit. If zero, it fires for both jobs and processes, which is pretty weird. Switch to tracking these explicitly. Separate out the --on-process-exit and --on-job-exit event types into separate types. Stop negating pgids as well.
2021-05-19 18:29:03 +00:00
# Type and exit status
echo $argv[1] $argv[3]
end
function anyjob --on-job-exit 0
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-13 19:34:22 +00:00
# Type and exit status
echo $argv[1] $argv[3]
Enhance the signal test
2019-02-23 20:41:01 +00:00
end
Event blocks just block all events In a galaxy far, far away, event_blockage_t was intended to block only cetain events. But it always just blocked everything. Eliminate the event block mask.
2019-02-21 05:41:35 +00:00
echo "command false:"
Enhance the signal test
2019-02-23 20:41:01 +00:00
command false
Port signal tests to littlecheck
2019-06-26 18:07:46 +00:00
# CHECK: command false:
Fix some tests for OpenIndiana Slightly different output and status - false returns 255, ls doesn't say it's "ls" in the error.
2021-06-24 16:14:45 +00:00
# (Solaris' false exits with 255, not 1)
# CHECK: PROCESS_EXIT {{1|255}}
Port signal tests to littlecheck
2019-06-26 18:07:46 +00:00
# CHECK: JOB_EXIT 0
Event blocks just block all events In a galaxy far, far away, event_blockage_t was intended to block only cetain events. But it always just blocked everything. Eliminate the event block mask.
2019-02-21 05:41:35 +00:00
echo "command true:"
Enhance the signal test
2019-02-23 20:41:01 +00:00
command true
Port signal tests to littlecheck
2019-06-26 18:07:46 +00:00
# CHECK: command true:
# CHECK: PROCESS_EXIT 0
# CHECK: JOB_EXIT 0
Event blocks just block all events In a galaxy far, far away, event_blockage_t was intended to block only cetain events. But it always just blocked everything. Eliminate the event block mask.
2019-02-21 05:41:35 +00:00
echo "command false | true:"
Enhance the signal test
2019-02-23 20:41:01 +00:00
command false | command true
Port signal tests to littlecheck
2019-06-26 18:07:46 +00:00
# CHECK: command false | true:
Fix some tests for OpenIndiana Slightly different output and status - false returns 255, ls doesn't say it's "ls" in the error.
2021-06-24 16:14:45 +00:00
# CHECK: PROCESS_EXIT {{1|255}}
Port signal tests to littlecheck
2019-06-26 18:07:46 +00:00
# CHECK: PROCESS_EXIT 0
# CHECK: JOB_EXIT 0
Event blocks just block all events In a galaxy far, far away, event_blockage_t was intended to block only cetain events. But it always just blocked everything. Eliminate the event block mask.
2019-02-21 05:41:35 +00:00
Pass $status to process-exit event handlers in all cases Previously, an event handler would receive -1 if the process exited due to a signal. Instead pass the same value as $status.
2021-05-17 21:34:52 +00:00
# Signals are reported correctly.
# SIGKILL $status is 128 + 9 = 137
$fish_test_helper sigkill_self
# CHECK: PROCESS_EXIT 137
# CHECK: JOB_EXIT 0
Event blocks just block all events In a galaxy far, far away, event_blockage_t was intended to block only cetain events. But it always just blocked everything. Eliminate the event block mask.
2019-02-21 05:41:35 +00:00
function test_blocks
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-13 19:34:22 +00:00
block -l
Pass $status to process-exit event handlers in all cases Previously, an event handler would receive -1 if the process exited due to a signal. Instead pass the same value as $status.
2021-05-17 21:34:52 +00:00
command echo "This is the process whose exit event should be blocked"
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-13 19:34:22 +00:00
echo "This should come before the event handler"
Event blocks just block all events In a galaxy far, far away, event_blockage_t was intended to block only cetain events. But it always just blocked everything. Eliminate the event block mask.
2019-02-21 05:41:35 +00:00
end
test_blocks
Pass $status to process-exit event handlers in all cases Previously, an event handler would receive -1 if the process exited due to a signal. Instead pass the same value as $status.
2021-05-17 21:34:52 +00:00
# CHECK: This is the process whose exit event should be blocked
Port signal tests to littlecheck
2019-06-26 18:07:46 +00:00
# CHECK: This should come before the event handler
Event blocks just block all events In a galaxy far, far away, event_blockage_t was intended to block only cetain events. But it always just blocked everything. Eliminate the event block mask.
2019-02-21 05:41:35 +00:00
echo "Now event handler should have run"
Port signal tests to littlecheck
2019-06-26 18:07:46 +00:00
# CHECK: PROCESS_EXIT 0
# CHECK: JOB_EXIT 0
# CHECK: Now event handler should have run
# CHECK: PROCESS_EXIT 0
Reference in a new issue Copy permalink