Mirrors/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell synced 2024-12-27 05:13:10 +00:00
Code Issues Projects Releases Packages Wiki Activity
fish-shell/tests/checks/string.fish

1168 lines
29 KiB
Fish
Raw Normal View History

tests: filter control sequences only when interactive This demonstrates that we only write control sequences when interactive.
2024-04-12 10:19:32 +00:00
#RUN: %fish %s
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
# Tests for string builtin. Mostly taken from man page examples.
string match -r -v "c.*" dog can cat diz; and echo "exit 0"
# CHECK: dog
# CHECK: diz
# CHECK: exit 0
string match -q -r -v "c.*" dog can cat diz; and echo "exit 0"
# CHECK: exit 0
string match -v "c*" dog can cat diz; and echo "exit 0"
# CHECK: dog
# CHECK: diz
# CHECK: exit 0
string match -q -v "c*" dog can cat diz; and echo "exit 0"
# CHECK: exit 0
string match -v "d*" dog dan dat diz; or echo "exit 1"
# CHECK: exit 1
string match -q -v "d*" dog dan dat diz; or echo "exit 1"
# CHECK: exit 1
string match -r -v x y; and echo "exit 0"
# CHECK: y
# CHECK: exit 0
string match -r -v x x; or echo "exit 1"
# CHECK: exit 1
string match -q -r -v x y; and echo "exit 0"
# CHECK: exit 0
string match -q -r -v x x; or echo "exit 1"
# CHECK: exit 1
string length "hello, world"
# CHECK: 12
string length -q ""; and echo not zero length; or echo zero length
# CHECK: zero length
New command "string pad" to pad text to a given width (#7340) Pads text to a given width, or the maximum width of all inputs.
2020-09-27 17:12:42 +00:00
string pad foo
# CHECK: foo
Port builtins/string to Rust - Add test to verify piped string replace exit code Ensure fields parsing error messages are the same. Note: C++ relied upon the value of the parsed value even when `errno` was set, that is defined behaviour we should not rely on, and cannot easilt be replicated from Rust. Therefore the Rust version will change the following error behaviour from: ```shell > string split --fields=a "" abc string split: Invalid fields value 'a' > string split --fields=1a "" abc string split: 1a: invalid integer ``` To: ```shell > string split --fields=a "" abc string split: a: invalid integer > string split --fields=1a "" abc string split: 1a: invalid integer ```
2023-06-20 02:28:35 +00:00
string pad -r -w 7 --chars - foo
New command "string pad" to pad text to a given width (#7340) Pads text to a given width, or the maximum width of all inputs.
2020-09-27 17:12:42 +00:00
# CHECK: foo----
Port builtins/string to Rust - Add test to verify piped string replace exit code Ensure fields parsing error messages are the same. Note: C++ relied upon the value of the parsed value even when `errno` was set, that is defined behaviour we should not rely on, and cannot easilt be replicated from Rust. Therefore the Rust version will change the following error behaviour from: ```shell > string split --fields=a "" abc string split: Invalid fields value 'a' > string split --fields=1a "" abc string split: 1a: invalid integer ``` To: ```shell > string split --fields=a "" abc string split: a: invalid integer > string split --fields=1a "" abc string split: 1a: invalid integer ```
2023-06-20 02:28:35 +00:00
# might overflow when converting sign
string sub --start -9223372036854775808 abc
# CHECK: abc
New command "string pad" to pad text to a given width (#7340) Pads text to a given width, or the maximum width of all inputs.
2020-09-27 17:12:42 +00:00
string pad --width 7 -c '=' foo
# CHECK: ====foo
echo \|(string pad --width 10 --right foo)\|
# CHECK: |foo |
Set fish_emoji_width in test to guard against older wcwidth See #7340
2020-09-28 15:53:27 +00:00
begin
set -l fish_emoji_width 2
# Pad string with multi-width emoji.
string pad -w 4 -c . 🐟
# CHECK: ..🐟
# Pad with multi-width character.
string pad -w 3 -c 🐟 .
# CHECK: 🐟.
# Multi-width pad with remainder, complemented with a space.
string pad -w 4 -c 🐟 . ..
# CHECK: 🐟 .
# CHECK: 🐟..
end
string pad: handle padding characters of width > 1 If the padding is not divisible by the char's width without remainder, we pad the remainder with spaces, so the total width of the output is correct. Also add completions, changelog entry, adjust documentation, add examples with emoji and some tests. Apply some minor style nitpicks and avoid extra allocations of the input strings.
2020-09-27 19:51:20 +00:00
# Pad to the maximum length.
New command "string pad" to pad text to a given width (#7340) Pads text to a given width, or the maximum width of all inputs.
2020-09-27 17:12:42 +00:00
string pad -c . long longer longest
# CHECK: ...long
# CHECK: .longer
# CHECK: longest
string pad: handle padding characters of width > 1 If the padding is not divisible by the char's width without remainder, we pad the remainder with spaces, so the total width of the output is correct. Also add completions, changelog entry, adjust documentation, add examples with emoji and some tests. Apply some minor style nitpicks and avoid extra allocations of the input strings.
2020-09-27 19:51:20 +00:00
# This tests current behavior where the max width of an argument overrules
# the width parameter. This could be changed if needed.
string pad -c_ --width 5 longer-than-width-param x
# CHECK: longer-than-width-param
# CHECK: ______________________x
# Current behavior is that only a single padding character is supported.
# We can support longer strings in future without breaking compatibilty.
string pad -c ab -w4 .
# CHECKERR: string pad: Padding should be a character 'ab'
Fix behaviour in the presence of non-visible width Padding with an unprintable character is now disallowed, like it was for other zero-length characters. `string shorten` now ignores escape sequences and non-printable characters when calculating the visible width of the ellipsis used (except for `\b`, which is treated as a width of -1). Previously `fish_wcswidth` returned a length of -1 when the ellipsis-str contained any non-printable character, causing the command to poentially print a larger width than expected. This also fixes an integer overflows in `string shorten`'s `max` and `max2`, when the cumulative sum of character widths turned negative (e.g. with any non-printable characters, or `\b` after the changes above). The overflow potentially caused strings containing non-printable characters to be truncated. This adds test that verify the fixed behaviour.
2023-07-13 02:17:19 +00:00
# nonprintable characters does not make sense
string pad -c \u07 .
# CHECKERR: string pad: Invalid padding character of width zero {{'\a'}}
Let visible length work with CR and LF Because we are, ultimately, interested in how many cells a string occupies, we *have* to handle carriage return (`\r`) and line feed (`\n`). A carriage return sets the current tally to 0, and only the longest tally is kept. The idea here is that the last position is the same as the last position of the longest string. So: abcdef\r123 ends up looking like 123def which is the same width as abcdef, 6. A line feed meanwhile means we flush the current tally and start a new one. Every line is printed separately, even if it's given as one. That's because, well, counting the width over multiple lines doesn't *help*. As a sidenote: This is necessarily imperfect, because, while we may know the width of the terminal ($COLUMNS), we don't know the current cursor position. So we can only give the width, and the user can then figure something out on their own. But for the common case of figuring out how wide the prompt is, this should do.
2021-07-29 18:49:14 +00:00
# Visible length. Let's start off simple, colors are ignored:
string length --visible (set_color red)abc
# CHECK: 3
begin
set -l fish_emoji_width 2
# This should print the emoji width
Change our test emoji The emoji we used wasn't actually widened-in-9, so we now switch to one that does.
2022-02-14 21:31:30 +00:00
string length --visible . \U2693
Let visible length work with CR and LF Because we are, ultimately, interested in how many cells a string occupies, we *have* to handle carriage return (`\r`) and line feed (`\n`). A carriage return sets the current tally to 0, and only the longest tally is kept. The idea here is that the last position is the same as the last position of the longest string. So: abcdef\r123 ends up looking like 123def which is the same width as abcdef, 6. A line feed meanwhile means we flush the current tally and start a new one. Every line is printed separately, even if it's given as one. That's because, well, counting the width over multiple lines doesn't *help*. As a sidenote: This is necessarily imperfect, because, while we may know the width of the terminal ($COLUMNS), we don't know the current cursor position. So we can only give the width, and the user can then figure something out on their own. But for the common case of figuring out how wide the prompt is, this should do.
2021-07-29 18:49:14 +00:00
# CHECK: 1
# CHECK: 2
set -l fish_emoji_width 1
Change our test emoji The emoji we used wasn't actually widened-in-9, so we now switch to one that does.
2022-02-14 21:31:30 +00:00
string length --visible . \U2693
Let visible length work with CR and LF Because we are, ultimately, interested in how many cells a string occupies, we *have* to handle carriage return (`\r`) and line feed (`\n`). A carriage return sets the current tally to 0, and only the longest tally is kept. The idea here is that the last position is the same as the last position of the longest string. So: abcdef\r123 ends up looking like 123def which is the same width as abcdef, 6. A line feed meanwhile means we flush the current tally and start a new one. Every line is printed separately, even if it's given as one. That's because, well, counting the width over multiple lines doesn't *help*. As a sidenote: This is necessarily imperfect, because, while we may know the width of the terminal ($COLUMNS), we don't know the current cursor position. So we can only give the width, and the user can then figure something out on their own. But for the common case of figuring out how wide the prompt is, this should do.
2021-07-29 18:49:14 +00:00
# CHECK: 1
# CHECK: 1
end
# Only the longest run between carriage returns is kept because the rest is overwritten.
string length --visible (set_color normal)abcdef\rfooba(set_color red)raaa
# (foobaraaa)
# CHECK: 9
# Visible length is *always* split by line
string length --visible a(set_color blue)b\ncde
# CHECK: 2
# CHECK: 3
Handle backspaces for visible width This makes it so we treat backspaces as width -1, but never go below a 0 total width when talking about *lines*, like in screen or string length --visible. Fixes #8277.
2021-09-23 10:57:44 +00:00
# Backslashes and visible length:
# It can't move us before the start of the line.
string length --visible \b
# CHECK: 0
# It can't move us before the start of the line.
string length --visible \bf
# CHECK: 1
# But it does erase chars before.
string length --visible \bf\b
# CHECK: 0
# Never move past 0.
string length --visible \bf\b\b\b\b\b
# CHECK: 0
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
string sub --length 2 abcde
# CHECK: ab
string sub -s 2 -l 2 abcde
# CHECK: bc
string sub --start=-2 abcde
# CHECK: de
Add `string sub --end` (#6765)
2020-03-22 14:53:09 +00:00
string sub --end=3 abcde
# CHECK: abc
string sub --end=-4 abcde
# CHECK: a
string sub --start=2 --end=-2 abcde
# CHECK: bc
string sub -s -5 -e -2 abcdefgh
# CHECK: def
string sub -s -100 -e -2 abcde
# CHECK: abc
string sub -s -5 -e 2 abcde
# CHECK: ab
string sub -s -50 -e -100 abcde
# CHECK:
string sub -s 2 -e -5 abcde
# CHECK:
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
string split . example.com
# CHECK: example
# CHECK: com
string split -r -m1 / /usr/local/bin/fish
# CHECK: /usr/local/bin
# CHECK: fish
string split "" abc
# CHECK: a
# CHECK: b
# CHECK: c
Port builtins/string to Rust - Add test to verify piped string replace exit code Ensure fields parsing error messages are the same. Note: C++ relied upon the value of the parsed value even when `errno` was set, that is defined behaviour we should not rely on, and cannot easilt be replicated from Rust. Therefore the Rust version will change the following error behaviour from: ```shell > string split --fields=a "" abc string split: Invalid fields value 'a' > string split --fields=1a "" abc string split: 1a: invalid integer ``` To: ```shell > string split --fields=a "" abc string split: a: invalid integer > string split --fields=1a "" abc string split: 1a: invalid integer ```
2023-06-20 02:28:35 +00:00
string split --max 1 --right 12 "AB12CD"
# CHECK: AB
# CHECK: CD
Add `string split --fields`
2020-03-20 16:31:23 +00:00
string split --fields=2 "" abc
# CHECK: b
Allow simple ranges to be specified for `--fields`
2020-03-21 16:30:00 +00:00
string split --fields=3,2 "" abc
Add `string split --fields`
2020-03-20 16:31:23 +00:00
# CHECK: c
Allow simple ranges to be specified for `--fields`
2020-03-21 16:30:00 +00:00
# CHECK: b
Add `string split --fields`
2020-03-20 16:31:23 +00:00
Return 1 if non-existent field is given
2020-03-24 14:25:37 +00:00
string split --fields=2,9 "" abc; or echo "exit 1"
# CHECK: exit 1
Add `string split --fields`
2020-03-20 16:31:23 +00:00
Port builtins/string to Rust - Add test to verify piped string replace exit code Ensure fields parsing error messages are the same. Note: C++ relied upon the value of the parsed value even when `errno` was set, that is defined behaviour we should not rely on, and cannot easilt be replicated from Rust. Therefore the Rust version will change the following error behaviour from: ```shell > string split --fields=a "" abc string split: Invalid fields value 'a' > string split --fields=1a "" abc string split: 1a: invalid integer ``` To: ```shell > string split --fields=a "" abc string split: a: invalid integer > string split --fields=1a "" abc string split: 1a: invalid integer ```
2023-06-20 02:28:35 +00:00
string split --fields=2-3-,9 "" a
# CHECKERR: string split: 2-3-,9: invalid integer
string split --fields=1-99999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999 "" abc
# CHECKERR: string split: 1-99999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999: invalid integer
string split --fields=99999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999-1 "" abc
# CHECKERR: string split: 99999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999-1: invalid integer
string split --fields=1--2 "" b
# CHECKERR: string split: 1--2: invalid integer
string split --fields=0 "" c
# CHECKERR: string split: Invalid fields value '0'
string split --fields=99999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999 "" abc
# CHECKERR: string split: 99999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999: invalid integer
string split --fields=1-0 "" d
# CHECKERR: string split: Invalid range value for field '1-0'
string split --fields=0-1 "" e
# CHECKERR: string split: Invalid range value for field '0-1'
string split --fields=-1 "" f
# CHECKERR: string split: -1: invalid integer
string split --fields=1a "" g
# CHECKERR: string split: 1a: invalid integer
string split --fields=a "" h
# CHECKERR: string split: a: invalid integer
Allow simple ranges to be specified for `--fields`
2020-03-21 16:30:00 +00:00
string split --fields=1-3,5,9-7 "" 123456789
# CHECK: 1
# CHECK: 2
# CHECK: 3
# CHECK: 5
# CHECK: 9
# CHECK: 8
# CHECK: 7
string split --fields: handle multi-line/arg input
2020-04-18 04:03:54 +00:00
string split -f1 ' ' 'a b' 'c d'
# CHECK: a
# CHECK: c
string split: add `--allow-empty` flag to be used with `--fields`
2020-04-18 06:25:08 +00:00
string split --allow-empty --fields=2,9 "" abc
# CHECK: b
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
seq 3 | string join ...
# CHECK: 1...2...3
string trim " abc "
# CHECK: abc
string trim --right --chars=yz xyzzy zany
# CHECK: x
# CHECK: zan
echo \x07 | string escape
# CHECK: \cg
string escape --style=script 'a b#c"\'d'
Support quoted escaping also when ' or \ is present Also, if there are more single quotes than double quotes and dollars, use double quotes for quoting.
2024-04-12 23:00:44 +00:00
# CHECK: 'a b#c"\'d'
string escape --no-quoted --style=script 'a b#c"\'d'
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
# CHECK: a\ b\#c\"\'d
string escape --style=url 'a b#c"\'d'
# CHECK: a%20b%23c%22%27d
string escape --style=url \na\nb%c~d\n
# CHECK: %0Aa%0Ab%25c~d%0A
string escape --style=var 'a b#c"\'d'
# CHECK: a_20_b_23_c_22_27_d
string escape --style=var a\nghi_
# CHECK: a_0A_ghi__
Reindent functions to remove useless quotes This does not include checks/function.fish because that currently includes a "; end" in a message that indent would remove, breaking the test.
2020-03-09 18:36:12 +00:00
string escape --style=var abc
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
# CHECK: abc
Reindent functions to remove useless quotes This does not include checks/function.fish because that currently includes a "; end" in a message that indent would remove, breaking the test.
2020-03-09 18:36:12 +00:00
string escape --style=var _a_b_c_
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
# CHECK: __a__b__c__
string escape --style=var -- -
# CHECK: _2D_
# string escape with multibyte chars
string escape --style=url aöb
string escape --style=url 中
string escape --style=url aöb | string unescape --style=url
string escape --style=url 中 | string unescape --style=url
string escape --style=var aöb
string escape --style=var 中
string escape --style=var aöb | string unescape --style=var
string escape --style=var 中 | string unescape --style=var
# CHECK: a%C3%B6b
# CHECK: %E4%B8%AD
# CHECK: aöb
# CHECK: 中
# CHECK: a_C3_B6_b
# CHECK: _E4_B8_AD_
# CHECK: aöb
# CHECK: 中
# test regex escaping
string escape --style=regex ".ext"
string escape --style=regex "bonjour, amigo"
string escape --style=regex "^this is a literal string"
string: Also escape new lines with --style=regex This isn't *required* in the PCRE2 spec but it greatly increases the utility of escaped regex strings at the commandline.
2024-07-16 22:05:11 +00:00
string escape --style=regex "hello
world"
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
# CHECK: \.ext
# CHECK: bonjour, amigo
# CHECK: \^this is a literal string
string: Also escape new lines with --style=regex This isn't *required* in the PCRE2 spec but it greatly increases the utility of escaped regex strings at the commandline.
2024-07-16 22:05:11 +00:00
# CHECK: hello\nworld
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
### Verify that we can correctly unescape the same strings
# we tested escaping above.
set x (string unescape (echo \x07 | string escape))
test $x = \x07
and echo success
# CHECK: success
string unescape --style=script (string escape --style=script 'a b#c"\'d')
# CHECK: a b#c"'d
string unescape --style=url (string escape --style=url 'a b#c"\'d')
# CHECK: a b#c"'d
string unescape --style=url (string escape --style=url \na\nb%c~d\n)
New command "string pad" to pad text to a given width (#7340) Pads text to a given width, or the maximum width of all inputs.
2020-09-27 17:12:42 +00:00
# CHECK:
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
# CHECK: a
# CHECK: b%c~d
string unescape --style=var (string escape --style=var 'a b#c"\'d')
# CHECK: a b#c"'d
string unescape --style=var (string escape --style=var a\nghi_)
# CHECK: a
# CHECK: ghi_
string unescape --style=var (string escape --style=var 'abc')
# CHECK: abc
string unescape --style=var (string escape --style=var '_a_b_c_')
# CHECK: _a_b_c_
string unescape --style=var -- (string escape --style=var -- -)
# CHECK: -
### Verify that we can correctly match strings.
string match "*" a
# CHECK: a
string match "a*b" axxb
# CHECK: axxb
string match -i "a**B" Axxb
# CHECK: Axxb
echo "ok?" | string match "*?"
# CHECK: ok?
string match -r "cat|dog|fish" "nice dog"
# CHECK: dog
string match -r "(\d\d?):(\d\d):(\d\d)" 2:34:56
# CHECK: 2:34:56
# CHECK: 2
# CHECK: 34
# CHECK: 56
string match -r "^(\w{2,4})\g1\$" papa mud murmur
# CHECK: papa
# CHECK: pa
# CHECK: murmur
# CHECK: mur
string match -r -a -n at ratatat
# CHECK: 2 2
# CHECK: 4 2
# CHECK: 6 2
string match -r -i "0x[0-9a-f]{1,8}" "int magic = 0xBadC0de;"
# CHECK: 0xBadC0de
string replace is was "blue is my favorite"
# CHECK: blue was my favorite
string replace 3rd last 1st 2nd 3rd
# CHECK: 1st
# CHECK: 2nd
# CHECK: last
string replace -a " " _ "spaces to underscores"
# CHECK: spaces_to_underscores
string replace -r -a "[^\d.]+" " " "0 one two 3.14 four 5x"
New command "string pad" to pad text to a given width (#7340) Pads text to a given width, or the maximum width of all inputs.
2020-09-27 17:12:42 +00:00
# CHECK: 0 3.14 5
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
string replace -r "(\w+)\s+(\w+)" "\$2 \$1 \$\$" "left right"
# CHECK: right left $
string replace -r "\s*newline\s*" "\n" "put a newline here"
# CHECK: put a
# CHECK: here
string replace -r -a "(\w)" "\$1\$1" ab
# CHECK: aabb
Port builtins/string to Rust - Add test to verify piped string replace exit code Ensure fields parsing error messages are the same. Note: C++ relied upon the value of the parsed value even when `errno` was set, that is defined behaviour we should not rely on, and cannot easilt be replicated from Rust. Therefore the Rust version will change the following error behaviour from: ```shell > string split --fields=a "" abc string split: Invalid fields value 'a' > string split --fields=1a "" abc string split: 1a: invalid integer ``` To: ```shell > string split --fields=a "" abc string split: a: invalid integer > string split --fields=1a "" abc string split: 1a: invalid integer ```
2023-06-20 02:28:35 +00:00
echo a | string replace b c -q
or echo No replace fails
# CHECK: No replace fails
echo a | string replace -r b c -q
or echo No replace regex fails
# CHECK: No replace regex fails
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
string replace --filter x X abc axc x def jkx
or echo Unexpected exit status at line (status --current-line-number)
# CHECK: aXc
# CHECK: X
# CHECK: jkX
string replace --filter y Y abc axc x def jkx
and echo Unexpected exit status at line (status --current-line-number)
string replace --regex -f "\d" X 1bc axc 2 d3f jk4 xyz
or echo Unexpected exit status at line (status --current-line-number)
# CHECK: Xbc
# CHECK: X
# CHECK: dXf
# CHECK: jkX
Reindent functions to remove useless quotes This does not include checks/function.fish because that currently includes a "; end" in a message that indent would remove, breaking the test.
2020-03-09 18:36:12 +00:00
string replace --regex -f Z X 1bc axc 2 d3f jk4 xyz
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
and echo Unexpected exit status at line (status --current-line-number)
# From https://github.com/fish-shell/fish-shell/issues/5201
# 'string match -r with empty capture groups'
string match -r '^([ugoa]*)([=+-]?)([rwx]*)$' '=r'
#CHECK: =r
New command "string pad" to pad text to a given width (#7340) Pads text to a given width, or the maximum width of all inputs.
2020-09-27 17:12:42 +00:00
#CHECK:
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
#CHECK: =
#CHECK: r
### Test some failure cases
string match -r "[" "a[sd"; and echo "unexpected exit 0"
# CHECKERR: string match: Regular expression compile error: missing terminating ] for character class
# CHECKERR: string match: [
# CHECKERR: string match: ^
# FIXME: This prints usage summary?
#string invalidarg; and echo "unexpected exit 0"
# DONTCHECKERR: string: Subcommand 'invalidarg' is not valid
string length; or echo "missing argument returns 1"
# CHECK: missing argument returns 1
string match -r -v "[dcantg].*" dog can cat diz; or echo "no regexp invert match"
# CHECK: no regexp invert match
string match -v "*" dog can cat diz; or echo "no glob invert match"
# CHECK: no glob invert match
string match -rvn a bbb; or echo "exit 1"
# CHECK: 1 3
### Test repeat subcommand
Reindent functions to remove useless quotes This does not include checks/function.fish because that currently includes a "; end" in a message that indent would remove, breaking the test.
2020-03-09 18:36:12 +00:00
string repeat -n 2 foo
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
# CHECK: foofoo
Reindent functions to remove useless quotes This does not include checks/function.fish because that currently includes a "; end" in a message that indent would remove, breaking the test.
2020-03-09 18:36:12 +00:00
string repeat --count 2 foo
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
# CHECK: foofoo
string repeat: allow omission of `-n` (#10282)
2024-02-11 11:19:02 +00:00
string repeat 2 foo
# CHECK: foofoo
string repeat 2 -n 3
# CHECK: 222
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
echo foo | string repeat -n 2
# CHECK: foofoo
string repeat: allow omission of `-n` (#10282)
2024-02-11 11:19:02 +00:00
echo foo | string repeat 2
# CHECK: foofoo
string repeat foo
# CHECKERR: string repeat: Invalid count value 'foo'
Reindent functions to remove useless quotes This does not include checks/function.fish because that currently includes a "; end" in a message that indent would remove, breaking the test.
2020-03-09 18:36:12 +00:00
string repeat -n2 -q foo; and echo "exit 0"
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
# CHECK: exit 0
Reindent functions to remove useless quotes This does not include checks/function.fish because that currently includes a "; end" in a message that indent would remove, breaking the test.
2020-03-09 18:36:12 +00:00
string repeat -n2 --quiet foo; and echo "exit 0"
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
# CHECK: exit 0
Reindent functions to remove useless quotes This does not include checks/function.fish because that currently includes a "; end" in a message that indent would remove, breaking the test.
2020-03-09 18:36:12 +00:00
string repeat -n0 foo; or echo "exit 1"
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
# CHECK: exit 1
string repeat -n0; or echo "exit 1"
# CHECK: exit 1
string repeat -m0; or echo "exit 1"
# CHECK: exit 1
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-13 19:34:22 +00:00
string repeat -n1 -N "there is "
echo "no newline"
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
# CHECK: there is no newline
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-13 19:34:22 +00:00
string repeat -n1 --no-newline "there is "
echo "no newline"
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
# CHECK: there is no newline
Reindent functions to remove useless quotes This does not include checks/function.fish because that currently includes a "; end" in a message that indent would remove, breaking the test.
2020-03-09 18:36:12 +00:00
string repeat -n10 -m4 foo
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
# CHECK: foof
Reindent functions to remove useless quotes This does not include checks/function.fish because that currently includes a "; end" in a message that indent would remove, breaking the test.
2020-03-09 18:36:12 +00:00
string repeat -n10 --max 5 foo
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
# CHECK: foofo
Reindent functions to remove useless quotes This does not include checks/function.fish because that currently includes a "; end" in a message that indent would remove, breaking the test.
2020-03-09 18:36:12 +00:00
string repeat -n3 -m20 foo
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
# CHECK: foofoofoo
Reindent functions to remove useless quotes This does not include checks/function.fish because that currently includes a "; end" in a message that indent would remove, breaking the test.
2020-03-09 18:36:12 +00:00
string repeat -m4 foo
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
# CHECK: foof
Teach string repeat to handle multiple arguments Each argument in string repeat is handled independently, except that the --no-newline option applies only to the last newline. Fixes #5988
2021-01-12 00:30:33 +00:00
string repeat -n 5 a b c
# CHECK: aaaaa
# CHECK: bbbbb
# CHECK: ccccc
string repeat -n 5 --max 4 123 456 789
# CHECK: 1231
# CHECK: 4564
# CHECK: 7897
string repeat -n 5 --max 4 123 '' 789
# CHECK: 1231
# CHECK:
# CHECK: 7897
Port builtins/string to Rust - Add test to verify piped string replace exit code Ensure fields parsing error messages are the same. Note: C++ relied upon the value of the parsed value even when `errno` was set, that is defined behaviour we should not rely on, and cannot easilt be replicated from Rust. Therefore the Rust version will change the following error behaviour from: ```shell > string split --fields=a "" abc string split: Invalid fields value 'a' > string split --fields=1a "" abc string split: 1a: invalid integer ``` To: ```shell > string split --fields=a "" abc string split: a: invalid integer > string split --fields=1a "" abc string split: 1a: invalid integer ```
2023-06-20 02:28:35 +00:00
# FIXME: handle overflowing nicely
# overflow behaviour depends on 32 vs 64 bit
# count here is isize::MAX
# we store what to print as usize, so this will overflow
# but we limit it to less than whatever the overflow is
# so this should be fine
# string repeat -m1 -n 9223372036854775807 aa
# DONTCHECK: a
# count is here (i64::MAX + 1) / 2
# we end up overflowing, and the result is 0
# but this should work fine, as we limit it way before the overflow
# string repeat -m1 -n 4611686018427387904 aaaa
# DONTCHECK: a
Teach string repeat to handle multiple arguments Each argument in string repeat is handled independently, except that the --no-newline option applies only to the last newline. Fixes #5988
2021-01-12 00:30:33 +00:00
# Historical string repeat behavior is no newline if no output.
echo -n before
string repeat -n 5 ''
echo after
# CHECK: beforeafter
Reindent functions to remove useless quotes This does not include checks/function.fish because that currently includes a "; end" in a message that indent would remove, breaking the test.
2020-03-09 18:36:12 +00:00
string repeat -n-1 foo; and echo "exit 0"
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
# CHECKERR: string repeat: Invalid count value '-1'
Reindent functions to remove useless quotes This does not include checks/function.fish because that currently includes a "; end" in a message that indent would remove, breaking the test.
2020-03-09 18:36:12 +00:00
string repeat -m-1 foo; and echo "exit 0"
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
# CHECKERR: string repeat: Invalid max value '-1'
Reindent functions to remove useless quotes This does not include checks/function.fish because that currently includes a "; end" in a message that indent would remove, breaking the test.
2020-03-09 18:36:12 +00:00
string repeat -n notanumber foo; and echo "exit 0"
Update tests for changed error output
2021-11-04 05:52:17 +00:00
# CHECKERR: string repeat: notanumber: invalid integer
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
Reindent functions to remove useless quotes This does not include checks/function.fish because that currently includes a "; end" in a message that indent would remove, breaking the test.
2020-03-09 18:36:12 +00:00
string repeat -m notanumber foo; and echo "exit 0"
Update tests for changed error output
2021-11-04 05:52:17 +00:00
# CHECKERR: string repeat: notanumber: invalid integer
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
Reindent functions to remove useless quotes This does not include checks/function.fish because that currently includes a "; end" in a message that indent would remove, breaking the test.
2020-03-09 18:36:12 +00:00
echo stdin | string repeat -n1 "and arg"; and echo "exit 0"
Update tests for changed error output
2021-11-04 05:52:17 +00:00
# CHECKERR: string repeat: too many arguments
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
string repeat -n; and echo "exit 0"
Update tests for changed error output
2021-11-04 05:52:17 +00:00
# CHECKERR: string repeat: -n: option requires an argument
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
# FIXME: Also triggers usage
# string repeat -l fakearg
# DONTCHECKERR: string repeat: Unknown option '-l'
string repeat ""
string repeat: allow omission of `-n` (#10282)
2024-02-11 11:19:02 +00:00
# CHECKERR: string repeat: Invalid count value ''
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
string repeat -n3 ""
or echo string repeat empty string failed
# CHECK: string repeat empty string failed
string repeat: Don't allocate repeated string all at once (#9124) * string repeat: Don't allocate repeated string all at once This used to allocate one string and fill it with the necessary repetitions, which could be a very very large string. Now, it instead uses one buffer and fills it to a chunk size, and then writes that. This fixes: 1. We no longer crash with too large max/count values. Before they caused a bad_alloc because we tried to fill all RAM. 2. We no longer fill all RAM if given a big-but-not-too-big value. You could've caused fish to eat *most* of your RAM here. 3. It can start writing almost immediately, instead of waiting potentially minutes to start. Performance is about the same to slightly faster overall.
2022-08-09 17:58:56 +00:00
# See that we hit the expected length
# First with "max", i.e. maximum number of characters
string repeat -m 5000 aab | string length
# CHECK: 5000
string repeat -m 5000 ab | string length
# CHECK: 5000
string repeat -m 5000 a | string length
# CHECK: 5000
string repeat -m 17 aab | string length
# CHECK: 17
string repeat -m 17 ab | string length
# CHECK: 17
string repeat -m 17 a | string length
# CHECK: 17
# Then with "count", i.e. number of repetitions.
# (these are count * length long)
string repeat -n 17 aab | string length
# CHECK: 51
string repeat -n 17 ab | string length
# CHECK: 34
string repeat -n 17 a | string length
# CHECK: 17
# And a more tricksy case with a long string that we truncate.
string repeat -m 5 (string repeat -n 500000 aaaaaaaaaaaaaaaaaa) | string length
# CHECK: 5
Fix #9899 integer overflow in string repeat We could end up overflowing if we print out something that's a multiple of the chunk size, which would then finish printing in the chunk-printing, but not break out early.
2023-07-17 12:53:03 +00:00
# might cause integer overflow
string repeat -n 2999 \n | count
# CHECK: 3000
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
# Test equivalent matches with/without the --entire, --regex, and --invert flags.
string match -e x abc dxf xyz jkx x z
or echo exit 1
# CHECK: dxf
# CHECK: xyz
# CHECK: jkx
# CHECK: x
string match x abc dxf xyz jkx x z
# CHECK: x
string match --entire -r "a*b[xy]+" abc abxc bye aaabyz kaabxz abbxy abcx caabxyxz
or echo exit 1
# CHECK: abxc
# CHECK: bye
# CHECK: aaabyz
# CHECK: kaabxz
# CHECK: abbxy
# CHECK: caabxyxz
# 'string match --entire "" -- banana'
string match --entire "" -- banana
or echo exit 1
# CHECK: banana
# 'string match -r "a*b[xy]+" abc abxc bye aaabyz kaabxz abbxy abcx caabxyxz'
string match -r "a*b[xy]+" abc abxc bye aaabyz kaabxz abbxy abcx caabxyxz
or echo exit 1
# CHECK: abx
# CHECK: by
# CHECK: aaaby
# CHECK: aabx
# CHECK: bxy
# CHECK: aabxyx
# Make sure that groups are handled correct with/without --entire.
# 'string match --entire -r "a*b([xy]+)" abc abxc bye aaabyz kaabxz abbxy abcx caabxyxz'
string match --entire -r "a*b([xy]+)" abc abxc bye aaabyz kaabxz abbxy abcx caabxyxz
or echo exit 1
# CHECK: abxc
# CHECK: x
# CHECK: bye
# CHECK: y
# CHECK: aaabyz
# CHECK: y
# CHECK: kaabxz
# CHECK: x
# CHECK: abbxy
# CHECK: xy
# CHECK: caabxyxz
# CHECK: xyx
# 'string match -r "a*b([xy]+)" abc abxc bye aaabyz kaabxz abbxy abcx caabxyxz'
string match -r "a*b([xy]+)" abc abxc bye aaabyz kaabxz abbxy abcx caabxyxz
or echo exit 1
# CHECK: abx
# CHECK: x
# CHECK: by
# CHECK: y
# CHECK: aaaby
# CHECK: y
# CHECK: aabx
# CHECK: x
# CHECK: bxy
# CHECK: xy
# CHECK: aabxyx
# CHECK: xyx
# Test `string lower` and `string upper`.
set x (string lower abc DEF gHi)
or echo string lower exit 1
Reindent functions to remove useless quotes This does not include checks/function.fish because that currently includes a "; end" in a message that indent would remove, breaking the test.
2020-03-09 18:36:12 +00:00
test $x[1] = abc -a $x[2] = def -a $x[3] = ghi
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
or echo strings not converted to lowercase
set x (echo abc DEF gHi | string lower)
or echo string lower exit 1
test $x[1] = 'abc def ghi'
or echo strings not converted to lowercase
string lower -q abc
and echo lowercasing a lowercase string did not fail as expected
set x (string upper abc DEF gHi)
or echo string upper exit 1
Reindent functions to remove useless quotes This does not include checks/function.fish because that currently includes a "; end" in a message that indent would remove, breaking the test.
2020-03-09 18:36:12 +00:00
test $x[1] = ABC -a $x[2] = DEF -a $x[3] = GHI
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
or echo strings not converted to uppercase
set x (echo abc DEF gHi | string upper)
or echo string upper exit 1
test $x[1] = 'ABC DEF GHI'
or echo strings not converted to uppercase
string upper -q ABC DEF
and echo uppercasing a uppercase string did not fail as expected
# 'Check NUL'
# Note: We do `string escape` at the end to make a `\0` literal visible.
builtin string: don't print final newline if it's missing from stdin A command like "printf nonewline | sed s/x/y/" does not print a concluding newline, whereas "printf nnl | string replace x y" does. This is an edge case -- usually the user input does have a newline at the end -- but it seems still better for this command to just forward the user's data. Teach most string subcommands to check if stdin is missing the trailing newline, and stop adding one in that case. This does not apply when input is read from commandline arguments. * Most subcommands stop adding the final newline, because they don't really care about newlines, so besides their normal processing, they just want to preserve user input. They are: * string collect * string escape/unescape * string join¹ * string lower/upper * string pad * string replace * string repeat * string sub * string trim * string match keeps adding the newline, following "grep". Additionally, for string match --regex, it's important to output capture groups separated by newlines, resulting in multiple output lines for an input line. So it is not obvious where to leave out the newline. * string split/split0 keep adding the newline for the same reason -- they are meant to output multiple elements for a single input line. ¹) string join0 is not changed because it already printed a trailing zero byte instead of the trailing newline. This is consistent with other tools like "find -print0". Closes #3847
2021-11-22 20:08:56 +00:00
printf 'a\0b\n' | string escape
printf 'a\0c\n' | string match -e a | string escape
printf 'a\0d\n' | string split '' | string escape
printf 'a\0b\n' | string match -r '.*b$' | string escape
printf 'a\0b\n' | string replace b g | string escape
printf 'a\0b\n' | string replace -r b g | string escape
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
# TODO: These do not yet work!
# printf 'a\0b' | string match '*b' | string escape
# CHECK: a\x00b
# CHECK: a\x00c
# CHECK: a
# CHECK: \x00
# CHECK: d
# CHECK: a\x00b
# CHECK: a\x00g
# CHECK: a\x00g
# string split0
count (echo -ne 'abcdefghi' | string split0)
# CHECK: 1
count (echo -ne 'abc\x00def\x00ghi\x00' | string split0)
# CHECK: 3
count (echo -ne 'abc\x00def\x00ghi\x00\x00' | string split0)
# CHECK: 4
count (echo -ne 'abc\x00def\x00ghi' | string split0)
# CHECK: 3
count (echo -ne 'abc\ndef\x00ghi\x00' | string split0)
# CHECK: 2
count (echo -ne 'abc\ndef\nghi' | string split0)
# CHECK: 1
# #5701 - split0 always returned 1
echo -ne 'a\x00b' | string split0
and echo Split something
# CHECK: a
# CHECK: b
# CHECK: Split something
# string join0
set tmp beta alpha\ngamma
count (string join \n $tmp)
# CHECK: 3
count (string join0 $tmp)
# CHECK: 2
count (string join0 $tmp | string split0)
# CHECK: 2
# string split0 in functions
# This function outputs some newline-separated content, and some
# explicitly separated content.
function dualsplit
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-13 19:34:22 +00:00
echo alpha
echo beta
echo -ne 'gamma\x00delta' | string split0
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
end
count (dualsplit)
# CHECK: 4
Correct handling of explicitly separated output when all elements are empty Previously when propagating explicitly separated output, we would early-out if the buffer was empty, where empty meant contains no characters. However it may contain one or more empty strings, in which case we should propagate those strings. Remove this footgun "empty" function and handle this properly. Fixes #5987
2019-07-21 20:53:05 +00:00
# Ensure we handle empty outputs correctly (#5987)
count (string split / /)
# CHECK: 2
count (echo -ne '\x00\x00\x00' | string split0)
# CHECK: 3
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
# string collect
count (echo one\ntwo\nthree\nfour | string collect)
count (echo one | string collect)
# CHECK: 1
# CHECK: 1
echo [(echo one\ntwo\nthree | string collect)]
# CHECK: [one
# CHECK: two
# CHECK: three]
echo [(echo one\ntwo\nthree | string collect -N)]
# CHECK: [one
# CHECK: two
# CHECK: three
# CHECK: ]
printf '[%s]\n' (string collect one\n\n two\n)
# CHECK: [one]
# CHECK: [two]
printf '[%s]\n' (string collect -N one\n\n two\n)
# CHECK: [one
New command "string pad" to pad text to a given width (#7340) Pads text to a given width, or the maximum width of all inputs.
2020-09-27 17:12:42 +00:00
# CHECK:
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
# CHECK: ]
# CHECK: [two
# CHECK: ]
printf '[%s]\n' (string collect --no-trim-newlines one\n\n two\n)
# CHECK: [one
New command "string pad" to pad text to a given width (#7340) Pads text to a given width, or the maximum width of all inputs.
2020-09-27 17:12:42 +00:00
# CHECK:
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
# CHECK: ]
# CHECK: [two
# CHECK: ]
# string collect returns 0 when it has any output, otherwise 1
string collect >/dev/null; and echo unexpected success; or echo expected failure
# CHECK: expected failure
echo -n | string collect >/dev/null; and echo unexpected success; or echo expected failure
# CHECK: expected failure
echo | string collect -N >/dev/null; and echo expected success; or echo unexpected failure
# CHECK: expected success
echo | string collect >/dev/null; and echo unexpected success; or echo expected failure
# CHECK: expected failure
string collect a >/dev/null; and echo expected success; or echo unexpected failure
# CHECK: expected success
string collect -N '' >/dev/null; and echo unexpected success; or echo expected failure
# CHECK: expected failure
string collect \n\n >/dev/null; and echo unexpected success; or echo expected failure
# CHECK: expected failure
string: Allow `collect --allow-empty` to avoid empty ellision (#8054) * string: Allow `collect --no-empty` to avoid empty ellision Currently we still have that issue where test -n (thing | string collect) can return true if `thing` doesn't print anything, because the collected argument will still be removed. So, what we do is allow `--no-empty` to be used, in which case we print one empty argument. This means test -n (thing | string collect -n) can now be safely used. "no-empty" isn't the best name for this flag, but string's design really incentivizes reusing names, and it's not *terrible*. * Switch to `--allow-empty` `--no-empty` does the exact opposite for `string split` and split0. Since `-a`/`--allow-empty` already exists, use it.
2021-07-09 19:20:58 +00:00
echo "foo"(true | string collect --allow-empty)"bar"
# CHECK: foobar
test -z (string collect)
and echo Nothing
# CHECK: Nothing
test -n (string collect)
and echo Something
# CHECK: Something
test -n (string collect -a)
or echo No, actually nothing
# CHECK: No, actually nothing
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
# string collect in functions
# This function outputs some newline-separated content, and some
# explicitly un-separated content.
function dualcollect
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-13 19:34:22 +00:00
echo alpha
echo beta
echo gamma\ndelta\nomega | string collect
Port string tests to littlecheck `wc -l tests/string.*` 329 tests/string.err 422 tests/string.in 520 tests/string.out 1271 total `wc -l tests/checks/string.fish` 555 tests/checks/string.fish and it looks nicer. 'nuff said.
2019-06-25 15:21:11 +00:00
end
count (dualcollect)
# CHECK: 3
string: Error out on `match -eq` The `--entire` would enable output even though the `--quiet` should have silenced it. These two don't make any sense together so print an error, because the user could have just left off the `-q`.
2019-10-22 19:56:44 +00:00
string match -qer asd asd
string: Allow `-eq` again Instead of forbidding it for both modes, allow it for both and make it quiet for string. Fixes #6282
2019-11-04 16:33:37 +00:00
echo $status
# CHECK: 0
Port builtins/string to Rust - Add test to verify piped string replace exit code Ensure fields parsing error messages are the same. Note: C++ relied upon the value of the parsed value even when `errno` was set, that is defined behaviour we should not rely on, and cannot easilt be replicated from Rust. Therefore the Rust version will change the following error behaviour from: ```shell > string split --fields=a "" abc string split: Invalid fields value 'a' > string split --fields=1a "" abc string split: 1a: invalid integer ``` To: ```shell > string split --fields=a "" abc string split: a: invalid integer > string split --fields=1a "" abc string split: 1a: invalid integer ```
2023-06-20 02:28:35 +00:00
# should not be able to enable UTF mode
string match -r "(*UTF).*" "aaa"
# CHECKERR: string match: Regular expression compile error: using UTF is disabled by the application
# CHECKERR: string match: (*UTF).*
# CHECKERR: string match: ^
string replace -r "(*UTF).*" "aaa"
# CHECKERR: string replace: Regular expression compile error: using UTF is disabled by the application
# CHECKERR: string replace: (*UTF).*
# CHECKERR: string replace: ^
string: Allow `-eq` again Instead of forbidding it for both modes, allow it for both and make it quiet for string. Fixes #6282
2019-11-04 16:33:37 +00:00
string match -eq asd asd
echo $status
# CHECK: 0
string: Handle unmatched capturing groups as empty Instead of erroring out. Fixes #7343.
2020-09-20 08:33:04 +00:00
# Unmatched capturing groups are treated as empty
string pad: handle padding characters of width > 1 If the padding is not divisible by the char's width without remainder, we pad the remainder with spaces, so the total width of the output is correct. Also add completions, changelog entry, adjust documentation, add examples with emoji and some tests. Apply some minor style nitpicks and avoid extra allocations of the input strings.
2020-09-27 19:51:20 +00:00
echo az | string replace -r -- 'a(b.+)?z' 'a:$1z'
string: Handle unmatched capturing groups as empty Instead of erroring out. Fixes #7343.
2020-09-20 08:33:04 +00:00
# CHECK: a:z
string: Quit early if --quiet is satisfied E.g. if we do `string match -q`, and we find a match, nothing about the input can change anything, so we quit early. This is mainly useful for performance, but it also allows `string` with `-q` to be used with infinite input (e.g. `yes`). Alternative to #7495.
2020-11-29 11:06:48 +00:00
# --quiet should quit early
echo "Checking that --quiet quits early - if this is broken it hangs"
# CHECK: Checking that --quiet quits early - if this is broken it hangs
yes | string match -q y
echo $status
# CHECK: 0
yes | string length -q
echo $status
# CHECK: 0
yes | string replace -q y n
echo $status
# CHECK: 0
Add `string` to reserved keywords Since `string match` now creates variables, wrapping `string` necessarily breaks things, so we need to disallow it. See #7459, #7509.
2020-12-06 14:31:04 +00:00
# `string` can't be wrapped properly anymore, since `string match` creates variables:
function string
builtin string $argv
end
Update tests for changed error output
2021-11-04 05:52:17 +00:00
# CHECKERR: checks/string.fish (line {{\d+}}): function: string: cannot use reserved keyword as function name
Add `string` to reserved keywords Since `string match` now creates variables, wrapping `string` necessarily breaks things, so we need to disallow it. See #7459, #7509.
2020-12-06 14:31:04 +00:00
# CHECKERR: function string
# CHECKERR: ^
escape_string_script: Escape DEL as \x7f This used to print a literal DEL character in the output for `bind`, which wouldn't actually show up and made it hard to figure out what the key was. So we just escape it back to how we actually used it - `\x7f`. Fixes #7631.
2021-01-16 11:49:49 +00:00
string escape \x7F
# CHECK: \x7f
Fix crash in string pad Try: string pad -w 8 he \eh
2021-03-09 17:32:15 +00:00
# This used to crash.
string pad -w 8 he \eh
# CHECK: he
# CHECK: {{\x1bh}}
string: Add "--groups-only" to match This adds a simple way of picking bits from a string that might be a bit nicer than having to resort to a full `replace`. Fixes #6056
2019-06-11 14:05:24 +00:00
string match -rg '(.*)fish' catfish
# CHECK: cat
string match -rg '(.*)fish' shellfish
# CHECK: shell
# An empty match
string match -rg '(.*)fish' fish
# No match at all
string match -rg '(.*)fish' banana
# Make sure it doesn't start matching something
string match -r --groups-only '(.+)fish' fish
echo $status
# CHECK: 1
# Multiple groups
string match -r --groups-only '(.+)fish(.*)' catfishcolor
# CHECK: cat
# CHECK: color
# Examples specifically called out in #6056.
echo "foo bar baz" | string match -rg 'foo (bar) baz'
# CHECK: bar
echo "foo1x foo2x foo3x" | string match -arg 'foo(\d)x'
# CHECK: 1
# CHECK: 2
# CHECK: 3
builtin string: don't print final newline if it's missing from stdin A command like "printf nonewline | sed s/x/y/" does not print a concluding newline, whereas "printf nnl | string replace x y" does. This is an edge case -- usually the user input does have a newline at the end -- but it seems still better for this command to just forward the user's data. Teach most string subcommands to check if stdin is missing the trailing newline, and stop adding one in that case. This does not apply when input is read from commandline arguments. * Most subcommands stop adding the final newline, because they don't really care about newlines, so besides their normal processing, they just want to preserve user input. They are: * string collect * string escape/unescape * string join¹ * string lower/upper * string pad * string replace * string repeat * string sub * string trim * string match keeps adding the newline, following "grep". Additionally, for string match --regex, it's important to output capture groups separated by newlines, resulting in multiple output lines for an input line. So it is not obvious where to leave out the newline. * string split/split0 keep adding the newline for the same reason -- they are meant to output multiple elements for a single input line. ¹) string join0 is not changed because it already printed a trailing zero byte instead of the trailing newline. This is consistent with other tools like "find -print0". Closes #3847
2021-11-22 20:08:56 +00:00
# Most subcommands preserve missing newline (#3847).
echo -n abc | string upper
echo '<eol>'
# CHECK: ABC<eol>
Port builtins/string to Rust - Add test to verify piped string replace exit code Ensure fields parsing error messages are the same. Note: C++ relied upon the value of the parsed value even when `errno` was set, that is defined behaviour we should not rely on, and cannot easilt be replicated from Rust. Therefore the Rust version will change the following error behaviour from: ```shell > string split --fields=a "" abc string split: Invalid fields value 'a' > string split --fields=1a "" abc string split: 1a: invalid integer ``` To: ```shell > string split --fields=a "" abc string split: a: invalid integer > string split --fields=1a "" abc string split: 1a: invalid integer ```
2023-06-20 02:28:35 +00:00
# newline should not appear from nowhere when command does not split on newline
echo -n abc | string collect
echo '<eol>'
# CHECK: abc<eol>
builtin string: don't print final newline if it's missing from stdin A command like "printf nonewline | sed s/x/y/" does not print a concluding newline, whereas "printf nnl | string replace x y" does. This is an edge case -- usually the user input does have a newline at the end -- but it seems still better for this command to just forward the user's data. Teach most string subcommands to check if stdin is missing the trailing newline, and stop adding one in that case. This does not apply when input is read from commandline arguments. * Most subcommands stop adding the final newline, because they don't really care about newlines, so besides their normal processing, they just want to preserve user input. They are: * string collect * string escape/unescape * string join¹ * string lower/upper * string pad * string replace * string repeat * string sub * string trim * string match keeps adding the newline, following "grep". Additionally, for string match --regex, it's important to output capture groups separated by newlines, resulting in multiple output lines for an input line. So it is not obvious where to leave out the newline. * string split/split0 keep adding the newline for the same reason -- they are meant to output multiple elements for a single input line. ¹) string join0 is not changed because it already printed a trailing zero byte instead of the trailing newline. This is consistent with other tools like "find -print0". Closes #3847
2021-11-22 20:08:56 +00:00
printf \<
printf my-password | string replace -ra . \*
printf \>\n
# CHECK: <***********>
Add string shorten This is essentially the inverse of `string pad`. Where that adds characters to get up to the specified width, this adds an ellipsis to a string if it goes over a specific maximum width. The char can be given, but defaults to our ellipsis string. ("…" if the locale can handle it and "..." otherwise) If the ellipsis string is empty, it just truncates. For arguments given via argv, it goes line-by-line, because otherwise length makes no sense. If "--no-newline" is given, it adds an ellipsis instead and removes all subsequent lines. Like pad and `length --visible`, it goes by visible width, skipping recognized escape sequences, as those have no influence on width. The default target width is the shortest of the given widths that is non-zero. If the ellipsis is already wider than the target width, we truncate instead. This is safer overall, so we don't e.g. move into a new line. This is especially important given our default ellipsis might be width 3.
2022-08-16 15:57:19 +00:00
string shorten -m 3 foo
# CHECK: foo
string shorten -m 2 foo
# CHECK: f…
string shorten -m 5 foobar
# CHECK: foob…
# Char is longer than width, we truncate instead.
string shorten -m 5 --char ........ foobar
# CHECK: fooba
string shorten --max 4 -c /// foobar
# CHECK: f///
string shorten --max 4 -c /// foobarnana
# CHECK: f///
string shorten --max 2 --chars "" foo
# CHECK: fo
string shorten foo foobar
# CHECK: foo
# CHECK: fo…
Fix behaviour in the presence of non-visible width Padding with an unprintable character is now disallowed, like it was for other zero-length characters. `string shorten` now ignores escape sequences and non-printable characters when calculating the visible width of the ellipsis used (except for `\b`, which is treated as a width of -1). Previously `fish_wcswidth` returned a length of -1 when the ellipsis-str contained any non-printable character, causing the command to poentially print a larger width than expected. This also fixes an integer overflows in `string shorten`'s `max` and `max2`, when the cumulative sum of character widths turned negative (e.g. with any non-printable characters, or `\b` after the changes above). The overflow potentially caused strings containing non-printable characters to be truncated. This adds test that verify the fixed behaviour.
2023-07-13 02:17:19 +00:00
# pad with a bell, it has zero width, that's fine
string shorten -c \a foo foobar | string escape
# CHECK: foo
# CHECK: foo\cg
string shorten -c \aw foo foobar | string escape
# CHECK: foo
# CHECK: fo\cgw
# backspace is fine!
string shorten -c \b foo foobar | string escape
# CHECK: foo
# CHECK: foo\b
string shorten -c \ba foo foobar | string escape
# CHECK: foo
# CHECK: fo\ba
string shorten -c cool\b\b\b\b foo foobar | string escape
# CHECK: foo
# CHECK: foocool\b\b\b\b
string shorten -c cool\b\b\b\b\b foo foobar | string escape
# CHECK: foo
# negative width ellipsis is fine
# CHECK: foocool\b\b\b\b\b
string shorten -c \a\aXX foo foobar | string escape
# CHECK: foo
# CHECK: f\cg\cgXX
Add string shorten This is essentially the inverse of `string pad`. Where that adds characters to get up to the specified width, this adds an ellipsis to a string if it goes over a specific maximum width. The char can be given, but defaults to our ellipsis string. ("…" if the locale can handle it and "..." otherwise) If the ellipsis string is empty, it just truncates. For arguments given via argv, it goes line-by-line, because otherwise length makes no sense. If "--no-newline" is given, it adds an ellipsis instead and removes all subsequent lines. Like pad and `length --visible`, it goes by visible width, skipping recognized escape sequences, as those have no influence on width. The default target width is the shortest of the given widths that is non-zero. If the ellipsis is already wider than the target width, we truncate instead. This is safer overall, so we don't e.g. move into a new line. This is especially important given our default ellipsis might be width 3.
2022-08-16 15:57:19 +00:00
# A weird case - our minimum width here is 1,
# so everything that goes over the width becomes "x"
for i in (seq 1 10)
math 2 ^ $i
end | string shorten -c x
# CHECK: 2
# CHECK: 4
# CHECK: 8
# CHECK: x
# CHECK: x
# CHECK: x
# CHECK: x
# CHECK: x
# CHECK: x
# CHECK: x
string shorten -N -cx bar\nfooo
# CHECK: barx
# Shorten and emoji width.
begin
# \U1F4A9 was widened in unicode 9, so it's affected
# by $fish_emoji_width
# "…" isn't and always has width 1.
#
# "abcde" has width 5, we have a total width of 6,
# so we need to overwrite the "e" with our ellipsis.
fish_emoji_width=1 string shorten --max=5 -- abcde💩
# CHECK: abcd…
# This fits assuming the poo fits in one column
fish_emoji_width=1 string shorten --max=6 -- abcde💩
# CHECK: abcde💩
# This has a total width of 7 (assuming double-wide poo),
# so we need to add the ellipsis on the "e"
fish_emoji_width=2 string shorten --max=5 -- abcde💩
# CHECK: abcd…
# This still doesn't fit!
fish_emoji_width=2 string shorten --max=6 -- abcde💩
# CHECK: abcde…
fish_emoji_width=2 string shorten --max=7 -- abcde💩
# CHECK: abcde💩
end
# See that colors aren't counted
string shorten -m6 (set_color blue)s(set_color red)t(set_color --bold brwhite)rin(set_color red)g(set_color yellow)-shorten | string escape
# Renders like "strin…" in colors
# Note that red sequence that we still pass on because it's width 0.
# CHECK: \e\[34ms\e\[31mt\e\[1m\e\[37mrin\e\[31m…
Fix behaviour in the presence of non-visible width Padding with an unprintable character is now disallowed, like it was for other zero-length characters. `string shorten` now ignores escape sequences and non-printable characters when calculating the visible width of the ellipsis used (except for `\b`, which is treated as a width of -1). Previously `fish_wcswidth` returned a length of -1 when the ellipsis-str contained any non-printable character, causing the command to poentially print a larger width than expected. This also fixes an integer overflows in `string shorten`'s `max` and `max2`, when the cumulative sum of character widths turned negative (e.g. with any non-printable characters, or `\b` after the changes above). The overflow potentially caused strings containing non-printable characters to be truncated. This adds test that verify the fixed behaviour.
2023-07-13 02:17:19 +00:00
# See that colors aren't counted in ellipsis
string shorten -c (set_color blue)s(set_color red)t(set_color --bold brwhite)rin(set_color red)g -m 8 abcdefghijklmno | string escape
# Renders like "abstring" in colors
# CHECK: ab\e\[34ms\e\[31mt\e\[1m\e\[37mrin\e\[31mg
Add string shorten This is essentially the inverse of `string pad`. Where that adds characters to get up to the specified width, this adds an ellipsis to a string if it goes over a specific maximum width. The char can be given, but defaults to our ellipsis string. ("…" if the locale can handle it and "..." otherwise) If the ellipsis string is empty, it just truncates. For arguments given via argv, it goes line-by-line, because otherwise length makes no sense. If "--no-newline" is given, it adds an ellipsis instead and removes all subsequent lines. Like pad and `length --visible`, it goes by visible width, skipping recognized escape sequences, as those have no influence on width. The default target width is the shortest of the given widths that is non-zero. If the ellipsis is already wider than the target width, we truncate instead. This is safer overall, so we don't e.g. move into a new line. This is especially important given our default ellipsis might be width 3.
2022-08-16 15:57:19 +00:00
set -l str (set_color blue)s(set_color red)t(set_color --bold brwhite)rin(set_color red)g(set_color yellow)-shorten
for i in (seq 1 (string length -V -- $str))
set -l len (string shorten -m$i -- $str | string length -V)
test $len = $i
or echo Oopsie ellipsizing to $i failed
end
string shorten -m4 foobar\nbananarama
# CHECK: foo…
# CHECK: ban…
# First line is empty and printed as-is
# The other lines are truncated to the width of the first real line.
printf '
1. line
2. another line
3. third line' | string shorten
# CHECK:
# CHECK: 1. line
# CHECK: 2. ano…
# CHECK: 3. thi…
printf '
1. line
2. another line
3. third line' | string shorten --left
# CHECK:
# CHECK: 1. line
# CHECK: …r line
# CHECK: …d line
string shorten -m12 -l (set_color blue)s(set_color red)t(set_color --bold brwhite)rin(set_color red)(set_color green)g(set_color yellow)-shorten | string escape
# Renders like "…ing-shorten" with g in green and "-shorten" in yellow
# Yes, that's a "red" escape before.
# CHECK: …in\e\[31m\e\[32mg\e\[33m-shorten
set -l str (set_color blue)s(set_color red)t(set_color --bold brwhite)rin(set_color red)g(set_color yellow)-shorten
for i in (seq 1 (string length -V -- $str))
set -l len (string shorten -m$i --left -- $str | string length -V)
test $len = $i
or echo Oopsie ellipsizing to $i failed
end
string shorten: Make max of 0 mean no shortening This makes it easier to just slot in `string shorten` wherever, without having to do a weird "if test $max -gt 0" check.
2022-10-04 16:44:21 +00:00
string shorten -m0 foo bar asodjsaoidj
# CHECK: foo
# CHECK: bar
# CHECK: asodjsaoidj
Fix behaviour in the presence of non-visible width Padding with an unprintable character is now disallowed, like it was for other zero-length characters. `string shorten` now ignores escape sequences and non-printable characters when calculating the visible width of the ellipsis used (except for `\b`, which is treated as a width of -1). Previously `fish_wcswidth` returned a length of -1 when the ellipsis-str contained any non-printable character, causing the command to poentially print a larger width than expected. This also fixes an integer overflows in `string shorten`'s `max` and `max2`, when the cumulative sum of character widths turned negative (e.g. with any non-printable characters, or `\b` after the changes above). The overflow potentially caused strings containing non-printable characters to be truncated. This adds test that verify the fixed behaviour.
2023-07-13 02:17:19 +00:00
# backspaces are weird
string shorten abc ab abcdef(string repeat -n 6 \b) | string escape
# CHECK: a…
# CHECK: ab
# this line has length zero, since backspace removes it all
# CHECK: abcdef\b\b\b\b\b\b
# due to an integer overflow this might truncate the third backspaced one, it should not
string shorten abc ab abcdef(string repeat -n 7 \b) | string escape
# CHECK: a…
# CHECK: ab
# this line has length zero, since backspace removes it all
# CHECK: abcdef\b\b\b\b\b\b\b
# due to an integer overflow this might truncate
string shorten abc \bab ab abcdef | string escape
# CHECK: a…
# backspace does not contribute length at the start
# CHECK: \bab
# CHECK: ab
# CHECK: a…
string shorten abc \babc ab abcdef | string escape
# CHECK: a…
# CHECK: \ba…
# CHECK: ab
# CHECK: a…
# non-printable-escape-chars (in this case bell)
string shorten abc ab abcdef(string repeat -n 6 \a) | string escape
# CHECK: a…
# CHECK: ab
# CHECK: a…
string shorten abc ab abcdef(string repeat -n 7 \a) | string escape
# CHECK: a…
# CHECK: ab
# CHECK: a…
string shorten abc \aab ab abcdef | string escape
# CHECK: a…
# non-printables have length 0
# CHECK: \cgab
# CHECK: ab
# CHECK: a…
string shorten abc \aabc ab abcdef | string escape
# CHECK: a…
# CHECK: \cga…
# CHECK: ab
# CHECK: a…
Add tests for `string match/replace --max-matches`
2024-06-27 03:46:50 +00:00
printf "dog\ncat\nbat\ngnat\n" | string match -m2 "*at"
# CHECK: cat
# CHECK: bat
printf "dog\ncat\nbat\nhog\n" | string match -rvm1 'at$'
# CHECK: dog
printf "dog\ncat\nbat\n" | string replace -rf --max-matches 1 'at$' 'aught'
# CHECK: caught
printf "dog\ncat\nbat\n" | string replace -r --max-matches 1 '^c' 'h'
# CHECK: dog
# CHECK: hat
Reference in a new issue Copy permalink