Mirrors/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell synced 2024-12-28 05:43:11 +00:00
Code Issues Projects Releases Packages Wiki Activity
fish-shell/tests/checks/eval.fish

85 lines
1.7 KiB
Fish
Raw Normal View History

Extended & human-friendly keys See the changelog additions for user-visible changes. Since we enable/disable terminal protocols whenever we pass terminal ownership, tests can no longer run in parallel on the same terminal. For the same reason, readline shortcuts in the gdb REPL will not work anymore. As a remedy, use gdbserver, or lobby for CSI u support in libreadline. Add sleep to some tests, otherwise they fall (both in CI and locally). There are two weird failures on FreeBSD remaining, disable them for now https://github.com/fish-shell/fish-shell/pull/10359/checks?check_run_id=23330096362 Design and implementation borrows heavily from Kakoune. In future, we should try to implement more of the kitty progressive enhancements. Closes #10359
2024-03-30 15:10:12 +00:00
# RUN: %fish %s | %filter-ctrlseqs
Port eval tests to littlecheck
2019-07-03 10:54:42 +00:00
# Regression test for issue #4443
eval set -l previously_undefined foo
echo $previously_undefined
# CHECK: foo
# Test redirection
eval "echo you can\\'t see this 1>&2" 2>/dev/null
# Test return statuses
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-13 19:34:22 +00:00
false
eval true
echo $status
Port eval tests to littlecheck
2019-07-03 10:54:42 +00:00
# CHECK: 0
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-13 19:34:22 +00:00
false
eval false
echo $status
Port eval tests to littlecheck
2019-07-03 10:54:42 +00:00
# CHECK: 1
# Test return status in case of parsing error
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-13 19:34:22 +00:00
false
eval "("
echo $status
Rationalize $status and errors Prior to this fix, fish was rather inconsistent in when $status gets set in response to an error. For example, a failed expansion like "$foo[" would not modify $status. This makes the following inter-related changes: 1. String expansion now directly returns the value to set for $status on error. The value is always used. 2. parser_t::eval() now directly returns the proc_status_t, which cleans up a lot of call sites. 3. We expose a new function exec_subshell_for_expand() which ignores $status but returns errors specifically related to subshell expansion. 4. We reify the notion of "expansion breaking" errors. These include command-not-found, expand syntax errors, and others. The upshot is we are more consistent about always setting $status on errors.
2020-01-24 01:34:46 +00:00
# CHECK: 123
eval tests: Fix path I tested this manually (`littlecheck.py -s fish=fish tests/checks/eval.fish`) from the base directory, which means I got "tests/checks/eval", while the real test gets "checks/eval". I then reran `make test_fishscript`, but that didn't pull in the updated test - we should really handle that better.
2019-07-03 13:14:49 +00:00
# CHECKERR: {{.*}}checks/eval.fish (line {{\d+}}): Unexpected end of string, expecting ')'
Port eval tests to littlecheck
2019-07-03 10:54:42 +00:00
# CHECKERR: (
# CHECKERR: ^
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-13 19:34:22 +00:00
false
eval '""'
echo $status
Rationalize $status and errors Prior to this fix, fish was rather inconsistent in when $status gets set in response to an error. For example, a failed expansion like "$foo[" would not modify $status. This makes the following inter-related changes: 1. String expansion now directly returns the value to set for $status on error. The value is always used. 2. parser_t::eval() now directly returns the proc_status_t, which cleans up a lot of call sites. 3. We expose a new function exec_subshell_for_expand() which ignores $status but returns errors specifically related to subshell expansion. 4. We reify the notion of "expansion breaking" errors. These include command-not-found, expand syntax errors, and others. The upshot is we are more consistent about always setting $status on errors.
2020-01-24 01:34:46 +00:00
# CHECK: 123
eval tests: Fix path I tested this manually (`littlecheck.py -s fish=fish tests/checks/eval.fish`) from the base directory, which means I got "tests/checks/eval", while the real test gets "checks/eval". I then reran `make test_fishscript`, but that didn't pull in the updated test - we should really handle that better.
2019-07-03 13:14:49 +00:00
# CHECKERR: {{.*}}checks/eval.fish (line {{\d+}}): The expanded command was empty.
Port eval tests to littlecheck
2019-07-03 10:54:42 +00:00
# CHECKERR: ""
Add more tests These were correct, but littlecheck escapes quotes!
2022-08-11 16:20:40 +00:00
# CHECKERR: ^^
Port eval tests to littlecheck
2019-07-03 10:54:42 +00:00
function empty
end
# Regression tests for issue #5692
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-13 19:34:22 +00:00
false
eval
Port eval tests to littlecheck
2019-07-03 10:54:42 +00:00
echo blank eval: $status # 0
# CHECK: blank eval: 0
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-13 19:34:22 +00:00
false
eval ""
Port eval tests to littlecheck
2019-07-03 10:54:42 +00:00
echo empty arg eval: $status # 0
# CHECK: empty arg eval: 0
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-13 19:34:22 +00:00
false
eval empty
Port eval tests to littlecheck
2019-07-03 10:54:42 +00:00
echo empty function eval $status # 0
# CHECK: empty function eval 0
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-13 19:34:22 +00:00
false
eval "begin; end;"
Port eval tests to littlecheck
2019-07-03 10:54:42 +00:00
echo empty block eval: $status # 0
# CHECK: empty block eval: 0
source: Escape filenames in errors Otherwise this would look weird if you had, say, a tab in there. See #7716. (note that this doesn't handle e.g. zero-width-joiners, because those aren't currently escaped. we might want to add an escape mode for unprintable characters, but for combining codepoints that's tricky!)
2021-02-15 16:06:43 +00:00
source /banana/\t/foo
# CHECKERR: source: Error encountered while sourcing file '/banana/\t/foo':
# CHECKERR: source: No such file or directory
Make `eval` a reserved keyword Like `set` and `read` before it, `eval` can be used to set variables, and so it can't be shadowed by a function without loss of functionality. So this forbids it. Incidentally, this means we will no longer try to autoload an `eval.fish` file that's left over from an old version, which would have helped with #8963.
2022-05-18 16:47:10 +00:00
# See that eval can't be defined as a function
function eval
builtin eval $argv
end
# CHECKERR: checks/eval.fish (line {{\d+}}): function: eval: cannot use reserved keyword as function name
# CHECKERR: function eval
# CHECKERR: ^
function evil --no-scope-shadowing
eval $argv
end
# And this is why we do this: `eval` *can't* be cleanly shadowed with a function,
# because that would always introduce a new block or at the very least clobber $argv.
eval set -l argv this works
echo $argv
# CHECK: this works
evil set -l argv this does not
echo $argv
# CHECK: this works
Reference in a new issue Copy permalink