Make tests usable with path with spaces
This is somewhat subtle:
The #RUN line in a littlecheck file will be run by a posix shell,
which means the substitutions will also be mangled by it.
Now, we *have* shell-quoted them, but unfortunately what we need is to
quote them for inside a pre-existing layer of quotes, e.g.
# RUN: fish -C 'set -g fish %fish'
here, %fish can't be replaced with `'path with spaces/fish'`, because
that ends up as
# RUN: fish -C 'set -g fish 'path with spaces/fish''
which is just broken.
So instead, we pass it as a variable to that fish:
# RUN: fish=%fish fish...
In addition, we need to not mangle the arguments in our test_driver.
For that, because we insist on posix shell, which has only one array,
and we source a file, we *need* to stop having that file use
arguments.
Which is okay - test_env.sh could previously be used to start a test,
and now it no longer can because that is test_*driver*.sh's job.
For the interactive tests, it's slightly different:
pexpect.spawn(foo) is sensitive to shell metacharacters like space.
So we shell-quote it.
But if you pass any args to pexpect.spawn, it no longer uses a shell,
and so we cannot shell-quote it.
There could be a better way to fix this?
2024-12-27 19:54:43 +00:00
|
|
|
#RUN: fish=%fish %fish %s
|
2024-12-28 12:05:58 +00:00
|
|
|
|
|
|
|
|
# Set a XDG_CONFIG_HOME with both pre-existing and non-existing directories.
|
|
|
|
|
set -l dir (mktemp -d)
|
|
|
|
|
mkdir -m 0755 $dir/old
|
|
|
|
|
set -gx XDG_CONFIG_HOME $dir/old/new
|
|
|
|
|
|
|
|
|
|
# Launch fish so it will create all missing directories.
|
|
|
|
|
$fish -c ''
|
|
|
|
|
|
|
|
|
|
# Check that existing directories kept their permissions, and new directories
|
|
|
|
|
# have the right permissions according to the XDG Base Directory Specification.
|
|
|
|
|
ls -ld $dir/old $dir/old/new $dir/old/new/fish | awk '{print $1}'
|
|
|
|
|
# CHECK: drwxr-xr-x
|
|
|
|
|
# CHECK: drwx------
|
|
|
|
|
# CHECK: drwx------
|
